From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752207AbbJWOm0 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 23 Oct 2015 10:42:26 -0400
Received: from mail-pa0-f48.google.com ([209.85.220.48]:34484 "EHLO
	mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751256AbbJWOmY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 23 Oct 2015 10:42:24 -0400
Subject: Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper
To: Peter Zijlstra <peterz@infradead.org>
References: <1445559014-4667-1-git-send-email-ast@kernel.org>
 <20151023120335.GZ17308@twins.programming.kicks-ass.net>
Cc: "David S. Miller" <davem@davemloft.net>, Ingo Molnar <mingo@kernel.org>,
        Wang Nan <wangnan0@huawei.com>, He Kuang <hekuang@huawei.com>,
        Kaixu Xia <xiakaixu@huawei.com>,
        Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Alexei Starovoitov <ast@plumgrid.com>
Message-ID: <562A474E.6040401@plumgrid.com>
Date: Fri, 23 Oct 2015 07:42:22 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151023120335.GZ17308@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/23/15 5:03 AM, Peter Zijlstra wrote:
> So the bpf_perf_event_read() returns the count value, does this not also
> mean that returning -EINVAL here is also 'wrong'?
>
> I mean, sure an actual count value that high is unlikely, but its still
> a broken interface.

Agree. that's not pretty interface. I wish I looked at it more carefully
when it was introduced. Now it's too late to change.