Re: [PATCH v3 3/7] vfio: platform: introduce module_vfio_reset_handler macro

Arnd Bergmann
2015-10-23T13:09:44Z

On Friday 23 October 2015 14:37:11 Eric Auger wrote:
> +static int __init reset ## _module_init(void) \
> +{ \
> + vfio_platform_register_reset(compat, reset); \
> + return 0; \
> +}; \
>

I would make this 'return vfio_platform_register_reset(...)', so loading
the driver fails if the handler cannot get registered. Alternatively,
change the return type of vfio_platform_register_reset to 'void'
so it can never fail.

Arnd