From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177AbbJXBVB (ORCPT ); Fri, 23 Oct 2015 21:21:01 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34270 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752528AbbJXBU7 (ORCPT ); Fri, 23 Oct 2015 21:20:59 -0400 To: linux-kernel@vger.kernel.org From: Chris Subject: hid-sony appears to be broken for some (new?) DualShock 4 controllers Message-ID: <562ADCFA.7060109@gmail.com> Date: Fri, 23 Oct 2015 21:20:58 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I have a brand new DualShock 4 and the descriptor is a different size than what the hid-sony driver expects. This causes the controller to not work at all over wireless except for the trackpad. On USB it sort of works but the motion sense does not. This affects kernels starting at 3.15 all the way to the current 4.3rc6. In sony_report_fixup() it looks for a size of 467 for USB or 357 for Bluetooth but my controller's descriptor size is 499 USB and 365 BT. I changed the sizes and the controller seems to be fully functional now. Is the descriptor size check actually even necessary? Don't all DS4's require the modified descriptor table regardless? I don't know. These are the changes I made against 4.3rc6: --- diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index 661f94f..d93a6a8 100644 --- a/drivers/hid/hid-sony.c +++ b/drivers/hid/hid-sony.c @@ -1137,11 +1137,11 @@ static __u8 *sony_report_fixup(struct hid_device *hdev, __u8 *rdesc, * the gyroscope values to corresponding axes so we need a * modified one. */ - if ((sc->quirks & DUALSHOCK4_CONTROLLER_USB) && *rsize == 467) { + if ((sc->quirks & DUALSHOCK4_CONTROLLER_USB) && (*rsize == 467 || *rsize == 499)) { hid_info(hdev, "Using modified Dualshock 4 report descriptor with gyroscope axes\n"); rdesc = dualshock4_usb_rdesc; *rsize = sizeof(dualshock4_usb_rdesc); - } else if ((sc->quirks & DUALSHOCK4_CONTROLLER_BT) && *rsize == 357) { + } else if ((sc->quirks & DUALSHOCK4_CONTROLLER_BT) && (*rsize == 357 || *rsize == 365)) { hid_info(hdev, "Using modified Dualshock 4 Bluetooth report descriptor\n"); rdesc = dualshock4_bt_rdesc; *rsize = sizeof(dualshock4_bt_rdesc);