From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145AbbJXQaq (ORCPT ); Sat, 24 Oct 2015 12:30:46 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:36038 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbbJXQao (ORCPT ); Sat, 24 Oct 2015 12:30:44 -0400 Subject: Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port To: Douglas Anderson References: <1445624891-31680-1-git-send-email-dianders@chromium.org> Cc: heiko@sntech.de, kishon@ti.com, johnyoun@synopsys.com, balbi@ti.com, gregkh@linuxfoundation.org, lyz@rock-chips.com, wulf@rock-chips.com, mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, galak@codeaurora.org, gregory.herrero@intel.com, paulz@synopsys.com, linux-arm-kernel@lists.infradead.org From: Rob Herring X-Enigmail-Draft-Status: N1110 Message-ID: <562B9F5F.1080800@kernel.org> Date: Sat, 24 Oct 2015 10:10:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445624891-31680-1-git-send-email-dianders@chromium.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/2015 01:28 PM, Douglas Anderson wrote: > The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 > has a hardware errata that causes everything to get confused when we get > a remote wakeup. It appears that the "port reset" bit that's in the USB > phy (located in the rk3288 GRF) fixes things up and appears safe to do. > > This series of patches exports the "port reset" from the PHY and then > hooks it up to dwc2 through a quirk. > > I've tested this series atop a bit of a conglomeration of Heiko's github > "somewhat stable" branch (v4.3-rc3-876-g6509232) but with Greg KH's > usb-next merged in. > > These patches currently conflict with patches that I posted previously > to enable USB wakeup from S3, specifically: > * https://patchwork.kernel.org/patch/6727081/ > * https://patchwork.kernel.org/patch/6727121/ > ...those patches no longer apply anyway, so presumably they need to be > reposted and I can do so later atop these patches. > > > Douglas Anderson (4): > phy: rockchip-usb: Support the PHY's "port reset" > usb: dwc2: optionally assert phy "port reset" when waking up > ARM: dts: rockchip: Enable the USB phys as reset providers on rk3288 > ARM: dts: rockchip: Point rk3288 dwc2 usb at phy port reset > > .../devicetree/bindings/phy/rockchip-usb-phy.txt | 6 ++ > Documentation/devicetree/bindings/usb/dwc2.txt | 7 ++ > arch/arm/boot/dts/rk3288.dtsi | 8 +++ > drivers/phy/phy-rockchip-usb.c | 74 ++++++++++++++++++++++ > drivers/usb/dwc2/core.h | 5 ++ > drivers/usb/dwc2/core_intr.c | 7 ++ > drivers/usb/dwc2/platform.c | 13 ++++ > 7 files changed, 120 insertions(+) A DT reset controller seems like a bit of an overkill here. I think this would be much more simple if we just add a phy reset hook to the phy subsystem. Rob >