From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753218AbbJXQMh (ORCPT ); Sat, 24 Oct 2015 12:12:37 -0400 Received: from mga01.intel.com ([192.55.52.88]:39312 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751987AbbJXQMf (ORCPT ); Sat, 24 Oct 2015 12:12:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,193,1444719600"; d="scan'208";a="670953514" Message-ID: <562BADE7.4010105@intel.com> Date: Sun, 25 Oct 2015 00:12:23 +0800 From: "Lan, Tianyu" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Alexander Duyck , bhelgaas@google.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, eddie.dong@intel.com, nrupal.jani@intel.com, yang.z.zhang@intel.com, agraf@suse.de, kvm@vger.kernel.org, pbonzini@redhat.com, qemu-devel@nongnu.org, emil.s.tantilov@intel.com, intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com, john.ronciak@intel.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, matthew.vick@intel.com, mitch.a.williams@intel.com, netdev@vger.kernel.org, shannon.nelson@intel.com Subject: Re: [RFC Patch 08/12] IXGBEVF: Rework code of finding the end transmit desc of package References: <1445445464-5056-1-git-send-email-tianyu.lan@intel.com> <1445445464-5056-9-git-send-email-tianyu.lan@intel.com> <56280050.9020301@gmail.com> In-Reply-To: <56280050.9020301@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/22/2015 5:14 AM, Alexander Duyck wrote: > Where is i being initialized? It was here but you removed it. Are you > using i without initializing it? Sorry, the initialization was put into patch 10 by mistake. "i" is assigned with "tx_ring->next_to_clean".