From: Jonathan Cameron <jic23@kernel.org>
To: Michael Welling <mwelling@ieee.org>,
Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Andrea Galbusera <gizero@gmail.com>,
linux-iio@vger.kernel.org, Peter Meerwald <pmeerw@pmeerw.net>,
Lars-Peter Clausen <lars@metafoo.de>,
Manfred Schlaegl <manfred.schlaegl@gmx.at>,
Hartmut Knaack <knaack.h@gmx.de>
Subject: Re: [PATCH 2/2] iio: adc: mcp320x: Add compatible with vendor prefix to OF table
Date: Sun, 25 Oct 2015 12:37:45 +0000 [thread overview]
Message-ID: <562CCD19.5090004@kernel.org> (raw)
In-Reply-To: <20151014152753.GB29846@deathstar>
On 14/10/15 16:27, Michael Welling wrote:
> On Wed, Oct 14, 2015 at 02:54:39PM +0200, Javier Martinez Canillas wrote:
>> The driver Device Tree binding now documents compatible strings that have
>> a vendor prefix, so add these to the OF device ID table to match and mark
>> the old ones as deprecated explaining that should not be used anymore.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>> drivers/iio/adc/mcp320x.c | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
>> index 41a21e986c1a..9fcb8b61e300 100644
>> --- a/drivers/iio/adc/mcp320x.c
>> +++ b/drivers/iio/adc/mcp320x.c
>> @@ -354,6 +354,7 @@ static int mcp320x_remove(struct spi_device *spi)
>>
>> #if defined(CONFIG_OF)
>> static const struct of_device_id mcp320x_dt_ids[] = {
>> + /* NOTE: The use of compatibles with no vendor prefix is deprecated. */
>> {
>> .compatible = "mcp3001",
>> .data = &mcp320x_chip_infos[mcp3001],
>> @@ -382,6 +383,33 @@ static const struct of_device_id mcp320x_dt_ids[] = {
>> .compatible = "mcp3301",
>> .data = &mcp320x_chip_infos[mcp3301],
>> }, {
>> + .compatible = "microchip,mcp3001",
>> + .data = &mcp320x_chip_infos[mcp3001],
>> + }, {
>> + .compatible = "microchip,mcp3002",
>> + .data = &mcp320x_chip_infos[mcp3002],
>> + }, {
>> + .compatible = "microchip,mcp3004",
>> + .data = &mcp320x_chip_infos[mcp3004],
>> + }, {
>> + .compatible = "microchip,mcp3008",
>> + .data = &mcp320x_chip_infos[mcp3008],
>> + }, {
>> + .compatible = "microchip,mcp3201",
>> + .data = &mcp320x_chip_infos[mcp3201],
>> + }, {
>> + .compatible = "microchip,mcp3202",
>> + .data = &mcp320x_chip_infos[mcp3202],
>> + }, {
>> + .compatible = "microchip,mcp3204",
>> + .data = &mcp320x_chip_infos[mcp3204],
>> + }, {
>> + .compatible = "microchip,mcp3208",
>> + .data = &mcp320x_chip_infos[mcp3208],
>> + }, {
>> + .compatible = "microchip,mcp3301",
>> + .data = &mcp320x_chip_infos[mcp3301],
>> + }, {
>
> Acked-by: Michael Welling <mwelling@ieee.org>
Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.
Thanks,
Jonathan
>
>> }
>> };
>> MODULE_DEVICE_TABLE(of, mcp320x_dt_ids);
>> --
>> 2.4.3
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-10-25 12:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 12:54 [PATCH 0/2] iio: adc: mcp320x: Add compatible with vendor prefix and deprecate old ones Javier Martinez Canillas
2015-10-14 12:54 ` [PATCH 1/2] iio: adc: mcp320x: Deprecated compatible strings with no vendor prefix Javier Martinez Canillas
2015-10-14 15:27 ` Michael Welling
2015-10-25 12:36 ` Jonathan Cameron
2015-10-25 19:34 ` Michael Welling
2015-10-25 12:35 ` Jonathan Cameron
2015-10-14 12:54 ` [PATCH 2/2] iio: adc: mcp320x: Add compatible with vendor prefix to OF table Javier Martinez Canillas
2015-10-14 15:27 ` Michael Welling
2015-10-25 12:37 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562CCD19.5090004@kernel.org \
--to=jic23@kernel.org \
--cc=gizero@gmail.com \
--cc=javier@osg.samsung.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred.schlaegl@gmx.at \
--cc=mwelling@ieee.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox