From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752594AbbJZBs0 (ORCPT <rfc822;w@1wt.eu>);
	Sun, 25 Oct 2015 21:48:26 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:2414 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751216AbbJZBsZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 25 Oct 2015 21:48:25 -0400
Message-ID: <562D860B.2060008@huawei.com>
Date: Mon, 26 Oct 2015 09:46:51 +0800
From: "Wangnan (F)" <wangnan0@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Alexei Starovoitov <ast@plumgrid.com>,
        Peter Zijlstra <peterz@infradead.org>
CC: "David S. Miller" <davem@davemloft.net>, Ingo Molnar <mingo@kernel.org>,
        He Kuang <hekuang@huawei.com>,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Daniel Borkmann <daniel@iogearbox.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 2/3] bpf: introduce bpf_perf_event_output() helper
References: <1445396556-4854-1-git-send-email-ast@kernel.org> <1445396556-4854-3-git-send-email-ast@kernel.org> <20151023143943.GC17308@twins.programming.kicks-ass.net> <562A4BE8.2060603@plumgrid.com> <20151023164223.GE17308@twins.programming.kicks-ass.net> <562A6D80.6000208@plumgrid.com>
In-Reply-To: <562A6D80.6000208@plumgrid.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.111.66.109]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090205.562D8620.0017,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 6b6d5b1cc9e35f7c46964e216ea548bb
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2015/10/24 1:25, Alexei Starovoitov wrote:
> On 10/23/15 9:42 AM, Peter Zijlstra wrote:
>> On Fri, Oct 23, 2015 at 08:02:00AM -0700, Alexei Starovoitov wrote:
>>> On 10/23/15 7:39 AM, Peter Zijlstra wrote:
>>>> On Tue, Oct 20, 2015 at 08:02:34PM -0700, Alexei Starovoitov wrote:
>>>>>> +static const struct bpf_func_proto bpf_perf_event_output_proto = {
>>>>>> +    .func        = bpf_perf_event_output,
>>>>>> +    .gpl_only    = false,
>>>> Oh ?
>>>
>>> no particular reason. key helper bpf_probe_read() is gpl, so all
>>> bpf for tracing progs have to be gpl.
>>> If you feel strongly about it, I can change it.
>>
>> All the perf symbols are export GPL, so I suppose this should be true.
>
> ok. will send a patch.
>

Can we (or have we already) setup some rules for licensing? Which part
should be GPL? Who has the response to decide it?

Thank you.