[PATCH] staging: ft1000: Remove boolean comparisons

[PATCH] staging: ft1000: Remove boolean comparisons

[Luis de Bethencourt]

Boolean tests do not need explicit comparison to true or false.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++--
 drivers/staging/ft1000/ft1000-usb/ft1000_hw.c    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
index eecfa37..dfb5da93 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
@@ -1531,7 +1531,7 @@ static int ft1000_copy_up_pkt(struct net_device *dev)
 			tempword = ft1000_read_reg(dev, FT1000_REG_DFIFO);
 			*pbuffer++ = (u8) (tempword >> 8);
 			*pbuffer++ = (u8)tempword;
-			if (ft1000_chkcard(dev) == false) {
+			if (!ft1000_chkcard(dev)) {
 				kfree_skb(skb);
 				return FAILURE;
 			}
@@ -1822,7 +1822,7 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id)
 		return IRQ_HANDLED;
 	}
 
-	if (ft1000_chkcard(dev) == false) {
+	if (!ft1000_chkcard(dev)) {
 		ft1000_disable_interrupts(dev);
 		return IRQ_HANDLED;
 	}
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
index 9ea32ce..22582be 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
@@ -1465,7 +1465,7 @@ int ft1000_poll(void *dev_id)
 	u16 modulo;
 	u16 portid;
 
-	if (ft1000_chkcard(dev) == FALSE) {
+	if (!ft1000_chkcard(dev)) {
 		pr_debug("failed\n");
 		return -1;
 	}
-- 
2.5.1

Re: [PATCH] staging: ft1000: Remove boolean comparisons

[Greg KH]

On Sun, Oct 18, 2015 at 09:58:15PM +0100, Luis de Bethencourt wrote:
> Boolean tests do not need explicit comparison to true or false.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++--
>  drivers/staging/ft1000/ft1000-usb/ft1000_hw.c    | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

This driver just got deleted from the tree, sorry :(

Re: [PATCH] staging: ft1000: Remove boolean comparisons

[Luis de Bethencourt]

On 25/10/15 02:20, Greg KH wrote:
> On Sun, Oct 18, 2015 at 09:58:15PM +0100, Luis de Bethencourt wrote:
>> Boolean tests do not need explicit comparison to true or false.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>> ---
>>  drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++--
>>  drivers/staging/ft1000/ft1000-usb/ft1000_hw.c    | 2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> This driver just got deleted from the tree, sorry :(
> 

Hi Greg,

No problem. I see the commit that removed this driver [0] mentions the radio
technology service has been discontinued.

Great to see drivers removed when they become obsolete instead of zombily
maintained.

Thanks for the review,
Luis


[0] https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=6512edec48b2ccfe9bb969ce26ebbbcd49de6c4b