From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753781AbbJZKLZ (ORCPT ); Mon, 26 Oct 2015 06:11:25 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:31479 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753219AbbJZKLX (ORCPT ); Mon, 26 Oct 2015 06:11:23 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-88-562dfc487310 Message-id: <562DFC47.6050904@samsung.com> Date: Mon, 26 Oct 2015 11:11:19 +0100 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Ingi Kim Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sameo@linux.intel.com, lee.jones@linaro.org, rpurdie@rpsys.net, inki.dae@samsung.com, sw0312.kim@samsung.com, beomho.seo@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033 References: <1445579285-6866-1-git-send-email-ingi2.kim@samsung.com> <1445579285-6866-2-git-send-email-ingi2.kim@samsung.com> In-reply-to: <1445579285-6866-2-git-send-email-ingi2.kim@samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsVy+t/xq7oef3TDDJ6+kbY4/Wkbu8X8I+dY LfrfLGS1OPdqJaPFjptf2Cwm3Z/AYnH/61FGi8u75rBZbH2zjtFi6fWLTBYTpq9lsWjde4Td Yveup6wWp7tZLWZMfsnmwO+xZt4aRo/Lfb1MHiuXf2Hz2LSqk83jzrU9bB7zTgZ67Jn/g9Wj b8sqRo/Pm+QCOKO4bFJSczLLUov07RK4Mmbsm8tWMEeg4uPedrYGxhm8XYycHBICJhL39r1k hLDFJC7cW8/WxcjFISSwlFFiwoMN7CAJIYFnjBLbG3VAbF4BLYlTr/aAxVkEVCXaTm9lBrHZ BAwlfr54zQRiiwpESPw5vY8Vol5Q4sfkeywgtoiAisSdpy0sIAuYBW4ySXz93cIGkhAWcJZ4 e+4aG8SyeollhxaCNXMKuEosO/0IbAGzgLXEyknbGCFseYnNa94yT2AUmIVkxywkZbOQlC1g ZF7FKJpamlxQnJSea6hXnJhbXJqXrpecn7uJERJbX3YwLj5mdYhRgINRiYf3BY9umBBrYllx Ze4hRgkOZiUR3t4ZQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8c3e9DxESSE8sSc1OTS1ILYLJ MnFwSjUw2s0XXrMuffntE62mvy/6t5yadLIz7djj2HknV3E+K3EOYypWnuQ3pacqrfHx08Oz 634oKfxr0PR9Fmrc/vIC13RrIZnjIY43Njb1N++Wa7sm0RYssWfXl//C1evmiMYJVmgJLiyf 5FGc5bXPe5Inw/uiDdmPLy3cae2q0pGjFPCvSTvpn9RkJZbijERDLeai4kQAv1UDVqkCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ingi, On 10/23/2015 07:48 AM, Ingi Kim wrote: > This patch adds the device tree bindings for RT5033 flash LEDs. > > Signed-off-by: Ingi Kim > Acked-by: Rob Herring > --- > .../devicetree/bindings/leds/leds-rt5033.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt b/Documentation/devicetree/bindings/leds/leds-rt5033.txt > new file mode 100644 > index 0000000..2ef7bdc > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt > @@ -0,0 +1,38 @@ > +* Richtek Technology Corporation - RT5033 Flash LED Driver > + > +The RT5033 Flash LED Circuit is designed for one or two LEDs driving These bindings don't say how to handle two LEDs case. > +for torch and strobe applications, it provides an I2C software command > +to trigger the torch and strobe operation. > + > +Required properties: > +- compatible : Must be "richtek,rt5033-led". > + > +A discrete LED element connected to the device must be represented by a child > +node - see Documentation/devicetree/bindings/leds/common.txt. > + > +Required properties of the LED child node: > + See Documentation/devicetree/bindings/leds/common.txt > +- led-max-microamp : Minimum Threshold for Timer protection > + is defined internally (Maximum 200mA). > +- flash-max-microamp : Flash LED maximum current > +- flash-max-timeout-us : Flash LED maximum timeout > + > +Optional properties of the LED child node: > +- label : see Documentation/devicetree/bindings/leds/common.txt > + > +Example: > + > +rt5033 { > + compatible = "richtek,rt5033"; > + > + led { > + compatible = "richtek,rt5033-led"; > + > + flash-led { > + label = "rt5033-flash"; > + led-max-microamp = <200000>; > + flash-max-microamp = <800000>; > + flash-max-timeout-us = <1216000>; > + }; > + }; > +} > -- Best Regards, Jacek Anaszewski