From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932078AbbJZMwS (ORCPT ); Mon, 26 Oct 2015 08:52:18 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:59249 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753935AbbJZMwP (ORCPT ); Mon, 26 Oct 2015 08:52:15 -0400 X-AuditID: cbfee691-f79d66d000001509-26-562e21fddbb7 Message-id: <562E1FB5.1000600@samsung.com> Date: Mon, 26 Oct 2015 18:12:29 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Lee Jones Cc: broonie@kernel.org, k.kozlowski@samsung.com, mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Thomas Abraham , devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC References: <1445855803-26973-1-git-send-email-alim.akhtar@samsung.com> <1445855803-26973-2-git-send-email-alim.akhtar@samsung.com> <20151026110924.GI597@x1> In-reply-to: <20151026110924.GI597@x1> Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMIsWRmVeSWpSXmKPExsWyRsSkSvevol6Ywb0b3BZTHz5hs5h/5Byr xesXhhb3vx5ltPjYc4/V4vKuOWwWM87vY7K4eMrVYn9nB6NFxzJGBy6P9zda2T32TDzJ5rFp VSebx51re9g8+rasYvT4vEkugC2KyyYlNSezLLVI3y6BK+PA2mcsBR0KFQ/W9zM3MDZJdjFy cEgImEj0fPTpYuQEMsUkLtxbz9bFyMUhJLCCUeLvul5WiISJxM57H5kgErMYJW7/3QzlPGCU +L5pCwtIFa+AlsSNVbMYQWwWAVWJPV3HwbrZBLQl7k7fwgSyTVQgQuLxBSGIckGJH5PvsYCE RQRUJM69MQcJMwt0MUnsWxMOYgsLREvcWtgGddBCRoknsxqYQBKcAmoS93ZC2MwCZhKPWtYx Q9jyEpvXvGUGaZAQeMku8fXkOlaIewQkvk0+xALxsazEpgPMEI9JShxccYNlAqPYLCQnzUIy dhaSsQsYmVcxiqYWJBcUJ6UXmeoVJ+YWl+al6yXn525iBMbl6X/PJu5gvH/A+hCjAAejEg/v Cx7dMCHWxLLiytxDjKZAV0xklhJNzgdGf15JvKGxmZGFqYmpsZG5pZmSOK+O9M9gIYH0xJLU 7NTUgtSi+KLSnNTiQ4xMHJxSDYzzXqqviV9w5WrRpl3PuWeY7RY+F2mf5mcnwnJP59yi73tO df22VOmMN5BP5c2OfX2pf6dh7NrmKVU8jCnyelvu6tZPaP3j0/VT0+93yr/fKSZX8m19TtUs PPnjxQz3Eyr9Ivv3r6qpmZv+OfgVy0yNi4nsM/i53TwnLt5gVhO+ViG/1Urz/E8lluKMREMt 5qLiRAA99dTJxgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42I5/e+xoO5fRb0wg1tyFlMfPmGzmH/kHKvF 6xeGFve/HmW0+Nhzj9Xi8q45bBYzzu9jsrh4ytVif2cHo0XHMkYHLo/3N1rZPfZMPMnmsWlV J5vHnWt72Dz6tqxi9Pi8SS6ALaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJc SSEvMTfVVsnFJ0DXLTMH6C4lhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGEN Y8aBtc9YCjoUKh6s72duYGyS7GLk5JAQMJHYee8jE4QtJnHh3nq2LkYuDiGBWYwSt/9uZoJw HjBKfN+0hQWkildAS+LGqlmMIDaLgKrEnq7jrCA2m4C2xN3pW4AaODhEBSIkHl8QgigXlPgx +R4LSFhEQEXi3BtzkDCzQBeTxL414SC2sEC0xK2FbVB7FzJKPJnVAHYQp4CaxL2dEDazgJnE o5Z1zBC2vMTmNW+ZJzACXYmwYhaSsllIyhYwMq9ilEgtSC4oTkrPNcxLLdcrTswtLs1L10vO z93ECI79Z1I7GA/ucj/EKMDBqMTD+4JHN0yINbGsuDL3EKMEB7OSCK+9jF6YEG9KYmVValF+ fFFpTmrxIUZTYBhMZJYSTc4HpqW8knhDYxNzU2NTSxMLEzNLJXHeCxkaYUIC6YklqdmpqQWp RTB9TBycUg2Mk7yMsvZfvjG778Den8KfPbU+v1ndZML60OvjWuNkvjVvH5/WLM9mbRVNX3n2 rbeDm8Y9ky+3+NZ8/h0zZ0FJ8ezG6w0i3q9SOpnFjzq7Shlv/KIRI9xVcOvwn4mLwrIqFgmZ bg/03HjxgYjZi49Prz16uj6P6cuGvLppS/pX2DE4iz14N2HaFyWW4oxEQy3mouJEAOLvNM0T AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2015 04:39 PM, Lee Jones wrote: > On Mon, 26 Oct 2015, Alim Akhtar wrote: > >> From: Thomas Abraham >> >> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device >> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. >> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Thomas Abraham >> Signed-off-by: Alim Akhtar >> Reviewed-by: Krzysztof Kozlowski >> --- >> Documentation/devicetree/bindings/mfd/s2mps11.txt | 23 ++++++++++++++------- >> 1 file changed, 15 insertions(+), 8 deletions(-) > > Nothing to controversial here. > > For my own reference: > Acked-by: Lee Jones > Thanks, will send v3 of this series. >> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt >> index 890f0b0e1643..c0427c9d0886 100644 >> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt >> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt >> @@ -1,5 +1,5 @@ >> >> -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current Regulator >> +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator >> >> The Samsung S2MPS11 is a multi-function device which includes voltage and >> current regulators, RTC, charger controller and other sub-blocks. It is >> @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C interface. Each sub-block is >> addressed by the host system using different I2C slave addresses. >> >> Required properties: >> -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps13-pmic" >> - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". >> +- compatible: Should be one of the following >> + - "samsung,s2mps11-pmic" >> + - "samsung,s2mps13-pmic" >> + - "samsung,s2mps14-pmic" >> + - "samsung,s2mps15-pmic" >> + - "samsung,s2mpu02-pmic". >> - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. >> >> Optional properties: >> @@ -24,7 +28,7 @@ Optional properties: >> unwanted buck warm reset (setting buck voltages to default values). >> >> Optional nodes: >> -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 >> +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide three(AP/CP/BT) buffered 32.768 >> KHz outputs, so to register these as clocks with common clock framework >> instantiate a sub-node named "clocks". It uses the common clock binding >> documented in : >> @@ -37,12 +41,13 @@ Optional nodes: >> the clock which they consume. >> Clock ID Devices >> ---------------------------------------------------------- >> - 32KhzAP 0 S2MPS11, S2MPS13, S2MPS14, S5M8767 >> - 32KhzCP 1 S2MPS11, S2MPS13, S5M8767 >> - 32KhzBT 2 S2MPS11, S2MPS13, S2MPS14, S5M8767 >> + 32KhzAP 0 S2MPS11, S2MPS13, S2MPS14, S2MPS15, S5M8767 >> + 32KhzCP 1 S2MPS11, S2MPS13, S2MPS15, S5M8767 >> + 32KhzBT 2 S2MPS11, S2MPS13, S2MPS14, S2MPS15, S5M8767 >> >> - compatible: Should be one of: "samsung,s2mps11-clk", "samsung,s2mps13-clk", >> - "samsung,s2mps14-clk", "samsung,s5m8767-clk" >> + "samsung,s2mps14-clk", "samsung,s2mps15-clk", >> + "samsung,s5m8767-clk" >> >> - regulators: The regulators of s2mps11 that have to be instantiated should be >> included in a sub-node named 'regulators'. Regulator nodes included in this >> @@ -90,6 +95,7 @@ as per the datasheet of s2mps11. >> - S2MPS11: 1 to 38 >> - S2MPS13: 1 to 40 >> - S2MPS14: 1 to 25 >> + - S2MPS15: 1 to 27 >> - S2MPU02: 1 to 28 >> - Example: LDO1, LDO2, LDO28 >> - BUCKn >> @@ -97,6 +103,7 @@ as per the datasheet of s2mps11. >> - S2MPS11: 1 to 10 >> - S2MPS13: 1 to 10 >> - S2MPS14: 1 to 5 >> + - S2MPS15: 1 to 10 >> - S2MPU02: 1 to 7 >> - Example: BUCK1, BUCK2, BUCK9 >> >