From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753965AbbJZMr1 (ORCPT ); Mon, 26 Oct 2015 08:47:27 -0400 Received: from mail-bn1on0082.outbound.protection.outlook.com ([157.56.110.82]:48075 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753545AbbJZMrY (ORCPT ); Mon, 26 Oct 2015 08:47:24 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH v4] PCI: Xilinx-NWL-PCIe: Added support for Xilinx NWL PCIe Host Controller To: Bharat Kumar Gogada , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" References: <1445066538-24638-1-git-send-email-bharatku@xilinx.com> <5705956.6YyKSO4LdH@wuerfel> <8520D5D51A55D047800579B09414719801692D8E@XAP-PVEXMBX01.xlnx.xilinx.com> CC: "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , Soren Brinkmann , "bhelgaas@google.com" , "tinamdar@apm.com" , "treding@nvidia.com" , "rjui@broadcom.com" , "Minghuan.Lian@freescale.com" , "m-karicheri2@ti.com" , "hauke@hauke-m.de" , "devicetree@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ravikiran Gummaluri From: Michal Simek Message-ID: <562E20CB.4020401@xilinx.com> Date: Mon, 26 Oct 2015 13:47:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <8520D5D51A55D047800579B09414719801692D8E@XAP-PVEXMBX01.xlnx.xilinx.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21902.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD019;1:/O9W8skM1CZI0c7ltdVZ9IGJPV9zwXfNAp4b1zx2hDX+TInIXD20bzc09iqiFbw+tvaZe9rZcp5IjPJ6spu9xyCbVDbAbJvZm9axY5TqxFuGrTJwPcMx5lycqoqHBgVfOjPBhODy4Xcc57QCpkntVVLaFx4jQdvb8rwYJrwiJnZynsQy6qT447ts/+c0OXktfU8Toi100l/EPWnMUkpQ5B3HyYvzuIF7zdk16zbuvQsfLduOy965GxNDTUgWahHQR7eCra/YQx2SznfYfc+UZ1OGuop4aAlSpCuv9p9eyVWZri/dTomGmow+qaVbh0uX9sNatMd4ExkmjvjJtZtMYKVEIzddQbmHjdlbAJ1RVLCHlDmy3/qINVEnyHo4yk0T/Ga9kpjP1VbcCpteh+2X30QHkrOFnMQktRIn9eaCi7c= X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(377454003)(199003)(69234005)(164054003)(24454002)(189002)(479174004)(107886002)(16796002)(33656002)(65806001)(92566002)(50466002)(65956001)(47776003)(6806005)(77096005)(5001960100002)(11100500001)(5008740100001)(5007970100001)(2950100001)(189998001)(2501003)(4001350100001)(81156007)(80316001)(5001920100001)(87936001)(23746002)(83506001)(5001770100001)(63266004)(575784001)(86362001)(106466001)(59896002)(36386004)(64126003)(65816999)(230783001)(87266999)(54356999)(76176999)(50986999)(4001430100002)(36756003)(7059030)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1AFFO11HUB044;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB044;2:QmS1NU3N4Pw0Aw6evm/kK9j6K6gGhRjPR91iQkQmvhiqPcRb+CA3M8gaaOHhJyGenJI7AoCv1HI1iLfE0bisbKPp8zuXQEAyFdpCemCJESTpQdUl9wzduNF58nkFHQkaPcocJvRHByWXONq5MxiyMZROmtq/oNDhrSUEKONCWVE=;3:0bSKaBPjKKm/QsKiwqQlum82d2S66F/x46NW3aYwFsl6q32dX32tGxk93b7h1Ez5b6ik2H084wQSARKMFt+SVVRAMT3FA7Xofga0vURlsrfDxEp52P17Vobq2tk96wr47N8cOUCQD7a1jY+lQ15PbYnL219st+DBLxPNLK2N3R4AdbedPjGtCeTCGZKIyNigDYnga8AOuwr1CEoBluCQq0Pn7VwxnwH8YCu00QudB72/zZQN7JtP5DCUgAyL/fdfYuBOZhQuGb0t8qz8BDjOvg==;25:GeGLpQfX2nMq21WRZXcgOzC/EiwgoFaHZhmX6X7pnuY3TkiiOt2Y6dYVOWhloyQoUYcEsErymN4+2kOSf3h+nNIjKMIluWukaL5HcLdDC6cu4vA/YwfyvgXQGchvDqTTNNJmmkPPn+SmgfvM4IsTfvPoXGm2Igt1Wh2mnhPXi89ne6/KdnYPWlYyAk+AVxx/PdF4Is/Xc3ZiGv2cA4sbGSv44lbevyXODCcK4Ev6EjS18rNswhUDKoyRdI6VKcoTVXmY/PquYZnhb2n06C/V4Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN1AFFO11HUB044; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB044;20:WH6PHj8ndJdsf0Vd6KbknMCJe7sA7ab4x3eJnn+9A8Xhs3OOQSAcjNwCk5diyN0iLz42SaIommkpp4NdbOtyRAF9mpeqllqX2yFmO3zN0alnRaDsPI5dU8z66bdyucIYjpN7iCX2cjEGj/2VzXw9IJ/nMBb3+1KrPHAHKlYjZqs088z9ODv9gOu/FpSN/IB76JxvCNuydqUu1vP7gayhL4Gq0w0UcT+3K8rkU/jwnuMx/PYqsr7WaLQ94aVx+PHhkNCMhETD8ppgB2ov6blzHskduGx7rNjpUH3jMl7DdUGjXiBIljyp1b7SxpTJApahw95vYqzymqOjDw7DBBhnQVSJP5TcZFdjfcmVK5RDf1FukGr9JCjZPAzUczUcNE2+bfdNQ0Y80u/fg8JIAXmQlHKb48ki8dhfeOYS6djb9/VZVm15D2zETGYk5wEz+kFH/Gu9xT/cBWB6QgkE+p6KhbUtNDvNCaw2md4vQjyYYbrvkM8Mm1idUx5X333G5WCQ;4:p+SaNL7URkkx8WIA90vU8m1sC/qQxAVBWBqn0AZgeLnAgeBzVmxR21hSniwNaQ/V0n3qqtO4md8zNyg8Y1PXMmXKWk1vXlVCbGNMVz30xjWi9SYuxOAvNolQbL7DLGg5V5Q6i70+DaUIco8B8kj0dCnW+Vgh01X52Pa91YQSX2T+x82FGFgyP82pPBPURJimY1ipUUjVH/0JOlfiTydXILFskaw08xfQ/UWWMwgrEaTfiMRfYGzw2lXhkQKXCRT1xf1ISGM7FXeUpiIeHxp8THFdHduRi41Klw4O4/7nyVDWl+RmW5SZWGjRC5b55ibfFthcy7Sj+BItSRLFjsVmL240oQpGX8929ilG/4iQqrwJLzAkyzFo1R6gdxYaa6zc/0VDoSAV8CJZKT4zebYrBg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(520078)(10201501027)(3002001)(102215026);SRVR:BN1AFFO11HUB044;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB044; X-Forefront-PRVS: 0741C77572 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN1AFFO11HUB044;23:/Iau1p7ByDAQQjKSLiTZUjZEbenhLmo5UOO?= =?Windows-1252?Q?UywzmPQubkguaqiIIsIeE4CP+kakLKjJXhzv+PIHGuv6qYD7AHiB59Vu?= =?Windows-1252?Q?i6jHdM7OO9EeRrN62Iasi+P/vM4/ZyPcvE3ee9nsskKiIKLp1cs8RTpq?= =?Windows-1252?Q?JPybwmKve/fzgKGKLyL3TPMIBUJzPzDIPyda/zidr8v1wL4ic6Hd+CGM?= =?Windows-1252?Q?1GMa7p6y5m7UUAjhwhdpKKNxe1SZqzeLFpzrS3dmN+Hta/10mZ3R4bKE?= =?Windows-1252?Q?RChWdVLrmTJI4GUBusvhV5HfhBOw8Wp/uSbSNFTixlfmBi+LeqN+SCMS?= =?Windows-1252?Q?Ckz1FDgBgIZYu5oyiJJH0/4Fn3NM4sXwqOF5eh9G22pEXajeCcZjQeJs?= =?Windows-1252?Q?1DmNEO3ski0JVjealyzujb/Kp6OXCkEvIpFCyhBswMrJa+Ir19d6xK67?= =?Windows-1252?Q?b9bcDwB4G2UBHRn2eyMCa5bXbbCEFHV9l1eyif1PuhNddylqFv4maZsh?= =?Windows-1252?Q?vzR30ajtV4spt1dK0icpKJloY6e3F7usHt7MtewcQfXxJ0R4yoA8Ztzu?= =?Windows-1252?Q?fygZ727MTRxmflqe5VTPPecDOkCpxPCs7+nX2EqhbDen77eFBSzHnTDc?= =?Windows-1252?Q?fVshvDd2ncuujU0Qj5GLjH0lYcre+XBgyEkgMPDi/5vZOVHntOYNmkbI?= =?Windows-1252?Q?ZUvUEMccHfgT03Y8i2MSmgVooD63Qlp8b1db+8tuKFbZxLxplCv82Oh0?= =?Windows-1252?Q?WgYhJo+jWegFRFZ2h0DncFkaq+dejqPvlsMSSBMFFha7OZNCNhCPlFY0?= =?Windows-1252?Q?dGOnQjtC23LWQCCFboh39Mr2u+MjZcC51Nz3SYZPvvK/470D9uMwR4IG?= =?Windows-1252?Q?l/lxVp8Y1K8bC3FGKdBbAoDFN6H/8lXsgKXas1tRZjq+QJlA1QgNyd96?= =?Windows-1252?Q?9MSQsoNOas63tGAp+OiUoFt1XUoWGIO41pWoPLOqMIU3PXuyJr9uCSoy?= =?Windows-1252?Q?s/mrA4owst0Q6PTmRBtR34V7uu94wM8SacaC3mBrTtdsGVBnqG9a/0Tg?= =?Windows-1252?Q?zQ2vCI2C074QlkQ/5/UcQm4ZSeLkJIIWfX8eyJRUj3Wm46LYRrkwNXmP?= =?Windows-1252?Q?Ja9AoGD2VgrpvK5/oUu6eeBMOLmapC74L1cDmUxmQTvlG+/sKHyn0RMo?= =?Windows-1252?Q?1mC3S4wR4v9xJawNwJMxEpTjYN/bsBC2OAtVdfLsG91U/fiPsSabvFe6?= =?Windows-1252?Q?vBGkR2v9fgwFI13PjQ8nXoz4euzyUAbhfirNAQebJU/viPYqghEfRXCc?= =?Windows-1252?Q?lw8xbfzOaij+GuPkui7XW7f1fJgXKX7m9IZzW6jFYOx/IU+alRWHWUTc?= =?Windows-1252?Q?pIpET744IdV5fxy1Gp0Z5SvT1snDaZqGHXCa5gqzgh5A4JaCfnPLNlO+?= =?Windows-1252?Q?HTm91xBNjjnUylxqZTSV85TpqUouGJNQdPTEoIVOT2A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11HUB044;5:CnHIDRh+ijA2c0MVyh7k/QQktZvC57m7fnYPOkz71PGAtztT7pie9nCwE57ndHcKraUTsr+DfrM1CTUhqFo2mOISuFtIkVXCbhsRN/oAqEWSfqxNJ2bwOcNGzMtXgotjGyNQkSA0r/QC/eQw6KH1nQ==;24:pdGCFRQPTtjC7paiPuT3dZRLtWZjUQVMHjHgs083WalOFaW516Ms6xClmqEtBB86KZKmSHr0lvM/4PTVXjIiDkkGAuqnHS8i5qjdmWpFefc= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2015 12:47:21.7440 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB044 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2015 11:26 AM, Bharat Kumar Gogada wrote: >>> + device_type = "pci"; >>> + interrupt-parent = <&gic>; >>> + interrupts = < 0 118 4 >>> + 0 116 4 >>> + 0 115 4 // MSI_1 [63...32] >>> + 0 114 4 >; // MSI_0 [31...0] >> >> Better write these as tuples: >> >> interrupts = <0 118 4>, <0 116 4>, <0 115 4>, <0 114 4>; >> >> And maybe reverse the order? It looks that might be what the soc >> integration person had in mind. >> >> Also, what is interrupt <0 117 4>? Is that connected here as well? >> Better list it as well then, even if you don't use it. >> > We have it but not using it, we will list it. > >>> + interrupt-map-mask = <0x0 0x0 0x0 0x7>; >>> + interrupt-map = <0x0 0x0 0x0 0x1 &pcie_intc 0x1 >>> + 0x0 0x0 0x0 0x2 &pcie_intc 0x2 >>> + 0x0 0x0 0x0 0x3 &pcie_intc 0x3 >>> + 0x0 0x0 0x0 0x4 &pcie_intc 0x4>; >> >>> + msi-parent = <&nwl_pcie>; >>> + reg = <0x0 0xfd0e0000 0x1000 >>> + 0x0 0xfd480000 0x1000 >>> + 0x0 0xE0000000 0x1000000>; >> >> Same grouping for reg and interrupt-map as above for interrupts. > > Grouping reg and interrupt-map as tuples will make lengthy line and reduces readability, is it compulsory ? FYI: Just this. reg = <0x0 0xfd0e0000 0x1000>, <0x0 0xfd480000 0x1000>, <0x0 0xe0000000 0x1000000>; Also please make sure that you are using the same case for addresses. That 0xE0000000 case above. Thanks, Michal