From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754184AbbJZOoj (ORCPT ); Mon, 26 Oct 2015 10:44:39 -0400 Received: from lists.s-osg.org ([54.187.51.154]:53206 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753719AbbJZOoY (ORCPT ); Mon, 26 Oct 2015 10:44:24 -0400 Subject: Re: [PATCH] clk: versatile: Make depend on OF when COMPILE_TEST To: Geert Uytterhoeven References: <1445812888-8170-1-git-send-email-javier@osg.samsung.com> Cc: "linux-kernel@vger.kernel.org" , Michael Turquette , Stephen Boyd , Scott Branden , linux-clk From: Javier Martinez Canillas Message-ID: <562E3C43.4010507@osg.samsung.com> Date: Mon, 26 Oct 2015 23:44:19 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Geert, Thanks a lot for your feedback. On 10/26/2015 06:02 PM, Geert Uytterhoeven wrote: > On Sun, Oct 25, 2015 at 11:41 PM, Javier Martinez Canillas > wrote: >> Commit 4a7748c3d641 ("clk: Allow drivers to build if COMPILE_TEST is >> enabled") allowed clk drives to be compile tested on other archs but >> the COMMON_CLK_VERSATILE was only enabled on platforms that already >> selected OF support so the drivers assume it will always be enabled. >> >> So, restrict compile test for these drivers only if OF is enabled. >> >> Fixes: 4a7748c3d641 ("clk: Allow drivers to build if COMPILE_TEST is enabled") >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> drivers/clk/versatile/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig >> index fc50b6264bed..e85863cf145f 100644 >> --- a/drivers/clk/versatile/Kconfig >> +++ b/drivers/clk/versatile/Kconfig >> @@ -1,6 +1,6 @@ >> config COMMON_CLK_VERSATILE >> bool "Clock driver for ARM Reference designs" >> - depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64 || COMPILE_TEST >> + depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS || ARM64 || (COMPILE_TEST && OF) > > I would separate the infrastructure and platform dependencies, like > > depends on OF > depends on ARCH_INTEGRATOR || ARCH_REALVIEW || ARCH_VEXPRESS > || ARM64 || COMPILE_TEST > You are right, having an explicit dependency is way better than it implicitly and relying on the arch Kconfig to select it. > But it's of course up to the maintainer to decide. > I'll wait to see Stephen and Mike opinion before sending a v2 but I agree with your suggestion. > Gr{oetje,eeting}s, > > Geert > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America