From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753345AbbJZVl2 (ORCPT ); Mon, 26 Oct 2015 17:41:28 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34882 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753018AbbJZVl0 (ORCPT ); Mon, 26 Oct 2015 17:41:26 -0400 Subject: Re: [PATCH] Staging: android: uapi: fixed comment block coding style error in ion.h To: Dzonatans Melgalvis , gregkh@linuxfoundation.org References: <1445811414-10953-1-git-send-email-dz.melgalvis@gmail.com> Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Laura Abbott Message-ID: <562E9E03.1080509@labbott.name> Date: Mon, 26 Oct 2015 14:41:23 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1445811414-10953-1-git-send-email-dz.melgalvis@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/25/15 3:16 PM, Dzonatans Melgalvis wrote: > Fixed checkpatch.pl warning about comment block coding style. > The right aligned comments aren't great style. How about moving the comments (with the correct style) right above the macro they are describing. > Signed-off-by: Dzonatans Melgalvis > --- > drivers/staging/android/uapi/ion.h | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h > index 68a14b4..11df59f 100644 > --- a/drivers/staging/android/uapi/ion.h > +++ b/drivers/staging/android/uapi/ion.h > @@ -56,13 +56,15 @@ enum ion_heap_type { > * allocation flags - the lower 16 bits are used by core ion, the upper 16 > * bits are reserved for use by the heaps themselves. > */ > -#define ION_FLAG_CACHED 1 /* mappings of this buffer should be > - cached, ion will do cache > - maintenance when the buffer is > - mapped for dma */ > +#define ION_FLAG_CACHED 1 /* mappings of this buffer should be > + * cached, ion will do cache > + * maintenance when the buffer is > + * mapped for dma > + */ > #define ION_FLAG_CACHED_NEEDS_SYNC 2 /* mappings of this buffer will created > - at mmap time, if this is set > - caches must be managed manually */ > + * at mmap time, if this is set > + * caches must be managed manually > + */ > > /** > * DOC: Ion Userspace API >