From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbbJZWE2 (ORCPT ); Mon, 26 Oct 2015 18:04:28 -0400 Received: from lists.s-osg.org ([54.187.51.154]:53252 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbbJZWE0 (ORCPT ); Mon, 26 Oct 2015 18:04:26 -0400 Subject: Re: [PATCH] clk: versatile: Make depend on OF when COMPILE_TEST To: Stephen Boyd References: <1445812888-8170-1-git-send-email-javier@osg.samsung.com> <20151026185142.GF19782@codeaurora.org> Cc: linux-kernel@vger.kernel.org, Michael Turquette , Scott Branden , linux-clk@vger.kernel.org From: Javier Martinez Canillas Message-ID: <562EA365.5080704@osg.samsung.com> Date: Tue, 27 Oct 2015 07:04:21 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151026185142.GF19782@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Stephen, On 10/27/2015 03:51 AM, Stephen Boyd wrote: > On 10/26, Javier Martinez Canillas wrote: >> Commit 4a7748c3d641 ("clk: Allow drivers to build if COMPILE_TEST is >> enabled") allowed clk drives to be compile tested on other archs but > > s/drives/drivers/ > >> the COMMON_CLK_VERSATILE was only enabled on platforms that already >> selected OF support so the drivers assume it will always be enabled. >> >> So, restrict compile test for these drivers only if OF is enabled. > > No compiler error message? > >> >> Fixes: 4a7748c3d641 ("clk: Allow drivers to build if COMPILE_TEST is enabled") >> Signed-off-by: Javier Martinez Canillas >> > > No Reported-by? > Yes, sorry for forgetting the Reported-by and the build error... > I'd prefer we add stubs instead, so I've applied the patch below. > Great, thanks! Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America