From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753255AbbJZWXi (ORCPT ); Mon, 26 Oct 2015 18:23:38 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:24794 "EHLO sender163-mail.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbbJZWXh (ORCPT ); Mon, 26 Oct 2015 18:23:37 -0400 Subject: Re: [PATCH v4 4/7] usb: gadget: f_midi: fix leak on failed to enqueue out requests To: "Felipe F. Tonello" , linux-usb@vger.kernel.org References: <1445878509-12084-1-git-send-email-eu@felipetonello.com> <1445878509-12084-5-git-send-email-eu@felipetonello.com> Cc: linux-kernel@vger.kernel.org, Felipe Balbi , Greg Kroah-Hartman , Andrzej Pietrasiewicz , Clemens Ladisch From: Robert Baldyga Message-ID: <562EA7E2.6010403@hackerion.com> Date: Mon, 26 Oct 2015 23:23:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1445878509-12084-5-git-send-email-eu@felipetonello.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2015 05:55 PM, Felipe F. Tonello wrote: > This patch fixes a memory leak that occurs when an endpoint fails to enqueue > the request. If that happens the complete function will never be called, thus > never freeing the request. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/function/f_midi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c > index 4c01c8a..0e9cdeb 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -344,6 +344,7 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt) > if (err) { > ERROR(midi, "%s queue req: %d\n", > midi->out_ep->name, err); > + free_ep_req(midi->out_ep, req); > } > } > > Don't we have similar problem in f_midi_transmit() and f_midi_complete() functions? Best regards, Robert