From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
<tony.luck@intel.com>, <x86@kernel.org>, <ashok.raj@intel.com>,
<linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>,
<peterz@infradead.org>, <luto@kernel.org>, <dvlasenk@redhat.com>,
<ross.zwisler@linux.intel.com>, <dirk.j.brandewie@intel.com>,
Wan Zongshun <Vincent.Wan@amd.com>
Subject: Re: [PATCH 2/2] x86/cpufeature: Add CLZERO feature
Date: Mon, 26 Oct 2015 17:50:47 -0500 [thread overview]
Message-ID: <562EAE47.2080100@amd.com> (raw)
In-Reply-To: <20151026202250.GD11980@nazgul.tnic>
On 10/26/2015 3:22 PM, Borislav Petkov wrote:
> On Mon, Oct 26, 2015 at 10:12:59AM -0500, Aravind Gopalakrishnan wrote:
>> For large part yes, wrapped code in patch form with commit message etc.
>> And modified comment a little bit.
>>
>> Does that still require his address in "From"?
> Yes, because it sounds like he was the author of the original patch.
Okay, will fix that in V2.
> No, I think you should add that bit to init_scattered_cpuid_features()
> instead.
>
> And btw, those Intel QoS single bit defines and the XSAVE stuff there
> should move to that function too - that's a pure waste having them in
> the cap_flags array. I'll fix that.
>
Ok, I added it to init_scattered_cpuid_features() on top of your RFC
patch and it seems to work fine.
How do you prefer a V2 for this to be sent though-
Shall I wait until your fixes are in tip.git and resend?
Or send a V2 on top of current tip.git?
Thanks,
-Aravind.
next prev parent reply other threads:[~2015-10-26 23:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 11:18 [PATCH 0/2] Add new features introduced in AMD Fam17h Aravind Gopalakrishnan
2015-10-23 11:18 ` [PATCH 1/2] x86/mcheck: Add Scalable MCA cpuid bit Aravind Gopalakrishnan
2015-10-23 11:18 ` [PATCH 2/2] x86/cpufeature: Add CLZERO feature Aravind Gopalakrishnan
2015-10-25 10:37 ` Borislav Petkov
2015-10-26 15:12 ` Aravind Gopalakrishnan
2015-10-26 20:22 ` Borislav Petkov
2015-10-26 21:01 ` [RFC PATCH] x86/cpu: Move sparsely used bit leafs into scattered features (was: Re: [PATCH 2/2] x86/cpufeature: Add CLZERO feature) Borislav Petkov
2015-10-27 2:56 ` Andy Lutomirski
2015-10-27 3:22 ` Borislav Petkov
2015-10-26 22:50 ` Aravind Gopalakrishnan [this message]
2015-10-27 1:09 ` [PATCH 2/2] x86/cpufeature: Add CLZERO feature Borislav Petkov
2015-10-27 15:32 ` Aravind Gopalakrishnan
2015-10-27 16:48 ` Aravind Gopalakrishnan
2015-10-27 22:45 ` Borislav Petkov
2015-10-26 15:13 ` Aravind Gopalakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562EAE47.2080100@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=Vincent.Wan@amd.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=dirk.j.brandewie@intel.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).