From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbbJZXGm (ORCPT ); Mon, 26 Oct 2015 19:06:42 -0400 Received: from mail-bl2on0088.outbound.protection.outlook.com ([65.55.169.88]:6368 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751701AbbJZXGk (ORCPT ); Mon, 26 Oct 2015 19:06:40 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NWUNGM-08-87L-02 X-M-MSG: Subject: Re: [PATCH 2/2] x86/cpufeature: Add CLZERO feature To: Borislav Petkov References: <1445599113-8792-1-git-send-email-Aravind.Gopalakrishnan@amd.com> <1445599113-8792-3-git-send-email-Aravind.Gopalakrishnan@amd.com> <20151025103703.GB6084@nazgul.tnic> <562E42FB.6030600@amd.com> <20151026202250.GD11980@nazgul.tnic> CC: , , , , , , , , , , , , , Wan Zongshun From: Aravind Gopalakrishnan Message-ID: <562EAE47.2080100@amd.com> Date: Mon, 26 Oct 2015 17:50:47 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151026202250.GD11980@nazgul.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(377454003)(24454002)(199003)(189002)(164054003)(479174004)(83506001)(110136002)(65816999)(54356999)(86362001)(50986999)(87936001)(11100500001)(87266999)(5008740100001)(76176999)(23676002)(50466002)(5004730100002)(77096005)(2950100001)(5007970100001)(105586002)(189998001)(106466001)(92566002)(47776003)(65806001)(4001350100001)(97736004)(33656002)(101416001)(65956001)(59896002)(19580395003)(80316001)(64126003)(36756003)(93886004);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0708;H:atltwp02.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0708;2:4n7gYjmucMlzZoRfVQlzicBZLhnD8x/WF3KAlYbjvkVKMxKFT0j2rX4eE1Y8UH9ZbGU9FAIuP9RWnuJjHN8kB3hB78kZhP8KnYUHtwceEnIdBXbIcF8zBpWO2CsOotl31pAnnVE31QlreneSD3FGZS3rJdva+iEYPxwIEzRE5VQ=;3:CTa/xbc829+0GaKdJGrJMdL9ffNRu7W86K23LRd/Sgay/kIqnmFs+Tc8FfsSk4WvCNfQNR90xMJdURVAUwwFG4OjcuqFMig0si0lVTBvYUX1PHSlOHwCzddjg4TSn35N7JQZK1JA0fcO7cOJWNWTSIGGGPnB3N73v8fD5RbcUxj4YUTXuYgPlGZhafq6PJCEaRJM3hwv/8p+mqyhcCXPnyBtefxFfuJyDhGDp+b6m5+Y3s+frDNzGQ+2k22F8kAH;25:LV30FRhIXhEOOAd6e1ODLXXdkpl8Ygmbdqrhkss848GSiHXhnfRQmswwz+HWUP8lyhmDXcrsucAvxGBYLw9EnPPlwPqNixYOD8E80Ch1UvuWCq2O1RBKfAebe5QRHwGeZ0tks1c96I8BxIF7jvTb3hGFfK+PW0WyuVSZZ3aLgSe09GkFewp2xcUKgA42RJuMWAZuDrxTU7HWjzXanynoa0PQuVNWHBghCKHhTfPpM/97GlSyjFbnv+7+sRcYjOgBR7WvopnicFMM7ToJqeRsWQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0708; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0708;20:RRk87ziGaBaqsvfL8rSl0wHx1PNuNw9D/iFkT+I4txDGzdejOvkO3GDifjuqMjoh2uBWwz1Zow6sJPB+C9Hc3u2zlnwXXJX/UVhyvdG3zfTg8AqrW9LrR8wdPYalq4OpVTwRgQQBqXhVPSr1dHm8IvOB98AliwUQIrNG7RvQ37SFCBvGGgX3mqqnHXGW0cUNO+cu4FYhQ2lVa9GR+7GioXJv81DFwGnLNK3MjtwD+9zjSS1C0VRnqktyWs7CNyLjIiXDNzjXVG8xZa+98FeOzwmbqAx/fpmrwDkt6SZuE8tnWb06D22tAFwAwZJrF7q1XX/QSAV6RSm8r0oPS/ZSgx8KaXcQImJ7H3elbS5+v/fRVQIX+78pIYOXsUwNUAqoLa487wfhz0zDHCy4M8sU/JhJDK24vMGrYnC2lsQO73bOXQ9flQXa28g5cBtTthFMurxS/X6x3F2KBIpnwvV3nJCviAdUPXcpwjSyjbaJgTpqBnKAGWcGuIgXYSHsOJfd;4:hBvCAfZf3dfjFrt3PYixtWeSkIycHA4JxAr4vSFUSFWJZSyPiP9+B0gD9inJspLMELIXycVFzZOu/2jjttUNh3cZ0vDAsmOXD3sgQzGsJRy0PLxypYBUdNjW4/sKZ5MVZNJhtZCm5fE8uHG0yJufUg2BUUoJZZ3PPXjrM0YAqgFSTeoPH8PkiK5fDjRN3g//qZlzk3fFPvKIVaxxIzcn+Gbh6jHc8eUMLlxoUxns0SwZKRJ9G5aZ011VjEERcP5LVoPEdXxCALpZk8Gwunu3dnT1qKS0l9tgh5+6sBi6irrVbrOFSJLMygL5wmRnJcVhvgQ0NFsBlvBD3/n74iz4ZnYyFlfBXanlLbFtxERLrlcpP5392vTi+bChTJC8FLIr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(102215026);SRVR:BLUPR12MB0708;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0708; X-Forefront-PRVS: 0741C77572 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjEyTUIwNzA4OzIzOjdrNWRHSU9MZFdCYzZHY2c3KzBFc0tIcm5i?= =?utf-8?B?UXcyOGdWaE1NN2Z6QTYwdjlzSFhrVG1hdFdwSWVOQW9rTTJSZ2dZY05ydC80?= =?utf-8?B?TDdOSE1NekI0V3c3V1NIMk91azU1YnlRcmpRWGUzaUlNMEc0WWdtakhtY05G?= =?utf-8?B?L01aeG8rNDlxUDhGV3R0ck5wSXpvN3dOZ2I4ZXZYejd6V1Izd2llbGt2SFA2?= =?utf-8?B?djZHL0d6WnljdGhCY2lHT3diMWY1YkRvaFFoM1R4VkpFQkNjYVNxYTJCS1Uv?= =?utf-8?B?dlMrWk5MWTlGZERkQWk2eUF1WGR3RElFT1BnK2JrKzRjQmRaOUhkYkd1OU5U?= =?utf-8?B?YUhYSk45OXI3N09XOVBQcndOSlNyVm1BcDY1SERyeTFJanQ4M052WDFma1l0?= =?utf-8?B?RHVZVzg5cjlYUEVWZE5mRTlvc01JZ2F5SVlYWWw5Z1RzQndlRzdxMW5raWRF?= =?utf-8?B?eG9xdXBHaHcxOE5xMU1TQnEzVzlRMVROYVBod2M3K05MWWx6RGp3MjRNS2pm?= =?utf-8?B?YVBxMzRYaGFLWWh1ekJhd1ViamFRcGhHS1NEY0xtQXExR3YvYXc3N0l0bnR1?= =?utf-8?B?YnVvK21rbmY3R3BQakhFTnZFTmtDR1VtYmgzRDdDZThlODdhTUxPOE9vYjZR?= =?utf-8?B?SWZtUFNIVUlTa0dudlFIWEt5aEFJcmlVWG11V3BaUC82WjFyRmRCQnYvVTNF?= =?utf-8?B?MTlKSHR2K0s5N2ZCTHNhaHFxamZzLzFNcTEraGNsaDNqSHFnOHJLT2NtQXdF?= =?utf-8?B?bkQzZko3R0hNTWkyNThrS0RzTmRwM1laUjVIUCtaUnV1S0dVYTBHMGljMklO?= =?utf-8?B?VmVRUDBtdzJGZkhvVXlnZFhTMDdaNGYwNWJ3K3F5dFVZQVFKVFNJZWhmanlO?= =?utf-8?B?eDBJWXNqRU5VRENvVk5LWWVaSGxmRnRQVTZaOWJnR3NrR1M1eXVDMkpocCtz?= =?utf-8?B?elRkV1VjWGpRbDZFTDVKbXZ3MXBJWkRnTGxocGVQcGhQL1Jma2dXTlJVWjEr?= =?utf-8?B?TWFadHhxaXd6TWxId3RaTVBOM1dvUmZDL3JDS1MxTjh6S0dBTmMvV2dYalRV?= =?utf-8?B?b081bE1XeTFlUE1HR1NLUS9jV1EvbnpOZTVOekhvRTQvZ0s4SlI1SE1zTUUv?= =?utf-8?B?a0FIQnduMFkzQ3ZXQjVDUUZMMEFFb3lQWEFVNldQMFNEWmY3YnFLaXBXeTBw?= =?utf-8?B?cGcrQ3h6cEF4cmxBRzlyZHp4UHMyREU2NjhReU9XU2o1WVRKanZES0hRVVpM?= =?utf-8?B?SllUOFkwaW1rYytXOHZieXZubUJCMmNqRnFBNGtsWDdjNzFFaHVJNjNGSGRn?= =?utf-8?B?bE1ZdkZvaW9FWENqNWhhWjYwYTE2T3ByL29HUWVPRk02cDJJOVRqY3hTeE9Y?= =?utf-8?B?a0ZYQm5jUlVhQ1JWZW53UW1hSlNzbFRvTVdVejhjaVkzanBhVy83a1JTSzRE?= =?utf-8?B?Y0tneW5PYTVVLzlqSGx3QjYyRUxxUVdUZE1GcjVtWlI0dzV4SEUxQUJPUE94?= =?utf-8?Q?ZoK+Acdtz7MhpxTqFax7ZR2y21Z57faKOt0T4+ozzMEAgk?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0708;5:ZWZVaJLW8DiXAxGmduCZRBF3vmlRu/nPRYQnX8YDDWj50u0iuju52im1J01/bd5pIjo5XOicWUkx/EDaTBUOuF3OSBkfUlbQJapSQtUgZQcLIkAfvD/wfYAbm07FABZa7hezLYfVxyRl+jXKE7c1SQ==;24:NHvrAeh02lMpfDg1ReJufCBXbhlvQfb90eQiqbd3aHAMifhDjHkzYbDXHcLD5cxSrRH+Lg2gHWTa7gP1lcKwFdwNyBrXMA+CruMFBZOTFgE=;20:3P4EYBx6Js+/8CDgSnOPTpx703ogPhiCLVucFSMDmBpORc9OcyHFmnMUePmhuLJ/YL12YCkYCbM4d+1GZbOkN4IslKDXKuqHTEMwLN/nimwM9AvRKslLS+tW0njWmcrVCDKtwUCOs/4lcq2DXa2/xdpBwyHpZV0Z11GorrbWhpKmjHUKUfw/EBo9JX0bZkOoMhquRYphrcRJHKjddAX12aPUy+nFRyI6+RorZRnedZjFe6DakbBB8vXQJkDqN6Ew SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2015 22:50:50.1470 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0708 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2015 3:22 PM, Borislav Petkov wrote: > On Mon, Oct 26, 2015 at 10:12:59AM -0500, Aravind Gopalakrishnan wrote: >> For large part yes, wrapped code in patch form with commit message etc. >> And modified comment a little bit. >> >> Does that still require his address in "From"? > Yes, because it sounds like he was the author of the original patch. Okay, will fix that in V2. > No, I think you should add that bit to init_scattered_cpuid_features() > instead. > > And btw, those Intel QoS single bit defines and the XSAVE stuff there > should move to that function too - that's a pure waste having them in > the cap_flags array. I'll fix that. > Ok, I added it to init_scattered_cpuid_features() on top of your RFC patch and it seems to work fine. How do you prefer a V2 for this to be sent though- Shall I wait until your fixes are in tip.git and resend? Or send a V2 on top of current tip.git? Thanks, -Aravind.