From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753124AbbJZXAP (ORCPT ); Mon, 26 Oct 2015 19:00:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56950 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbbJZXAO (ORCPT ); Mon, 26 Oct 2015 19:00:14 -0400 Subject: Re: [PATCH] get_maintainer: Don't fallback to git by default To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1445897508-16528-1-git-send-email-javier@osg.samsung.com> Cc: Wolfram Sang , Lee Jones , Joe Perches From: Laura Abbott Message-ID: <562EB07B.9040501@redhat.com> Date: Mon, 26 Oct 2015 16:00:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445897508-16528-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2015 03:11 PM, Javier Martinez Canillas wrote: > The get_maintainer.pl script could be used to get a list of people that > has to be in the copy list when posting patches for a given file but it > defaults to git fallback so the list returned isn't really relevant and > submitters are posting patches to random developers that just happened > to touch that file in the past. > > Disable git fallback so get_maintainer.pl only returns the information > that is in MAINTAINERS by default. > > Suggested-by: Wolfram Sang > Signed-off-by: Javier Martinez Canillas > > --- > Hello, > > This patch was suggested by Wolfram on this thread [0] but it is > something I thought before because I've seen people complaining > on a regular basis about being cc'ed in random patches and there > are tools like patman [1] that rely on get_maintainers.pl to post > the patches. > > [0]: https://lkml.org/lkml/2015/10/26/444 > [1]: http://git.denx.de/?p=u-boot.git;a=blob;f=tools/patman/README > > Best regards, > Javier > We might need to do a sweep of files to make sure more of them are listed in the maintainers file, else by default they only show LKML. As an example, a bunch of files in lib are only showing LKML. Defaulting to only sending to LKML may be swinging too far in the wrong direction for reducing inbox size. > scripts/get_maintainer.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > index 98bae869f6d0..b52ae26270e8 100755 > --- a/scripts/get_maintainer.pl > +++ b/scripts/get_maintainer.pl > @@ -29,7 +29,7 @@ my $email_git = 0; > my $email_git_all_signature_types = 0; > my $email_git_blame = 0; > my $email_git_blame_signatures = 1; > -my $email_git_fallback = 1; > +my $email_git_fallback = 0; > my $email_git_min_signatures = 1; > my $email_git_max_maintainers = 5; > my $email_git_min_percent = 5; >