linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: "Franklin S Cooper Jr." <fcooper@ti.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	<linux-spi@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
	Sekhar Nori <nsekhar@ti.com>, <ssantosh@kernel.org>,
	"Ivan T. Ivanov" <iivanov@mm-sol.com>, <m-karicheri2@ti.com>,
	"Ivan T. Ivanov" <iivanov.xz@gmail.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	<hkallweit1@gmail.com>,
	Ivan Khoronzhuk <ivan.khoronzhuk@lonaro.org>
Subject: Re: [PATCH v2] spi: Setup the master controller driver before setting the chipselect
Date: Tue, 27 Oct 2015 15:11:29 +0200	[thread overview]
Message-ID: <562F7801.3090508@ti.com> (raw)
In-Reply-To: <562F6C9B.6010607@ti.com>

On 10/27/2015 02:22 PM, Franklin S Cooper Jr. wrote:
>
>
> On 10/16/2015 10:55 AM, Andy Shevchenko wrote:
>> On Fri, Oct 16, 2015 at 6:47 PM, Franklin S Cooper Jr. <fcooper@ti.com> wrote:
>>>
>>> On 10/16/2015 10:45 AM, Andy Shevchenko wrote:
>>>> On Fri, Oct 16, 2015 at 6:29 PM, Franklin S Cooper Jr <fcooper@ti.com> wrote:
>>>>> SPI controllers may need to be properly setup before chip selects
>>>>> can be used. Therefore, wait until the spi controller has a chance
>>>>> to perform their setup procedure before trying to use the chip
>>>>> select.
>>>>>
>>>>> This also insures that the chip selects pins are in a good
>>>>> state before asseting them which otherwise may cause confusion.
>>>>>
>>>>> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
>>>> Does it mean I have to test it again?
>>> Oops sorry. No the patch hasn't changed. I can shoot a v3 with your tested by included.
>> Whatever Mark prefers.
> Hi Mark,
> I don't see that you pulled this patch into your topic/core branch just yet. Would you prefer
> for me to shoot a v3 with Andy's tested by or will you just add it when your ready to
> pull it in?
>
> Without this patch several of our boards don't boot in linux-next so if there is anything you
> need for me to do please let me know.
>>
>>
>

Boot tested on K2HK:

Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>
Tested-by: Ivan Khoronzhuk <ivan.khoronzhuk@lonaro.org>

-- 
regards,
-grygorii

  reply	other threads:[~2015-10-27 13:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 15:29 [PATCH v2] spi: Setup the master controller driver before setting the chipselect Franklin S Cooper Jr
2015-10-16 15:45 ` Andy Shevchenko
2015-10-16 15:47   ` Franklin S Cooper Jr.
2015-10-16 15:55     ` Andy Shevchenko
2015-10-27 12:22       ` Franklin S Cooper Jr.
2015-10-27 13:11         ` Grygorii Strashko [this message]
2015-10-27 13:34           ` Grygorii Strashko
2015-10-28  0:33         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562F7801.3090508@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=fcooper@ti.com \
    --cc=hkallweit1@gmail.com \
    --cc=iivanov.xz@gmail.com \
    --cc=iivanov@mm-sol.com \
    --cc=ivan.khoronzhuk@lonaro.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=nsekhar@ti.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).