From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932477AbbJ0OJl (ORCPT ); Tue, 27 Oct 2015 10:09:41 -0400 Received: from foss.arm.com ([217.140.101.70]:56646 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932251AbbJ0OJi (ORCPT ); Tue, 27 Oct 2015 10:09:38 -0400 Subject: Re: [PATCH v2 5/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states To: "Prakash, Prashanth" , Ashwin Chaugule References: <1438710406-3822-1-git-send-email-sudeep.holla@arm.com> <1442411963-14398-1-git-send-email-sudeep.holla@arm.com> <1442411963-14398-6-git-send-email-sudeep.holla@arm.com> <562EC3A5.2070402@codeaurora.org> Cc: Sudeep Holla , linux acpi , "Rafael J. Wysocki" , lkml , linux-ia64@vger.kernel.org, x86@kernel.org, Al Stone , Lorenzo Pieralisi , Mahesh Sivasubramanian From: Sudeep Holla Organization: ARM Message-ID: <562F859E.4010105@arm.com> Date: Tue, 27 Oct 2015 14:09:34 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562EC3A5.2070402@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prashanth, On 27/10/15 00:21, Prakash, Prashanth wrote: > Hi Sudeep, > > While testing with these patches everything looked fine except that we > are flattening all the LPI > states even if it is disabled. I added a simple check to fix it. Please > let me know if you have any > feedback on the same. > Looks good to me and thanks for the nice catch. I completely missed to handle that case. Is it OK if I fold this patch into the next version ? I have worked on Ashwin's comments, but was waiting to get some feedback from Rafael before I post newer version. -- Regards, Sudeep