From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964929AbbJ0Pnx (ORCPT ); Tue, 27 Oct 2015 11:43:53 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:36838 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932256AbbJ0Pnu (ORCPT ); Tue, 27 Oct 2015 11:43:50 -0400 Subject: Re: [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources To: Florian Fainelli , "David S. Miller" References: <562F8ED7.2000804@baylibre.com> <562F9AAB.8090202@gmail.com> Cc: Andrew Lunn , Guenter Roeck , vivien.didelot@savoirfairelinux.com, Fabian Frederick , Pavel Nakonechny , Joe Perches , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Frode Isaksen From: Neil Armstrong Organization: Baylibre Message-ID: <562F9BB1.8090700@baylibre.com> Date: Tue, 27 Oct 2015 16:43:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <562F9AAB.8090202@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/27/2015 04:39 PM, Florian Fainelli wrote: > On 27/10/15 07:48, Neil Armstrong wrote: >> Some switch drivers might request interrupts, remap register ranges, >> allow such drivers to implement a "remove" callback doing just that. >> >> Suggested-by: Florian Fainelli > > This should probably be a Signed-off-by tag, but there is nothing using > this, so you would want to introduce an user of this function in the > same patch series so we see how you intend to use it? > >> Signed-off-by: Neil Armstrong Yes, I didn't know how to handle this since it was part of a larger patch. I forgot to add this into the cover-letter but I wanted to send an RFC serie with your bcm remove patch and a mv88e6xxx remove experimental code. Yet, the mv88e6060 does not make usage of this. Neil