From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932654AbbJ0Sz2 (ORCPT ); Tue, 27 Oct 2015 14:55:28 -0400 Received: from mail-qg0-f45.google.com ([209.85.192.45]:35031 "EHLO mail-qg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932359AbbJ0Sz0 (ORCPT ); Tue, 27 Oct 2015 14:55:26 -0400 Subject: Re: [PATCH 06/15] serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes To: Denys Vlasenko References: <1445968007-12616-1-git-send-email-dvlasenk@redhat.com> <1445968007-12616-7-git-send-email-dvlasenk@redhat.com> Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org From: Peter Hurley Message-ID: <562FC89A.50703@hurleysoftware.com> Date: Tue, 27 Oct 2015 14:55:22 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445968007-12616-7-git-send-email-dvlasenk@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/2015 01:46 PM, Denys Vlasenko wrote: > This function compiles to 98 bytes of machine code. This looks ok because these function are heavyweight. You'll want to add men_z135_reg_set() to this patch as well, and please cc the driver author: Johannes Thumshirn Regards, Peter Hurley > Signed-off-by: Denys Vlasenko > CC: Greg Kroah-Hartman > CC: Peter Hurley > CC: Jiri Slaby > CC: linux-serial@vger.kernel.org > --- > drivers/tty/serial/men_z135_uart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c > index b90e7b3..2b5b66f 100644 > --- a/drivers/tty/serial/men_z135_uart.c > +++ b/drivers/tty/serial/men_z135_uart.c > @@ -159,7 +159,7 @@ static inline void men_z135_reg_set(struct men_z135_port *uart, > * @addr: Register address > * @val: value to clear > */ > -static inline void men_z135_reg_clr(struct men_z135_port *uart, > +static void men_z135_reg_clr(struct men_z135_port *uart, > u32 addr, u32 val) > { > struct uart_port *port = &uart->port; >