From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965357AbbJ0TYg (ORCPT ); Tue, 27 Oct 2015 15:24:36 -0400 Received: from lists.s-osg.org ([54.187.51.154]:53331 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965111AbbJ0TYe (ORCPT ); Tue, 27 Oct 2015 15:24:34 -0400 Subject: Re: [PATCH] get_maintainer: Don't fallback to git by default To: Lee Jones , Joe Perches References: <1445897508-16528-1-git-send-email-javier@osg.samsung.com> <562EB07B.9040501@redhat.com> <562EC06C.5010404@osg.samsung.com> <20151027024729.GC16244@thunk.org> <20151027082150.GQ597@x1> <1445968411.2757.17.camel@perches.com> <20151027180900.GD5828@x1> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: "Theodore Ts'o" , Laura Abbott , linux-kernel@vger.kernel.org, Wolfram Sang , linux-kernel-owner@vger.kernel.org Message-ID: <562FCF6D.8030700@osg.samsung.com> Date: Wed, 28 Oct 2015 04:24:29 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151027180900.GD5828@x1> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 10/28/2015 03:09 AM, Lee Jones wrote: > On Tue, 27 Oct 2015, Joe Perches wrote: > >> On Tue, 2015-10-27 at 08:21 +0000, Lee Jones wrote: >>> On Mon, 26 Oct 2015, joe@perches.com wrote: >>>> On 2015-10-26 19:47, Theodore Ts'o wrote: >>>>> What if we have a git_fallback "auto" mode which only falls back to >>>>> using git if there is no entry in the MAINTAINERS file? That might >>>>> address the concern which Laura raised, without blocking this >>>>> change until the MAINTAINERS file is fully populated. >>>> >>>> That's what happens already right now. >>> >>> I think it can be done better. >>> >>> FYI, this patch came about because I keep complaining about submitters >>> sending me patches I really shouldn't have to care about. >> >> Then you should add your name to the .get_maintainer.ignore file. >> >> If you do, you'll only get listed by get_maintainer for files where >> you have a specific entry in MAINTAINERS. > > Oooo... I didn't even know that existed. It's an idea, but I'd rather > have these kinds of issues sorted out for everyone, rather than being > a special case and putting myself in the grumpy-old-b***** file. I'm > certainly not the only one suffering with this problem. > I agree with Lee here, if everyone has to be added to a file then that solution does not scale. I bet that no one working on the kernel would say that is OK on receiving random patches. >>> Here is the most recent offending command output: >>> >>> $ ./scripts/get_maintainer.pl -f drivers/i2c/busses/Kconfig >>> Wolfram Sang (maintainer:I2C SUBSYSTEM,commit_signer:26/26=100%,authored:3/26=12%,removed_lines:3/11=27%) >>> Lee Jones (commit_signer:3/26=12%) >>> Geert Uytterhoeven (commit_signer:3/26=12%,authored:3/26=12%,removed_lines:2/11=18%) >>> David Box (commit_signer:3/26=12%,added_lines:11/146=8%) >>> Jean Delvare (commit_signer:2/26=8%) >>> Javier Martinez Canillas (authored:2/26=8%,removed_lines:2/11=18%) >>> Neelesh Gupta (added_lines:11/146=8%) >>> James Hogan (added_lines:10/146=7%) >>> Ray Jui (added_lines:10/146=7%) >>> Joachim Eastwood (added_lines:10/146=7%) >>> Andrew Bresticker (removed_lines:2/11=18%) >>> Zhangfei Gao (removed_lines:1/11=9%) >>> linux-i2c@vger.kernel.org (open list:I2C SUBSYSTEM) >>> linux-kernel@vger.kernel.org (open list) >>> >>> Anyone south of Wolfram and north of the I2C ML is unlikely to care. >>> >>> Please find a way to make this better. For the sake of our sanity. >> Another option is to bump the git-fallback min % used as a threshold, for example when using a min value of 20 the list is more sensible: $ ./scripts/get_maintainer.pl -f --git-min-percent=20 drivers/i2c/busses/Kconfig Wolfram Sang (maintainer:I2C SUBSYSTEM,commit_signer:26/26=100%,removed_lines:3/11=27%) linux-i2c@vger.kernel.org (open list:I2C SUBSYSTEM) linux-kernel@vger.kernel.org (open list) >> Your sanity must be pretty darn fragile. > > Ticking time-bomb, me. ;) > Is not only Lee tbh, I see people complaining almost on a daily so the current default is not good enough. This of course annoys more to maintainers that already have a very heavy email load but it is also inconvenient for developers like me since by doing a change on a file that is frequently modified (i.e: Makefile, Kconfig, etc) you earn a life of spam :) Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America