From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754586AbbJ0TgV (ORCPT ); Tue, 27 Oct 2015 15:36:21 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:11950 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754493AbbJ0TgT (ORCPT ); Tue, 27 Oct 2015 15:36:19 -0400 Subject: Re: [PATCH v2] PM / suspend: replacing printk To: Saurabh Sengar References: <1445973676-4394-1-git-send-email-saurabh.truth@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Len Brown , Pavel Machek , "Rafael J. Wysocki" From: Richard Weinberger Message-ID: <562FD22D.2030206@nod.at> Date: Tue, 27 Oct 2015 20:36:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 27.10.2015 um 20:32 schrieb Saurabh Sengar: > it fixes the checkpatch.pl warnings Don't get me wrong, but checkpatch.pl is only a script which makes suggestions. Especially as these are only warnings and not errors. IMHO the code is perfectly fine as is. Thanks, //richard > On Oct 28, 2015 12:56 AM, "Richard Weinberger" > wrote: >> >> On Tue, Oct 27, 2015 at 8:21 PM, Saurabh Sengar > wrote: >> > replacing prink(s) with appropriate pr_info and pr_err >> > >> > Signed-off-by: Saurabh Sengar > >> > --- >> > kernel/power/suspend.c | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> >> In which way does this patch improve the existing code? >> You describe what it does but not which problem it solves and >> why this patch is necessary. >> >> -- >> Thanks, >> //richard >