From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965304AbbJ0UDN (ORCPT ); Tue, 27 Oct 2015 16:03:13 -0400 Received: from mail-bn1bon0066.outbound.protection.outlook.com ([157.56.111.66]:44352 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932184AbbJ0UDK (ORCPT ); Tue, 27 Oct 2015 16:03:10 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NWWACZ-08-E3T-02 X-M-MSG: Subject: Re: [PATCH v3] EDAC: Add ARM64 EDAC To: Stephen Boyd References: <1445966985-5777-1-git-send-email-brijeshkumar.singh@amd.com> <20151027190832.GN19782@codeaurora.org> CC: , , , , , , , , , , , , , , , From: Brijesh Singh Message-ID: <562FD837.50505@amd.com> Date: Tue, 27 Oct 2015 15:01:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151027190832.GN19782@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(24454002)(479174004)(189002)(377454003)(199003)(105586002)(86362001)(65816999)(106466001)(101416001)(76176999)(54356999)(83506001)(50986999)(110136002)(64126003)(4001350100001)(36756003)(65806001)(87936001)(33656002)(23746002)(11100500001)(50466002)(97736004)(47776003)(189998001)(5004730100002)(92566002)(5007970100001)(65956001)(2950100001)(77096005)(5008740100001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0717;H:atltwp02.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0717;2:jzk1gnAR1L8hYxYgTdytbXqkP15znsIhD32kRBWS8paOKOBhsAtYSs3kpx/DMKSrdjDZaJSRAn2oJI8AKqmb6+js2PaFpyqEdUQilS1ZHrc3+FwFg37ZwCFHUWiqX//BYK5X35HiysQldyQC7gYicHeln98XkopRrWlZCi0XssI=;3:69zyzTTMO1BKf5E4sj4xZEQsnDGcjdirnZrgk6z46BSPzgcyatUc97i1JQej5s37FUsBMfaaK5pUj4XVN6pODjeaVihkNUMITfeiao3pBAx3MKfzGhYZ9q7lgiJyNNMmJN7vAeOfgl+Qc04Vn/3k9mvldabPOkBn8j8YEpk9gMGQFoW48B+InBf3wtdU2YxRdlNrsU1gY3jWnFP6j8ftiIOQ4tOOdkNE0qvuLv8YXhY6RYs/wmI1wAmPkd+7gski;25:DrWFgXJib4wDMgzTW1njOrEcplDpwK+Dpoapag5kH39UNRKMA1zsriLnDz9reig2sM7ewFowZeSEkZqq+DnuHmOnw6fWm8S1Ps8iU2Wd4OKdYQ97Jhowbak2r9tle0FmMfTG389NtcSKpszBNvJnPCqooMkqg77rJ0fVWm1UG9pLqEu5OuFbeUR6LreZcbpMsHogKdfKElk09dJcQ4FlzeKkIQN1sV93y2sPfdlXvAEm3URwfJqKk/4D/raj5Kuc9PFPP4KSN36AppNSiLTaCw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0717; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0717;20:iv8wZAUtT7s0cR0TEoqYWpUrQkUTLuM9Mk+/9UJInftr0w21JbYxi0eW8DP2VsuLUaCM+8i1Zbu+crrIfdmpjK/93wSz0Y7KOp8TZGjmk32yRPTK05sEQ6aE3/PLx3pparYfxcic1CB2Gvqm1OqS5ohM+0SLd0jmTpCc5/D8ShF3l/SHB8aTwDTovwMwXlvCMBuH5c0EG2+Ht2343SKQGFsNTcGR4dbprYdGxAlN9LeXaniqR0sQpCPhk2LHD2cBZxWHcQcXh4At+bvpSFMV9w9xzvvOoTVOkNvsAxc3weOKcCNqh3BDEUQoi7eV245FSHm021ino/0O8tZo5ObqbR9kEAeOIMriFjfYOCyQHZ7jN/psYAuZNF4wdm691ZbsA0TDYk1Fn0F6BWaxnffzuBEDqrNceu7OMIcAKdUklvhvnP87k6sW+Y/R7HOpNB1z7NMAPgqHik+wgxMYjHHTJu7heZZLNSmYXtCM6QQWixjjQrYBDstIV5/FtqW7e7p4;4:ngHRSwfwVDuP+zOxbJWT2oHvDrxdYPaTLBUj334IQkzEMCH6PKOSnvXXnY9uIHuLGhzIkcLa0BBt2GZdRPW1JYGm5Ze00OgL++tpVhOAt9qB5JEUrPohC3547bTbGjAJBLQAPFeWGdLep/c/aOM4XsPflqi+ZS4L65KH1nhHk7gVwsUKNBEnVcyu55iCI/6/M+8w2vpxlzMjiBI2YsJcKSl8hG6b0BSQpvfg1ksrrO54u9UPjLNd5LqKmRuKtRp/Ycxrw1DCC6yf/sh3jpoxXJ7CTTewWMKYPcnLL9sgCIOFH5PBPGwFSughwo3Cos1hf76fKHgxaoCvTyj6h01XEz+CwdtBL7gnNVN+4P52iSWfZUEIVUChX8neWA7i22bE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(102215026);SRVR:SN1PR12MB0717;BCL:0;PCL:0;RULEID:;SRVR:SN1PR12MB0717; X-Forefront-PRVS: 0742443479 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;SN1PR12MB0717;23:l0fTgtEGq731tKVzchVUQiKP59IhImbeuzZ5+?= =?Windows-1252?Q?sov5Gmek705u6MnC8y82/7QcGUSx3Mq2rwx9ziLQ8qGAc+wJ2Q0VuKLy?= =?Windows-1252?Q?N29ksYqsZKWBQ4SF+CPsMjeuF5lnoFUBKX91mYLJErI2E6ycGMcE9hXq?= =?Windows-1252?Q?gYt1eMfDUaJI62PlUQRKGgXnWtEFsMKOckWm3wctThP4dLPjgmPBN/Ly?= =?Windows-1252?Q?hMGuUS4kIrvypteqJliPCY3wnKi4NDcbUgSHsIna/SLq2K/YmtwF87US?= =?Windows-1252?Q?MTYj5kYe1b/MPlyA51T1xnbrMns6R18oWgvAq58gk1kDHEwFEn6SgD+H?= =?Windows-1252?Q?r5uQwOVhOeEBIkWw0nU2RVpt2y6gBseErFEIiMy9T04rP5SZGv/k2GYc?= =?Windows-1252?Q?DfFM6rmD9d0eh3URU1YfSwEPZmFgIflOLUTqRHNo9z1j2jDtJsW/YVmA?= =?Windows-1252?Q?43sJd3P2Qac5tJAXC8XkbzwHpVcDCAlYE8ijgwUpCu6TVk2e4Al5wulx?= =?Windows-1252?Q?nQldp/mO7C7Uc1MiE9ph5XJJE0wIT4YBh68kf9muuhI8v6PbsoRRrApD?= =?Windows-1252?Q?aAyS6v1PwmDbJDCGZdzr1LnlJFBfr5vl097t2SKK96TecxLQt5kfcmm5?= =?Windows-1252?Q?sqfHT/RBe/8tc0gaIDy7+4Yy+ThN90AjP7TiLr7MW/pV8u71Rclf7KiE?= =?Windows-1252?Q?iEAIV87PIXjcVVW9ckRiud8vOWQokgX9jrZtUUAqu38QD1HbaqzIB8X3?= =?Windows-1252?Q?0aFF/LQK2HNbqHfo1Du0vnWO/EP8PjPMLP6DIYJpo/Hsfg0Br5qnlPGZ?= =?Windows-1252?Q?m63hzBkz5Hvlq9zJVKpk8NJosE7AZTifjB5Hbh6EP9JgJgtJQ+5Xin9X?= =?Windows-1252?Q?qxRS8WTdm1nv39BHvQhdHRbZO8CXckGPso7LNckKF5jjexwbL1zWQJ+p?= =?Windows-1252?Q?AWY7wJ96hUvmbfT4drM5c9mGp8Ex76o+xKUJXzFoh11nbl6OtYcLBn+3?= =?Windows-1252?Q?rvpMb584EBouJ/mpWkQXhVQjoAUYM0Ykef836bi4v2lWtHPtrw6TZXIJ?= =?Windows-1252?Q?/k7l3u7z1MImoh7+1v/8RBM2CpR7QAzkYc9?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0717;5:RmI9uGDX1iiCytNojSqMxgYmH5ASanzG5Qv58Pr/xUwM+vnn3fpOK7b1hayv99xjkZBIRO0f8EJ3mWh6UZxdU7n0QSaClVrC53ooCpQeQj0Io1k1Y3/glkjeqfzb4bNjypyW45HOyK/piIPPKzxNNw==;24:7zUqcljX0A5nsI6EWEhWWj6F69gK1R7ZxkruNg4KKIVLHeiEj61fvqaY6tXy12vMcuPlTFBGZAVFeIgcsjhz4Pg7uLgHRvOC4eaIZ6u05u0=;20:jGdnnwBLgrgJNNtcH3eC6t0rGCk7WAd6+fbpOjfE840OIDOu5mX1uRyZf81rK3uFdr9MVg5ZJ4Uz/QzjNkFlLY0ypjPnIQwhbBgmDZP+CmhMFav+cA/dA6tf90pw9o5UjLv2fTCJ2p6OU0JmZ9UP5fiZNbjg3VIwOQSjpd7aonlvaaoSoqskhTi/7xA05R43qfoOVL+OCw3fmyf3d7F2ysEAldV3fKN/3+PSyePrXiR7VMXa0BsKAI8g15n9d/+E SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2015 20:03:05.3398 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0717 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for review Steve. On 10/27/2015 02:08 PM, Stephen Boyd wrote: >> +config EDAC_CORTEX_ARM64 >> + tristate "ARM Cortex A57/A53" >> + depends on EDAC_MM_EDAC && ARM64 >> + default n > > n is the default so this can be removed. > noted >> + .driver = { >> + .name = DRV_NAME, >> + .owner = THIS_MODULE, > > This line can be removed. THIS_MODULE is assigned by > platform_driver_register(). noted. > >> + .of_match_table = cortex_arm64_edac_of_match, >> + }, >> +}; >> + >> +static int __init cortex_arm64_edac_init(void) >> +{ >> + return platform_driver_register(&cortex_arm64_edac_driver); >> +} >> +module_init(cortex_arm64_edac_init); >> + >> +static void __exit cortex_arm64_edac_exit(void) >> +{ >> + platform_driver_unregister(&cortex_arm64_edac_driver); >> +} >> +module_exit(cortex_arm64_edac_exit); > > This can be module_platform_driver(cortex_arm64_edac_driver) now. > noted. -Brijesh