From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751225AbbJXH20 (ORCPT ); Sat, 24 Oct 2015 03:28:26 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:36160 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbbJXH2Z (ORCPT ); Sat, 24 Oct 2015 03:28:25 -0400 Message-ID: <562b3318.c1bf440a.60511.242e@mx.google.com> X-Google-Original-Message-ID: <20151024072820.GA6361@pauldaviesc@gmail.com> Date: Sat, 24 Oct 2015 12:58:20 +0530 From: Paul Davies C To: oleg.drokin@intel.com, andreas.dilger@intel.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] lustre: obdclass: fix sparse warning MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the following warnings given by the sparse: drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: symbol 'class_procfs_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: symbol 'class_procfs_clean' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:161:5: warning: symbol 'obd_sysctl_init' was not declared. Should it be static? drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:166:6: warning: symbol 'obd_sysctl_clean' was not declared. Should it be static? Signed-off-by: Paul Davies C --- drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 4 ++-- drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c index 6218ef3..45d92c2 100644 --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c @@ -421,7 +421,7 @@ static struct attribute_group lustre_attr_group = { .attrs = lustre_attrs, }; -int class_procfs_init(void) +static int class_procfs_init(void) { int rc = -ENOMEM; struct dentry *file; @@ -457,7 +457,7 @@ out: return rc; } -int class_procfs_clean(void) +static int class_procfs_clean(void) { if (debugfs_lustre_root != NULL) debugfs_remove_recursive(debugfs_lustre_root); diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c index 1515163..6f13f21 100644 --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c @@ -158,11 +158,11 @@ static struct attribute_group lustre_attr_group = { .attrs = lustre_attrs, }; -int obd_sysctl_init(void) +static int obd_sysctl_init(void) { return sysfs_create_group(lustre_kobj, &lustre_attr_group); } -void obd_sysctl_clean(void) +static void obd_sysctl_clean(void) { } -- 1.9.1