From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754852AbbJ1AZl (ORCPT ); Tue, 27 Oct 2015 20:25:41 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:57977 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbbJ1AZi (ORCPT ); Tue, 27 Oct 2015 20:25:38 -0400 X-IronPort-AV: E=Sophos;i="5.20,207,1444719600"; d="scan'208";a="78755663" Subject: Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2 To: Brian Norris , Anup Patel References: <1445577373-21252-1-git-send-email-anup.patel@broadcom.com> <1445577373-21252-3-git-send-email-anup.patel@broadcom.com> <20151028001920.GY13239@google.com> CC: David Woodhouse , Linux MTD , Rob Herring , Pawel Moll , Mark Rutland , Catalin Marinas , Will Deacon , Sudeep Holla , Ian Campbell , "Kumar Gala" , Scott Branden , Florian Fainelli , Pramod KUMAR , Vikram Prakash , "Sandeep Tripathy" , Linux ARM Kernel , Device Tree , Linux Kernel , BCM Kernel Feedback From: Ray Jui Message-ID: <563015FC.9040006@broadcom.com> Date: Tue, 27 Oct 2015 17:25:32 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151028001920.GY13239@google.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/27/2015 5:19 PM, Brian Norris wrote: > On Fri, Oct 23, 2015 at 10:46:13AM +0530, Anup Patel wrote: >> The NAND controller on NS2 SoC is compatible with existing >> BRCM IPROC NAND driver so let's enable it in NS2 DT and >> NS2 SVK DT. >> >> This patch also fixes use of node labels in ns2-svk.dts. >> >> Signed-off-by: Anup Patel >> Reviewed-by: Ray Jui >> Reviewed-by: Scott Branden >> --- >> arch/arm64/boot/dts/broadcom/ns2-svk.dts | 30 ++++++++++++++++++++---------- >> arch/arm64/boot/dts/broadcom/ns2.dtsi | 14 ++++++++++++++ >> 2 files changed, 34 insertions(+), 10 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/broadcom/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/ns2-svk.dts >> index e5950d5..6bb3d4d 100644 >> --- a/arch/arm64/boot/dts/broadcom/ns2-svk.dts >> +++ b/arch/arm64/boot/dts/broadcom/ns2-svk.dts >> @@ -50,18 +50,28 @@ >> device_type = "memory"; >> reg = <0x000000000 0x80000000 0x00000000 0x40000000>; >> }; >> +}; >> >> - soc: soc { >> - i2c0: i2c@66080000 { >> - status = "ok"; >> - }; >> +&i2c0 { >> + status = "ok"; >> +}; >> >> - i2c1: i2c@660b0000 { >> - status = "ok"; >> - }; >> +&i2c1 { >> + status = "ok"; >> +}; >> + >> +&uart3 { >> + status = "ok"; >> +}; >> >> - uart3: serial@66130000 { >> - status = "ok"; >> - }; >> +&nand { >> + nandcs@0 { >> + compatible = "brcm,nandcs"; >> + reg = <0>; >> + nand-ecc-mode = "hw"; >> + nand-ecc-strength = <8>; >> + nand-ecc-step-size = <512>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> }; >> }; >> diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi b/arch/arm64/boot/dts/broadcom/ns2.dtsi >> index f603277..9610822 100644 >> --- a/arch/arm64/boot/dts/broadcom/ns2.dtsi >> +++ b/arch/arm64/boot/dts/broadcom/ns2.dtsi >> @@ -212,5 +212,19 @@ >> compatible = "brcm,iproc-rng200"; >> reg = <0x66220000 0x28>; >> }; >> + >> + nand: nand@66460000 { >> + compatible = "brcm,nand-iproc", "brcm,brcmnand-v6.1"; > > Technically, the binding says you should also have "brcm,brcmnand" as a > last resort. Otherwise (for the NAND parts): > I believe Anup was seeing issues when both "brcm,nand-iproc" and "brcm,brcmnand" are present. Note "brcm,nand-iproc" invokes 'iproc_nand_probe', which calls 'brcmnand_probe' in the end. "brcm,brcmnand" invokes 'brcmstb_nand_probe', which also calls 'brcmstb_probe', but without all the prep configuration required for "brcm,nand-iproc". > Reviewed-by: Brian Norris