From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754942AbbJ1BWe (ORCPT ); Tue, 27 Oct 2015 21:22:34 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:61513 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754359AbbJ1BWc (ORCPT ); Tue, 27 Oct 2015 21:22:32 -0400 X-AuditID: cbfec7f5-f794b6d000001495-59-56302354ab20 Subject: Re: [PATCH v3 4/5] clk: s2mps15: Add support for S2MPS15 clocks To: Alim Akhtar , lee.jones@linaro.org, broonie@kernel.org References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-5-git-send-email-alim.akhtar@samsung.com> Cc: mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5630234A.8080905@samsung.com> Date: Wed, 28 Oct 2015 10:22:18 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1445863883-5187-5-git-send-email-alim.akhtar@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t/xq7ohygZhBk0PLCwezNvGZjH14RM2 i9cvDC3ufz3KaPGx5x6rxeVdc9gsZpzfx2Rx8ZSrxf7ODkYHTo/3N1rZPfZMPMnmsWlVJ5vH nWt72Dz6tqxi9Pi8SS6ALYrLJiU1J7MstUjfLoErY/H7uewFB4Uqrn2dyNLA2MnfxcjBISFg IjHxm3wXIyeQKSZx4d56ti5GLg4hgaWMEl1b/7JAOF8YJdr/XWQFqRIW8JDYcaSBCcQWEQiV mDH/ATNEUTOjxIwds1lBHGaB6YwSd+Y+ZAGpYhMwlti8fAkbiM0roCVx7+dpsG4WAVWJvevm gtWICkRITJzQwApRIyjxY/I9sDingLvE5dmbmEFOZRbQk7h/UQskzCwgL7F5zVvmCYwCs5B0 zEKomoWkagEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT83E2MkPD/uoNx6TGrQ4wCHIxKPLwG FXphQqyJZcWVuYcYJTiYlUR4awQNwoR4UxIrq1KL8uOLSnNSiw8xSnOwKInzztz1PkRIID2x JDU7NbUgtQgmy8TBKdXA6DfnWeuxussPjJRtZsvmVq6e9+fz9JV84ZnRGToHdxxwvj5LnNVY K2rOY/eThw60nxbzSNr55m9r6vJinoVJfZulxA5eP+Z7jC/RX0Lh+GxH4cztmsf6MmZeE+O0 Pas/X9Ks7+2SQKuzu3mM587Injd3raycr4n3nnn7H9c99bD58+9yXXfGbyWW4oxEQy3mouJE AJ8Sz/d7AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.10.2015 21:51, Alim Akhtar wrote: > S2MPS15 PMIC has three 32k buffered clocks outputs. This patch > adds supports for the same to the s2mps11 clock driver. > > Signed-off-by: Alim Akhtar > --- > drivers/clk/Kconfig | 5 +++-- > drivers/clk/clk-s2mps11.c | 24 ++++++++++++++++++++++++ > 2 files changed, 27 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig > index a1fa61159179..037a314b5d76 100644 > --- a/drivers/clk/Kconfig > +++ b/drivers/clk/Kconfig > @@ -120,9 +120,10 @@ config COMMON_CLK_S2MPS11 > tristate "Clock driver for S2MPS1X/S5M8767 MFD" > depends on MFD_SEC_CORE > ---help--- > - This driver supports S2MPS11/S2MPS14/S5M8767 crystal oscillator > + This driver supports S2MPS1X/S5M8767 crystal oscillator > clock. These multi-function devices have two (S2MPS14) or three > - (S2MPS11, S5M8767) fixed-rate oscillators, clocked at 32KHz each. > + (S2MPS11/S2MPS13/S2MPS15/S5M8767) fixed-rate oscillators, > + clocked at 32KHz each. > > config CLK_TWL6040 > tristate "External McPDM functional clock from twl6040" > diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c > index d266299dfdb1..455500dca653 100644 > --- a/drivers/clk/clk-s2mps11.c > +++ b/drivers/clk/clk-s2mps11.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -148,6 +149,24 @@ static struct clk_init_data s2mps14_clks_init[S2MPS11_CLKS_NUM] = { > }, > }; > > +static struct clk_init_data s2mps15_clks_init[S2MPS11_CLKS_NUM] = { > + [S2MPS11_CLK_AP] = { > + .name = "s2mps15_ap", > + .ops = &s2mps11_clk_ops, > + .flags = CLK_IS_ROOT, > + }, > + [S2MPS11_CLK_CP] = { > + .name = "s2mps15_cp", > + .ops = &s2mps11_clk_ops, > + .flags = CLK_IS_ROOT, > + }, > + [S2MPS11_CLK_BT] = { > + .name = "s2mps15_bt", > + .ops = &s2mps11_clk_ops, > + .flags = CLK_IS_ROOT, > + }, > +}; I see that for S2MPS13 we already added similar array which duplicates the S2MPS11. This actually looks wrong. Just re-use existing s2mps11_clks_init. Best regards, Krzysztof