From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755046AbbJ1B2Q (ORCPT ); Tue, 27 Oct 2015 21:28:16 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:14868 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754879AbbJ1B2P (ORCPT ); Tue, 27 Oct 2015 21:28:15 -0400 X-AuditID: cbfec7f5-f794b6d000001495-cb-563024ab6626 Subject: Re: [PATCH v3 2/5] mfd: sec: Add support for S2MPS15 PMIC To: Alim Akhtar , lee.jones@linaro.org, broonie@kernel.org References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-3-git-send-email-alim.akhtar@samsung.com> Cc: mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Thomas Abraham From: Krzysztof Kozlowski Message-id: <563024A5.1050705@samsung.com> Date: Wed, 28 Oct 2015 10:28:05 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1445863883-5187-3-git-send-email-alim.akhtar@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsVy+t/xq7qrVQzCDJ5/1LV4MG8bm8XUh0/Y LF6/MLS4//Uoo8XHnnusFpd3zWGzmHF+H5PFxVOuFvs7OxgtOpYxOnB5vL/Ryu6xZ+JJNo9N qzrZPO5c28Pm0bdlFaPH501yAWxRXDYpqTmZZalF+nYJXBnT1k1kLvjLX3F32SfmBsbfPF2M nBwSAiYSh6/PZoGwxSQu3FvP1sXIxSEksJRRYtX0rUwQzhdGiXfvm4CqODiEBZwkXh+TBWkQ EQiVmDH/ATNETTOjxL/mLywgDrPAfiDn2DR2kCo2AWOJzcuXsIHYvAJaEj/7fjCB2CwCqhLN k9+wgtiiAhESEyc0sELUCEr8mHwP7CROAXeJHX3z2UAWMwvoSdy/qAUSZhaQl9i85i3zBEaB WUg6ZiFUzUJStYCReRWjaGppckFxUnqukV5xYm5xaV66XnJ+7iZGSBx83cG49JjVIUYBDkYl Hl6DCr0wIdbEsuLK3EOMEhzMSiK8NYIGYUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIk kJ5YkpqdmlqQWgSTZeLglGpgXHx3p1+tg9FH269mnqUaswx/zNn6Md1hieqrhKnvFpW+XBix 7kfYZaO4uphU0fzH1oLZ7vOP1nA9ipNNyvuelZxdbtY+S2CPZcF39341s6rXJ2Xi/4rULmJY /cfa/dMx8f/XdRwncigJRsyTi47gFBYR/fA2t9I64b6XSu+KsitWgX36mpeVWIozEg21mIuK EwH3qPCSfwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.10.2015 21:51, Alim Akhtar wrote: > From: Thomas Abraham > > Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 > PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz > clock outputs and battery charger. This patch adds initial support for > LDO and buck regulators of S2MPS15 device. > > Signed-off-by: Thomas Abraham > Signed-off-by: Alim Akhtar > [Alim: Added s2mps15_devs like rtc and clk and related changes] > Reviewed-by: Krzysztof Kozlowski > --- > drivers/mfd/sec-core.c | 31 +++++++ > drivers/mfd/sec-irq.c | 8 ++ > include/linux/mfd/samsung/core.h | 1 + > include/linux/mfd/samsung/s2mps15.h | 158 +++++++++++++++++++++++++++++++++++ > 4 files changed, 198 insertions(+) > create mode 100644 include/linux/mfd/samsung/s2mps15.h > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index 2626fc0b5b8c..db3d4d4ff805 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -96,6 +97,17 @@ static const struct mfd_cell s2mps14_devs[] = { > } > }; > > +static const struct mfd_cell s2mps15_devs[] = { > + { > + .name = "s2mps15-pmic", > + }, { > + .name = "s2mps15-rtc", > + }, { > + .name = "s2mps15-clk", > + .of_compatible = "samsung,s2mps15-clk", > + }, I have different questions here. RTC and CLK module look the same as S2MPS14. Then you should existing compatibles and names. I'll ask in details about this in separate emails for patch 4 and 5. Until questions are resolved, these looks wrong. Best regards, Krzysztof