From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932301AbbJ1BaG (ORCPT ); Tue, 27 Oct 2015 21:30:06 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:62440 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754735AbbJ1BaE (ORCPT ); Tue, 27 Oct 2015 21:30:04 -0400 X-AuditID: cbfec7f5-f794b6d000001495-3d-56302519c62a Subject: Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC To: Alim Akhtar , lee.jones@linaro.org, broonie@kernel.org References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-6-git-send-email-alim.akhtar@samsung.com> Cc: mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56302514.4090407@samsung.com> Date: Wed, 28 Oct 2015 10:29:56 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1445863883-5187-6-git-send-email-alim.akhtar@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t/xa7qSqgZhBi9vclk8mLeNzWLqwyds Fq9fGFrc/3qU0eJjzz1Wi8u75rBZzDi/j8ni4ilXi/2dHYwOnB7vb7Sye+yZeJLNY9OqTjaP O9f2sHn0bVnF6PF5k1wAWxSXTUpqTmZZapG+XQJXRvudTtaCQwoVm0/GNTDelOxi5OSQEDCR aPz7hw3CFpO4cG89kM3FISSwlFFi0fsZzBDOF0aJrrXvWEGqhAX8JNbPfM4OYosIhErMmP8A qqiZUeLwsn/sIA6zwHRGiTtzH7KAVLEJGEtsXr4EaoecRG/3JLA4r4CWxNlXH4CmcnCwCKhK 7FtmDBIWFYiQmDihgRWiRFDix+R7YOWcAu4SZ5duYgQpZxbQk7h/UQskzCwgL7F5zVvmCYyC s5B0zEKomoWkagEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT83E2MkKj4uoNx6TGrQ4wCHIxK PLwGFXphQqyJZcWVuYcYJTiYlUR4awQNwoR4UxIrq1KL8uOLSnNSiw8xSnOwKInzztz1PkRI ID2xJDU7NbUgtQgmy8TBKdXAaMIVGur/M1zt4Lap03eXmz06FOoz7/ADNsWKv09eXfRd/Fyl 9Nbavs8BW19fjF1tKrLQPEzqPJeG/dT4fMfu334zDzXcTvEW/FUWLKE6XzQ8+/k6dW/xrlnz l8nZWvE9Zjx4OWbWL693Bw5E9x2Jv/lp/6q8xkPPNka+OXXcs1a1pu6On8nbHCWW4oxEQy3m ouJEAK8ooR6GAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26.10.2015 21:51, Alim Akhtar wrote: > RTC found in s2mps15 is almost same as one found in s2mps14. > This patch add required changes to enable s2mps15 rtc timer. > > Signed-off-by: Alim Akhtar > --- > drivers/rtc/rtc-s5m.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) NACK. I don't have S2MPS15 datasheet but looking at the code right now this looks *exactly the same* device as S2MPS14. If that's true, then don't add new compatibles, new names etc. Re-use. No new code needed, no changes needed. Keep it simple. Best regards, Krzysztof > > diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c > index f2504b4eef34..ac3286a267ba 100644 > --- a/drivers/rtc/rtc-s5m.c > +++ b/drivers/rtc/rtc-s5m.c > @@ -188,6 +188,7 @@ static inline int s5m_check_peding_alarm_interrupt(struct s5m_rtc_info *info, > ret = regmap_read(info->regmap, S5M_RTC_STATUS, &val); > val &= S5M_ALARM0_STATUS; > break; > + case S2MPS15X: > case S2MPS14X: > case S2MPS13X: > ret = regmap_read(info->s5m87xx->regmap_pmic, S2MPS14_REG_ST2, > @@ -253,6 +254,7 @@ static inline int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) > data &= ~S5M_RTC_TIME_EN_MASK; > break; > case S2MPS14X: > + case S2MPS15X: > data |= S2MPS_RTC_RUDR_MASK; > break; > case S2MPS13X: > @@ -317,7 +319,8 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm) > u8 data[info->regs->regs_count]; > int ret; > > - if (info->device_type == S2MPS14X || info->device_type == S2MPS13X) { > + if (info->device_type == S2MPS14X || info->device_type == S2MPS15X || > + info->device_type == S2MPS13X) { > ret = regmap_update_bits(info->regmap, > info->regs->rtc_udr_update, > S2MPS_RTC_RUDR_MASK, S2MPS_RTC_RUDR_MASK); > @@ -339,6 +342,7 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm) > break; > > case S5M8767X: > + case S2MPS15X: > case S2MPS14X: > case S2MPS13X: > s5m8767_data_to_tm(data, tm, info->rtc_24hr_mode); > @@ -366,6 +370,7 @@ static int s5m_rtc_set_time(struct device *dev, struct rtc_time *tm) > s5m8763_tm_to_data(tm, data); > break; > case S5M8767X: > + case S2MPS15X: > case S2MPS14X: > case S2MPS13X: > ret = s5m8767_tm_to_data(tm, data); > @@ -414,6 +419,7 @@ static int s5m_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) > break; > > case S5M8767X: > + case S2MPS15X: > case S2MPS14X: > case S2MPS13X: > s5m8767_data_to_tm(data, &alrm->time, info->rtc_24hr_mode); > @@ -463,6 +469,7 @@ static int s5m_rtc_stop_alarm(struct s5m_rtc_info *info) > break; > > case S5M8767X: > + case S2MPS15X: > case S2MPS14X: > case S2MPS13X: > for (i = 0; i < info->regs->regs_count; i++) > @@ -508,6 +515,7 @@ static int s5m_rtc_start_alarm(struct s5m_rtc_info *info) > break; > > case S5M8767X: > + case S2MPS15X: > case S2MPS14X: > case S2MPS13X: > data[RTC_SEC] |= ALARM_ENABLE_MASK; > @@ -548,6 +556,7 @@ static int s5m_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) > break; > > case S5M8767X: > + case S2MPS15X: > case S2MPS14X: > case S2MPS13X: > s5m8767_tm_to_data(&alrm->time, data); > @@ -631,6 +640,7 @@ static int s5m8767_rtc_init_reg(struct s5m_rtc_info *info) > ret = regmap_raw_write(info->regmap, S5M_ALARM0_CONF, data, 2); > break; > > + case S2MPS15X: > case S2MPS14X: > case S2MPS13X: > data[0] = (0 << BCD_EN_SHIFT) | (1 << MODEL24_SHIFT); > @@ -679,6 +689,7 @@ static int s5m_rtc_probe(struct platform_device *pdev) > return -ENOMEM; > > switch (platform_get_device_id(pdev)->driver_data) { > + case S2MPS15X: > case S2MPS14X: > case S2MPS13X: > regmap_cfg = &s2mps14_rtc_regmap_config; > @@ -805,6 +816,7 @@ static const struct platform_device_id s5m_rtc_id[] = { > { "s5m-rtc", S5M8767X }, > { "s2mps13-rtc", S2MPS13X }, > { "s2mps14-rtc", S2MPS14X }, > + { "s2mps15-rtc", S2MPS15X }, > { }, > }; > MODULE_DEVICE_TABLE(platform, s5m_rtc_id); >