From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755347AbbJ1CSI (ORCPT ); Tue, 27 Oct 2015 22:18:08 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:62032 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbbJ1CSF (ORCPT ); Tue, 27 Oct 2015 22:18:05 -0400 X-AuditID: cbfec7f5-f794b6d000001495-5a-563030591564 Subject: Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC To: Mark Brown References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-6-git-send-email-alim.akhtar@samsung.com> <56302514.4090407@samsung.com> <20151028015323.GZ28319@sirena.org.uk> Cc: Alim Akhtar , lee.jones@linaro.org, mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56303054.8060804@samsung.com> Date: Wed, 28 Oct 2015 11:17:56 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <20151028015323.GZ28319@sirena.org.uk> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t/xy7qRBgZhBpva1CwezNvGZjH14RM2 i9cvDC3ufz3KaPGx5x6rxeVdc9gsZpzfx2Rx8ZSrxf7ODkYHTo/3N1rZPfZMPMnmsWlVJ5vH nWt72Dz6tqxi9Pi8SS6ALYrLJiU1J7MstUjfLoErY9bsuIIP7BU/O5ezNjDOZeti5OSQEDCR aJ19lQXCFpO4cG89UJyLQ0hgKaNE39zJUM4XRolHC+8wg1QJC/hJrJ/5nB3EFhFQlrj6fS8L RNFpRonTc04xgzjMAtcYJWb/W8UKUsUmYCyxefkSsH28AloSS16eBpvEIqAq0b/qOthuUYEI iYkTGlghagQlfky+BxbnBOp9vuAQUC8H0FA9ifsXtUDCzALyEpvXvGWewCgwC0nHLISqWUiq FjAyr2IUTS1NLihOSs810itOzC0uzUvXS87P3cQICf+vOxiXHrM6xCjAwajEw2tQoRcmxJpY VlyZe4hRgoNZSYS3RtAgTIg3JbGyKrUoP76oNCe1+BCjNAeLkjjvzF3vQ4QE0hNLUrNTUwtS i2CyTBycUg2M2Qc+R6ZYNZUeTF+4e7XW/Vj+Aq7KKZN7WNSmiV5ZqrXm6WyWb19WM3x+xuXY FRzuc0g9PTtIqVHw6VXN760RXW6i7nfq/Hv3M/91VWhhnzXxnGVPiq9qhhL724jw9plOk84o ZSgs2bBZeA+/VnrNJIuZe+R2Hzi38UXq5rSiSye05jZ8iMlVYinOSDTUYi4qTgQAQAUfsXsC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.10.2015 10:53, Mark Brown wrote: > On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: > >> If that's true, then don't add new compatibles, new names etc. Re-use. >> No new code needed, no changes needed. Keep it simple. > > Well, it depends - it can be useful to get the information about it > being a different part into DT so that if in future we realise that > there is some difference (perhaps a bug workaround even if the IP is > intended to be the same). Though in the case of a MFD that information > can be obtained from the MFD for the device. We can always differentiate later and introduce new compatible. Declaring a compatible right now would be useful only if we really cared about using the workaround on older DTBs. Since I cannot judge the difference (I don't have the datasheet of S2MPS15) then I don't see the need of adding new compatible/name for the "same device". Of course maybe there is such need? Alim? Best regards, Krzysztof