From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755402AbbJ1DYX (ORCPT ); Tue, 27 Oct 2015 23:24:23 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:45450 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751976AbbJ1DYU (ORCPT ); Tue, 27 Oct 2015 23:24:20 -0400 X-AuditID: cbfee68e-f791c6d000001498-5a-56303fe25be5 Message-id: <56303DA3.5020306@samsung.com> Date: Wed, 28 Oct 2015 08:44:43 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Mark Brown Cc: lee.jones@linaro.org, mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-6-git-send-email-alim.akhtar@samsung.com> <56302514.4090407@samsung.com> <20151028015323.GZ28319@sirena.org.uk> <56303054.8060804@samsung.com> In-reply-to: <56303054.8060804@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsWyRsSkVveRvUGYwbtbuhZTHz5hs3j9wtDi /tejjBYfe+6xWlzeNYfNYsb5fUwWF0+5Wuzv7GB04PB4f6OV3WPPxJNsHptWdbJ53Lm2h82j b8sqRo/Pm+QC2KK4bFJSczLLUov07RK4MhYdvstY8Ie7ovXQBtYGxq2cXYycHBICJhIzNvxj gbDFJC7cW8/WxcjFISSwglFizuOtLDBFfU9/MUIkljJKrN71ggXCecAocXf9RHaQKl4BLYnJ MxeygtgsAqoSLVvamUBsNgFtibvTtwDZHByiAhESjy8IQZQLSvyYfI8FJCwiECKx94QhyEhm gbWMEr2HrrOB1AgL+Emsn/mcHWLXG0aJvh2vweZwAs1s2hcNUsMsYCux4P06FghbXmLzmrfM IPUSAvfYJVovTmOHuEdA4tvkQ2DLJARkJTYdYIZ4TFLi4IobLBMYxWYhOWkWkrGzkIxdwMi8 ilE0tSC5oDgpvchIrzgxt7g0L10vOT93EyMwDk//e9a3g/HmAetDjAIcjEo8vAYVemFCrIll xZW5hxhNga6YyCwlmpwPjPa8knhDYzMjC1MTU2Mjc0szJXHeBKmfwUIC6YklqdmpqQWpRfFF pTmpxYcYmTg4pRoYu+aJn15nElLquDt4iQbH1hSO7WfuyU3Mfa54iPXwRPWkTcae9fMVEjqr eLJDD15beK2rYn5Lc/jeD8YX7qdrRb7JV/q8NVJ/l0JvnOs0wc1/VpWm5Ly5MznyfezH7u3n d/1muifepJV3nnd67YsJuRr6M7zKHTaH14mfMU+PELkYv9JlWe1yJZbijERDLeai4kQAp8t0 r74CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBIsWRmVeSWpSXmKPExsVy+t9jAd1H9gZhBseeq1lMffiEzeL1C0OL +1+PMlp87LnHanF51xw2ixnn9zFZXDzlarG/s4PRgcPj/Y1Wdo89E0+yeWxa1cnmcefaHjaP vi2rGD0+b5ILYItqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy 8QnQdcvMAbpHSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5vSBBcj5EBGkhYw5ix6PBdxoI/ 3BWthzawNjBu5exi5OSQEDCR6Hv6ixHCFpO4cG89WxcjF4eQwFJGidW7XrBAOA8YJe6un8gO UsUroCUxeeZCVhCbRUBVomVLOxOIzSagLXF3+hYgm4NDVCBC4vEFIYhyQYkfk++xgIRFBEIk 9p4wBBnJLLCWUaL30HU2kBphAT+J9TOfs0PsesMo0bfjNdgcTqCZTfuiQWqYBWwlFrxfxwJh y0tsXvOWeQKjwCwkK2YhKZuFpGwBI/MqRonUguSC4qT0XKO81HK94sTc4tK8dL3k/NxNjOBY fya9g/HwLvdDjAIcjEo8vAYVemFCrIllxZW5hxglOJiVRHhrBA3ChHhTEiurUovy44tKc1KL DzGaAsNgIrOUaHI+MA3llcQbGpuYmxqbWppYmJhZKonzXsjQCBMSSE8sSc1OTS1ILYLpY+Lg lGpgFHJWrGV5wM287N6H2TcX3mNj7XvZs0rr9VTVN+c5e8T3e0bv42mNkj5ufP6S3WKTOW8k rVqWX7k9fRlzjIJCyR/OnqpX1tlrlNyUXaY+T13drN+9IPDIocyIl7uXWHyS+cfrzpG4svnl pFl/TBitfm++EnaZQ6zhkMd2jqBDeb4m86x2W0o+VmIpzkg01GIuKk4EAFQkATALAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 10/28/2015 07:47 AM, Krzysztof Kozlowski wrote: > On 28.10.2015 10:53, Mark Brown wrote: >> On Wed, Oct 28, 2015 at 10:29:56AM +0900, Krzysztof Kozlowski wrote: >> >>> If that's true, then don't add new compatibles, new names etc. Re-use. >>> No new code needed, no changes needed. Keep it simple. >> >> Well, it depends - it can be useful to get the information about it >> being a different part into DT so that if in future we realise that >> there is some difference (perhaps a bug workaround even if the IP is >> intended to be the same). Though in the case of a MFD that information >> can be obtained from the MFD for the device. > > We can always differentiate later and introduce new compatible. > Declaring a compatible right now would be useful only if we really cared > about using the workaround on older DTBs. > > Since I cannot judge the difference (I don't have the datasheet of > S2MPS15) then I don't see the need of adding new compatible/name for the > "same device". > > Of course maybe there is such need? Alim? > Well I did think of keeping the changes as minimal as possible, like just have "{ "s2mps15-rtc", S2MPS14X }", since I don't have access to s2mps14 UM, I could not confirm that s2mps14 and s2mps15 are exactly the same w.r.t rtc block. So I proposed the current changes. Well I do agree with Mark here, a name/compatible matching with the pmic is good to at least avoid confusion while looking at the sysfs. > Best regards, > Krzysztof >