From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755360AbbJ1DqN (ORCPT ); Tue, 27 Oct 2015 23:46:13 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:41310 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbbJ1DqK (ORCPT ); Tue, 27 Oct 2015 23:46:10 -0400 X-AuditID: cbfee691-f79d66d000001509-6d-5630450096ef Message-id: <563042D7.7020907@samsung.com> Date: Wed, 28 Oct 2015 09:06:55 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , lee.jones@linaro.org, broonie@kernel.org Cc: mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/5] clk: s2mps15: Add support for S2MPS15 clocks References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-5-git-send-email-alim.akhtar@samsung.com> <5630234A.8080905@samsung.com> In-reply-to: <5630234A.8080905@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsWyRsSkWpfB1SDMoPcah8XUh0/YLF6/MLS4 //Uoo8XHnnusFpd3zWGzmHF+H5PFxVOuFvs7OxgdODze32hl99gz8SSbx6ZVnWwed67tYfPo 27KK0ePzJrkAtigum5TUnMyy1CJ9uwSujO2n77MXPBWumHnxHGMDY69AFyMHh4SAicSKztAu Rk4gU0ziwr31bF2MXBxCAisYJVbPOckGkTCR+LXlOVRiKaPE1SUnGSGcB4wSz1/1s4BU8Qpo SXyZeBLMZhFQleiaOI8JxGYT0Ja4O30LE8g2UYEIiccXhCDKBSV+TL7HAhIWEYiV+PVFB2Qk s8B0Rok7cx+CjREW8JDYcaSBCWLXEkaJD72HwBKcQDO/bTkPNp9ZwFZiwft1LBC2vMTmNW+Z QRokBG6xS8y/u4gJ4iABiW+TD7FAvCwrsekAM8RnkhIHV9xgmcAoNgvJTbOQjJ2FZOwCRuZV jKKpBckFxUnpRaZ6xYm5xaV56XrJ+bmbGIFxePrfs4k7GO8fsD7EKMDBqMTDa1ChFybEmlhW XJl7iNEU6IqJzFKiyfnAaM8riTc0NjOyMDUxNTYytzRTEufVkf4ZLCSQnliSmp2aWpBaFF9U mpNafIiRiYNTqoGxfvaje5MKd+ZXfCp2rFnUbeEYtuL12p6HjHwziqbYiC2f+OKL1tuwV9/2 zn7YUVL9wjHwg+OX1x0Hs7p/V1yXyj5e/JfVUPnMCRHmrz0J1yYU/6gu2rwlIW1+/547319r nw+dlhB3ruJI9Z4jSs6el9epf1JIePR+hZz6TIP7bYsvW8Z83Z59SImlOCPRUIu5qDgRANXR aCq+AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsVy+t9jAV0GV4Mwg4lHGS2mPnzCZvH6haHF /a9A3seee6wWl3fNYbOYcX4fk8XFU64W+zs7GB04PN7faGX32DPxJJvHplWdbB53ru1h8+jb sorR4/MmuQC2qAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRef AF23zByge5QUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhDWMGdtP32cveCpc MfPiOcYGxl6BLkZODgkBE4lfW56zQdhiEhfurQeyuTiEBJYySlxdcpIRwnnAKPH8VT8LSBWv gJbEl4knwWwWAVWJronzmEBsNgFtibvTtwDZHByiAhESjy8IQZQLSvyYfI8FJCwiECvx64sO yEhmgemMEnfmPgQbIyzgIbHjSAMTxK4ljBIfeg+BJTiBZn7bch5sPrOArcSC9+tYIGx5ic1r 3jJPYBSYhWTHLCRls5CULWBkXsUokVqQXFCclJ5rlJdarlecmFtcmpeul5yfu4kRHO3PpHcw Ht7lfohRgINRiYfXoEIvTIg1say4MvcQowQHs5IIb42gQZgQb0piZVVqUX58UWlOavEhRlNg IExklhJNzgcmorySeENjE3NTY1NLEwsTM0slcd4LGRphQgLpiSWp2ampBalFMH1MHJxSDYzz PFfPejm/ZMnJ7TnzDN039tp5HVCsaufL+9Z1/5oIo+bVTZs4uWaFvmXM+P+s8Xe4Of+ikLZj iz8fSEv5FDVPaEnptm+M1ZZ96+z2Z4n0zpN5p3NDYu3kW+p2vwULqhetLX7p/qJ+jjYzS9LM V4+UDCs+2nsYqKfWPrfWvL595fFfPG5WTqZKLMUZiYZazEXFiQASMJ6TDAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello On 10/28/2015 06:52 AM, Krzysztof Kozlowski wrote: > On 26.10.2015 21:51, Alim Akhtar wrote: >> S2MPS15 PMIC has three 32k buffered clocks outputs. This patch >> adds supports for the same to the s2mps11 clock driver. >> >> Signed-off-by: Alim Akhtar >> --- >> drivers/clk/Kconfig | 5 +++-- >> drivers/clk/clk-s2mps11.c | 24 ++++++++++++++++++++++++ >> 2 files changed, 27 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig >> index a1fa61159179..037a314b5d76 100644 >> --- a/drivers/clk/Kconfig >> +++ b/drivers/clk/Kconfig >> @@ -120,9 +120,10 @@ config COMMON_CLK_S2MPS11 >> tristate "Clock driver for S2MPS1X/S5M8767 MFD" >> depends on MFD_SEC_CORE >> ---help--- >> - This driver supports S2MPS11/S2MPS14/S5M8767 crystal oscillator >> + This driver supports S2MPS1X/S5M8767 crystal oscillator >> clock. These multi-function devices have two (S2MPS14) or three >> - (S2MPS11, S5M8767) fixed-rate oscillators, clocked at 32KHz each. >> + (S2MPS11/S2MPS13/S2MPS15/S5M8767) fixed-rate oscillators, >> + clocked at 32KHz each. >> >> config CLK_TWL6040 >> tristate "External McPDM functional clock from twl6040" >> diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c >> index d266299dfdb1..455500dca653 100644 >> --- a/drivers/clk/clk-s2mps11.c >> +++ b/drivers/clk/clk-s2mps11.c >> @@ -25,6 +25,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> @@ -148,6 +149,24 @@ static struct clk_init_data s2mps14_clks_init[S2MPS11_CLKS_NUM] = { >> }, >> }; >> >> +static struct clk_init_data s2mps15_clks_init[S2MPS11_CLKS_NUM] = { >> + [S2MPS11_CLK_AP] = { >> + .name = "s2mps15_ap", >> + .ops = &s2mps11_clk_ops, >> + .flags = CLK_IS_ROOT, >> + }, >> + [S2MPS11_CLK_CP] = { >> + .name = "s2mps15_cp", >> + .ops = &s2mps11_clk_ops, >> + .flags = CLK_IS_ROOT, >> + }, >> + [S2MPS11_CLK_BT] = { >> + .name = "s2mps15_bt", >> + .ops = &s2mps11_clk_ops, >> + .flags = CLK_IS_ROOT, >> + }, >> +}; > > I see that for S2MPS13 we already added similar array which duplicates > the S2MPS11. This actually looks wrong. Just re-use existing > s2mps11_clks_init. > hmm..ok will do. > Best regards, > Krzysztof > >