From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755372AbbJ1Dsz (ORCPT ); Tue, 27 Oct 2015 23:48:55 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:53377 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751556AbbJ1Dsw (ORCPT ); Tue, 27 Oct 2015 23:48:52 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68f-f796f6d0000014a4-ab-563045a23808 Content-transfer-encoding: 8BIT Message-id: <563045A4.1050504@samsung.com> Date: Wed, 28 Oct 2015 12:48:52 +0900 From: Ingi Kim User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Jacek Anaszewski Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, sameo@linux.intel.com, lee.jones@linaro.org, rpurdie@rpsys.net, inki.dae@samsung.com, sw0312.kim@samsung.com, beomho.seo@samsung.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033 References: <1445579285-6866-1-git-send-email-ingi2.kim@samsung.com> <1445579285-6866-2-git-send-email-ingi2.kim@samsung.com> <562DFC47.6050904@samsung.com> In-reply-to: <562DFC47.6050904@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNIsWRmVeSWpSXmKPExsWyRsSkRHeRq0GYQWeztMXpT9vYLeYfOcdq 0f9mIavFuVcrGS0m3Z/AYtF79Tmjxf2vRxktLu+aw2ax9c06Roul1y8yWUyYvpbFonXvEXaL 3bueslqc7ma1mDH5JZsDv8eaeWsYPS739TJ5rFz+hc1j06pONo871/awecw7GeixZ/4PVo++ LasYPT5vkgvgjOKySUnNySxLLdK3S+DK6F18m7HgvWBF24UTjA2Mk/i6GDk5JARMJK5emsUO YYtJXLi3nq2LkYtDSGAFo0TT1TfsMEVHlp1jhUjMYpSYM+UcI0iCV0BQ4sfkeyxdjBwczALy EkcuZUOY6hJTpuRClD9glPhx8hgzRLmWxJsv85hAbBYBVYmrLw+xgthsAmoSN1YsBIuLCiRI HD/7A8wWEdCXaGjoYwQZxCxwk0ni6+8WNpCEsICzxNtz16AuXcAocf7fcrBJnALaEsuW/2KE uHolh8ShRSIQ2wQkvk0+BHaohICsxKYDzBAlkhIHV9xgmcAoNgvJO7MQ3pmF8M4CRuZVjKKp BckFxUnpRcZ6xYm5xaV56XrJ+bmbGIFxfvrfs/4djHcPWB9iFOBgVOLhNajQCxNiTSwrrsw9 xGgKdMNEZinR5HxgMskriTc0NjOyMDUxNTYytzRTEuddKPUzWEggPbEkNTs1tSC1KL6oNCe1 +BAjEwenVANjdNxyp62M72fl7L/VtjkyfsLq7hyV5uliq1K/f1SVYZDc133ErfkmH58D41yt pvdsv5KiVFfydW/73vxL91HHc/FK2SnrK0WY3vRkXFZewdegIic5mY/nSukjyayzM1S2nZ7s bMhydYez/u75G4I6v65qkIqRvqx0a0aTDX9M9Z5lPm1NbtJKLMUZiYZazEXFiQB/hxfM7gIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJKsWRmVeSWpSXmKPExsVy+t9jQd1FrgZhBscbhCxOf9rGbjH/yDlW i/43C1ktzr1ayWgx6f4EFoveq88ZLe5/PcpocXnXHDaLrW/WMVosvX6RyWLC9LUsFq17j7Bb 7N71lNXidDerxYzJL9kc+D3WzFvD6HG5r5fJY+XyL2wem1Z1snncubaHzWPeyUCPPfN/sHr0 bVnF6PF5k1wAZ1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKL T4CuW2YO0AdKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMIaxozexbcZC94L VrRdOMHYwDiJr4uRk0NCwETiyLJzrBC2mMSFe+vZuhi5OIQEZjFKzJlyjhEkwSsgKPFj8j2W LkYODmYBeYkjl7IhTHWJKVNyIcofMEr8OHmMGaJcS+LNl3lMIDaLgKrE1ZeHwOazCahJ3Fix ECwuKpAgcfzsDzBbREBfoqGhjxFkELPATSaJr79b2EASwgLOEm/PXYM6aAGjxPl/y8EmcQpo Syxb/otxAiPQmQj3zUK4bxbCfQsYmVcxSqQWJBcUJ6XnGuallusVJ+YWl+al6yXn525iBCeT Z1I7GA/ucj/EKMDBqMTD+7NIP0yINbGsuDL3EKMEB7OSCG+NoEGYEG9KYmVValF+fFFpTmrx IUZToAcnMkuJJucDE11eSbyhsYmZkaWRuaGFkbG5kjjvhQyNMCGB9MSS1OzU1ILUIpg+Jg5O qQZGhfedP749upx3dLlOBYvAFttJxzwmF59a+0/xleMBl8AFB5cILD3y8dxhdoM29h2XJ8bd O/JuUUG6WYVygATfj5oHhsJzEj22n1zNeapvw8Iq1RUGPZ7FlRFOlyav9Nhp6fDCtfKZ0cSW oxxuc0w4bQR9JtVc7naon/uiL+tmenwjd09kVNABJZbijERDLeai4kQAViInXDwDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacek, Oh, I see. I'll add. Thanks for the review. On 2015년 10월 26일 19:11, Jacek Anaszewski wrote: > Hi Ingi, > > On 10/23/2015 07:48 AM, Ingi Kim wrote: >> This patch adds the device tree bindings for RT5033 flash LEDs. >> >> Signed-off-by: Ingi Kim >> Acked-by: Rob Herring >> --- >> .../devicetree/bindings/leds/leds-rt5033.txt | 38 ++++++++++++++++++++++ >> 1 file changed, 38 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-rt5033.txt b/Documentation/devicetree/bindings/leds/leds-rt5033.txt >> new file mode 100644 >> index 0000000..2ef7bdc >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/leds/leds-rt5033.txt >> @@ -0,0 +1,38 @@ >> +* Richtek Technology Corporation - RT5033 Flash LED Driver >> + >> +The RT5033 Flash LED Circuit is designed for one or two LEDs driving > > These bindings don't say how to handle two LEDs case. > >> +for torch and strobe applications, it provides an I2C software command >> +to trigger the torch and strobe operation. >> + >> +Required properties: >> +- compatible : Must be "richtek,rt5033-led". >> + >> +A discrete LED element connected to the device must be represented by a child >> +node - see Documentation/devicetree/bindings/leds/common.txt. >> + >> +Required properties of the LED child node: >> + See Documentation/devicetree/bindings/leds/common.txt >> +- led-max-microamp : Minimum Threshold for Timer protection >> + is defined internally (Maximum 200mA). >> +- flash-max-microamp : Flash LED maximum current >> +- flash-max-timeout-us : Flash LED maximum timeout >> + >> +Optional properties of the LED child node: >> +- label : see Documentation/devicetree/bindings/leds/common.txt >> + >> +Example: >> + >> +rt5033 { >> + compatible = "richtek,rt5033"; >> + >> + led { >> + compatible = "richtek,rt5033-led"; >> + >> + flash-led { >> + label = "rt5033-flash"; >> + led-max-microamp = <200000>; >> + flash-max-microamp = <800000>; >> + flash-max-timeout-us = <1216000>; >> + }; >> + }; >> +} >> > >