From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755646AbbJ1KE7 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 28 Oct 2015 06:04:59 -0400
Received: from mx2.suse.de ([195.135.220.15]:45191 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752829AbbJ1KE6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 28 Oct 2015 06:04:58 -0400
Subject: Re: [PATCH] coccinelle: misc: remove "complex return code" warnings
To: Johan Hovold <johan@kernel.org>
References: <1443652647-23097-1-git-send-email-johan@kernel.org>
 <alpine.DEB.2.10.1510031825170.2586@hadrien>
 <20151028095414.GD28572@localhost>
Cc: Julia Lawall <julia.lawall@lip6.fr>, Gilles Muller <Gilles.Muller@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>, linux-kernel@vger.kernel.org,
        cocci@systeme.lip6.fr
From: Michal Marek <mmarek@suse.com>
Message-ID: <56309DC8.5030202@suse.com>
Date: Wed, 28 Oct 2015 11:04:56 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20151028095414.GD28572@localhost>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dne 28.10.2015 v 10:54 Johan Hovold napsal(a):
> On Sat, Oct 03, 2015 at 06:25:39PM +0200, Julia Lawall wrote:
>> Should have acked this message...
>>
>> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>>
>> On Wed, 30 Sep 2015, Johan Hovold wrote:
>>
>>> This effectively reverts 932058a5d5f9 ("coccinelle: misc: semantic patch
>>> to delete overly complex return code processing").
>>>
>>> There can be both symmetry and readability reasons for not wanting to do
>>> the final function call as part of the return statement and to maintain
>>> a clear separation of success and error paths.
>>>
>>> Since this is in no way mandated by the coding standard, let's just
>>> remove this semantic patch to avoid having "clean up" patches being
>>> posted over and over in response to these Coccinelle warnings.
>>>
>>> Signed-off-by: Johan Hovold <johan@kernel.org>
> 
> Is anyone planning on picking this patch up?

It is already in kbuild.git as commit 1a617a8475e8, I apparenly forgot
to reply to this thread.

Michal