From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965894AbbJ1NNu (ORCPT ); Wed, 28 Oct 2015 09:13:50 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34341 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965702AbbJ1NNr (ORCPT ); Wed, 28 Oct 2015 09:13:47 -0400 Subject: Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag To: Lee Jones , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= References: <1445960557-24328-1-git-send-email-lee.jones@linaro.org> <20151027172428.GB21070@earth> <20151027181555.GE5828@x1> <1445971482.2757.27.camel@perches.com> <20151028082446.GF5828@x1> <56309419.4060908@samsung.com> <20151028093907.GP4931@pengutronix.de> <20151028095524.GP5828@x1> Cc: k.kozlowski.k@gmail.com, wsa@the-dreams.de, linus.walleij@linaro.org, Sebastian Reichel , linux-kernel@vger.kernel.org, Chanwoo Choi , broonie@kernel.org, ben-linux@fluff.org, Joe Perches , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-ID: <5630CA06.7050503@samsung.com> Date: Wed, 28 Oct 2015 22:13:42 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151028095524.GP5828@x1> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 28.10.2015 o 18:55, Lee Jones pisze: > On Wed, 28 Oct 2015, Uwe Kleine-König wrote: > >> Hello, >> >> On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote: >>> On 28.10.2015 17:24, Lee Jones wrote: >>>> You guys are pushing back like this is some kind of demotion. >>>> That's not the case at all. All it does is better describe the (very >>>> worthy) function you *actually* provide. >>> >>> It is getting into dispute about entire change of yours... which is not >>> what I want. I agree with your general idea but I was referring only to >>> that particular case - the Samsung PMICs (and Maxim PMICs/MUICs which >>> would fall into same category). >> >> Not being affected by this change, I wonder what the technical >> difference is if someone is listed as reviewer instead of maintainer. >> Does get_maintainer.pl behave differently? > > Reviewers are people who should be Cc'ed on all patches, as are > Maintainers, so no, fundamentally they are treated the same by a > Submitter. > > Here is some output for Maintainers/Reviews from get_maintainer.pl. > > $ ./scripts/get_maintainer.pl -f arch/arm/boot/dts/vf500.dtsi > Shawn Guo (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE) > Sascha Hauer (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE) > Stefan Agner (reviewer) > Russell King (maintainer:ARM PORT) > linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE VYBRID ARM ARCHITECTURE) > devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) > linux-kernel@vger.kernel.org (open list) > > I'm sure we can make the output even more similar by listing the > MAINTAINERS tag after "reviewer" too. And here is the output of drivers/mfd/sec-core.c *before*: Sangbeom Kim (supporter:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS) Krzysztof Kozlowski (supporter:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS) Lee Jones (supporter:MULTIFUNCTION DEVICES (MFD)) and after (where I am listed as reviewer): Sangbeom Kim (reviewer) Krzysztof Kozlowski (reviewer) Lee Jones (supporter:MULTIFUNCTION DEVICES (MFD)) Maybe it should be "supporter reviewer"? Best regards, Krzysztof