From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965626AbbJ1Nb4 (ORCPT ); Wed, 28 Oct 2015 09:31:56 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34852 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753221AbbJ1Nby (ORCPT ); Wed, 28 Oct 2015 09:31:54 -0400 Subject: Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC To: Alexandre Belloni References: <1445863883-5187-1-git-send-email-alim.akhtar@samsung.com> <1445863883-5187-6-git-send-email-alim.akhtar@samsung.com> <56302514.4090407@samsung.com> <20151028015323.GZ28319@sirena.org.uk> <56303054.8060804@samsung.com> <56303DA3.5020306@samsung.com> <5630419F.1000300@samsung.com> <20151028094853.GM22331@piout.net> Cc: k.kozlowski.k@gmail.com, Alim Akhtar , Mark Brown , lee.jones@linaro.org, mturquette@baylibre.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-ID: <5630CE44.7070204@samsung.com> Date: Wed, 28 Oct 2015 22:31:48 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151028094853.GM22331@piout.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org W dniu 28.10.2015 o 18:48, Alexandre Belloni pisze: > On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : >> The s2mps13 clock driver added new name and compatible... which was >> probably totally unneeded (I missed that during review). We don't have >> to make this as a rule... >> >> Since we do not have any data about future workarounds and the >> differences then just follow Ockham's razor - use the same name and >> compatible. >> > > So you don't care about DT backward compatibility because when a > workaround will be needed for one of the IPs, then you will have to > update the old dtb to use it. Nope, DTB does not contain the name for RTC driver (s2mps15-rtc). It will be exactly the same. > > Unless you are sure that the IP is the same, doing > > { "s2mps15-rtc", S2MPS14X }, > > is probably the best way to handle that. Note that I personally don't > care about the DT ABI, I'm just pointing out what may happen ;) In case of RTC driver there is no chance of DT ABI issues here. The clock driver is different because it contain a compatible. Best regards, Krzysztof