From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755912AbbJ1SM3 (ORCPT ); Wed, 28 Oct 2015 14:12:29 -0400 Received: from mail-bn1on0066.outbound.protection.outlook.com ([157.56.110.66]:44256 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751673AbbJ1SM1 (ORCPT ); Wed, 28 Oct 2015 14:12:27 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0NWXZWL-07-2OF-02 X-M-MSG: Subject: Re: [PATCH V4 7/8] PCI: OF: Move of_pci_dma_configure() to pci_dma_configure() To: Hanjun Guo , , , , , References: <1445442731-28819-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1445442731-28819-8-git-send-email-Suravee.Suthikulpanit@amd.com> <562B36EC.3040406@huawei.com> CC: , , , , , Murali Karicheri , , , From: Suravee Suthikulpanit Message-ID: <56311004.6090809@amd.com> Date: Wed, 28 Oct 2015 13:12:20 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <562B36EC.3040406@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(189002)(24454002)(199003)(164054003)(479174004)(92566002)(59896002)(50466002)(65956001)(23746002)(53416004)(101416001)(5004730100002)(87936001)(5007970100001)(47776003)(106466001)(54356999)(64126003)(5008740100001)(76176999)(105586002)(65816999)(11100500001)(87266999)(65806001)(83506001)(50986999)(5003600100002)(99136001)(36756003)(117636001)(4001350100001)(189998001)(2201001)(86362001)(2950100001)(5001770100001)(5001920100001)(77096005)(97736004)(62816006);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0713;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0713;2:B7R+HAQhk7xH6Kuxbx5Cgl+l7ztQzBm6D+H211VsqwO10nP9Ab430VO5ZRlRYgqdEIaGhz7EaS+aBFZF/aD8WgrjxKxglEyocuHnb3Qyo8EXWgOVe2WG9wZg3/K/SsuK/r2V6pzePkCQRvyDYRVke7YhHeJJ/n6xGWGvY6KEUJc=;3:pArzEo1lwCSoTjqGBmGFKrsd+H1L24KftRb+LF2Ofr/J6Se+ue9O4UFkMeY2fxxTxs6YmAJdI5Dq+bNBB8XP3UWqp2vMK3iNKVIqPEg7ufzHqOcGCEjGOIpSSrRr2B4kHDxgLPvpk+yeCrUYw5N2RK7avsIvNKFUwmNDGRhLXOTwRH730KPQwcspNrw6Ot/37ZDZ5kyh1+ReGIN99QUCR7vjcn7JjAkd9cwKv6/J21+R6LbNitfHYicCVKcxWrEr;25:QDVnAnl0uynE4lDZ71Gztny2TIP863cNZqfxNbw/DegrVuFSCmH1FadXDDXezCaWT4VOck7v62FEWKqrf17gpSow7hvr0ZPxsRBtOkA1ax0Bdv8s6+slehJ37qtajEb0EXebP9pTfADV1LhqB6lXn8jNqD2/7ZvkR88MJF+D1B2uZOMlHKN7gyC8mfwAdnDpqIX+aJAperm6SdCkbbPnsVnoOpN8AEg8UoCrgbXyQzSEhQ2489Gc5BjWBtAHr4V77ViwLYkoikXh7YigrEGNWA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0713; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0713;20:xkjsyH2pvrnyAwr0/VTxtnQWN3+GRDk//OjFxg1jfV81/umS4EVQVH7oUtcuEqkE+ql6AVt7Ru7E27d9pgbb2t3LrlrSXnyR/sNzXXxg3TpSyFhHHYbkgd1vvHLFNqoscmda2SVvp9ejXSwzOij2ZJXUKqvoILGk7yjQDmrI2xAc+wX6/A4GoZ11oGqe6LLG0px6kFKK2b2nIShJOl8byrkkmq33v1h5Mlb3iVUKcgSZgeoyGQ+mzll3iXT3FaKU8dgFsLPtLZcPenpKsUedDTVMJGHypaaeSHHMXbBUW9UQfFVTgTzW7A8QZVAOKzHHYDGbQkFOOnDgDYCuRS+9vQy0RNoLuUKLFLN8OIaQYl1+FC5Bh3eDnTYN/dZIeGo6ImFydYaI+wP3SvIRYs9aRqUXLQC4khAq8+6My1xxnT9yP0crmfREV/z9cLb6PDFLFsGnfSrxwmHgpY5fXe9nMUrC/a5+zvdysj9mK5rgcPc7XHJNZPEdYK8BxqscDgZ8;4:CdiNk70dh6luHS/pgH8YRSFAzpQw2fcaCiYzuyxHX72+E6dd0MH8ySiAToJTziWRJi5ZTW/oTrGyfL0f0OmqsXBV57WB54mA1hQ61n2O2oIQkyAmyzFJjTeK9BdBtLuaIgm0PdPS/JTXER6Ir7lIiDzx8XxY+AVbHczCZiJibqlTHu//vuE+tM6jVivurTG5JqnGLnSYjyDb0uy//eQJw9y5O0txDg8ozTemoC0QQfZhW+1KB2xFpHcRF53ayEUhUD8/zsFK8uNe/Yrm5fy8L1/zzPA41CS5ETgL0KKuj1tRdn7AZ3ysSNtkrowExoCanE40TPBobBa5TQXlJ3xdUpdfaHNMQLBuoxwYqIpR3F6wIys9oZLa+EC/bdngwQycwThqrb3wtApahoOaFpci3A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001)(102215026);SRVR:CY1PR12MB0713;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0713; X-Forefront-PRVS: 0743E8D0A6 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR12MB0713;23:N82YGRDphokK0GyoVbBaWw4SDPLGSjbGa34W2?= =?Windows-1252?Q?bs74r68Cckpsl7Gq6jEOmMj87iTTqau4WxB+HGpRtUsshr8E42yPZ1va?= =?Windows-1252?Q?P2WrQ4x8gepwH1xDSvDFF+tGz318uzBGRvgJFk3RsdGyToTtJWasfUpj?= =?Windows-1252?Q?wY51ADUCGONUIbeKiM8fZ7WTogAlNXE4JqBmTu4NZah+PiYH9usXjuqm?= =?Windows-1252?Q?lZZaOGUOhERI+dvktoJi56b9amoy6LpSDV+ImPD0N5ibz1nAtvsugJZ4?= =?Windows-1252?Q?+gBOwg3FPw5MzGLzrlPIcYp0OchsigFJWZrU5p+i1QbZg7zonyQz0xIm?= =?Windows-1252?Q?bjW1Fyp7zPUdvBo8tDsxvliI4lSb4kr0pJ3N70drZPLYMzjdMKy8zBVz?= =?Windows-1252?Q?E1nyNaUAFaAogLFGYudqJA8vmfmQREnJwT57oGbotxyKOYwjYMjwrrfG?= =?Windows-1252?Q?ZmFBC95nK5ZAtnqg412dZyZWlnMZNKOp7mNUYH+sxeWqRgzQ56MTEvFt?= =?Windows-1252?Q?llaYZvq02nClI4IAHGxUs9cVkgwkRs9mWv6bqgnUX/2nKh6NYSJlg8tJ?= =?Windows-1252?Q?Mha5a2/xxVp6PQnaIb/oJPyB/rgu5yFtixj9VuKFwDB0USEqGXl/F1VG?= =?Windows-1252?Q?LNUuWwyBKcIKB7je5bdXvxeWAWPrQEvtr0iYWwjhMysx14PBbk1iejQc?= =?Windows-1252?Q?3oSBleyl5+d5ocjXZhQ5aQ7GN8/jeT6UaXchRHjxE6TPP2MLHEN59/a6?= =?Windows-1252?Q?p6hr74abG4F/HM67GfAo1wGqrItCIPeftXf0qvBNPrZgpofQ1fAqMAuf?= =?Windows-1252?Q?ILophbhKvxEOxDBupdo5EjoD8K8AwoAk7g/RKvLi0RhBF5/eiuB5De9d?= =?Windows-1252?Q?32lsSHU726inpn43peu5Wubmu+hQH+db5G/hOiockcmLg6Eo2viAeExM?= =?Windows-1252?Q?np/to+salE57uTtTkZJw0/SWj8Ik8dbLCMhc7WLOtpUf/sFu5WH0zF9t?= =?Windows-1252?Q?hIs3CqUY5AfyZ+Df5PTBHNS4iOZK/QvhAgBu8LFH0NhhY8M57K74OAnW?= =?Windows-1252?Q?cUkbLAYlLEIGZO0A1nC2Qz3ykNUXPl30l/ooUlUt4kLwTeuZeDj6LH+i?= =?Windows-1252?Q?ex/GpYbZEZTf5nUYjukuTzE3zZHZ44PIGh76QdJ/U6bkMWasS26E9oEN?= =?Windows-1252?Q?mGPdHlEOq01p5xUydQF2dIVS4m7g5ybCRM2bTO1afUkFAgl5l93jKNyP?= =?Windows-1252?Q?sYnaU4aYLizXsCEM4Qi4fkwGIoe5WnHu2JerredjPQ1jEWVO/gwrroUx?= =?Windows-1252?Q?u5P?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0713;5:U7DUM9vqfx+pSGS1k3H2nDjuoQbnVFWj9EtRRHbne/sUmNu96efSSbxYkqOwQxK4d8+UeY/AOk3u2H+woIrIaI1k629x2JzVE9xShhfK3d+iKj88tujDJyG4KJebGCfiB8jM59XmbQmB+zLa+oF0sQ==;24:NsJMxdf1SN08Iq/sGAkE9FuGl35Ss84e5r4iElRR1xjTBJzjURahzT2H3ZYi/NBQmDhsmVXz30fpqdY2NxV8KKCnYbsio8gXZO4TwrvQgCM=;20:mM+g95gKN1E0bqRflhJgCVcZFUAXq544pVL6IXZoAsoqC6S7mp926zNIZtuUjk+oCpZ2xf5mBPcleiIzNYlj6PjxsHpVfOlkhJnXXMLNB4StwwPevvTK0V1qzFJY15pDttQnsvc4yQlylNiw2VpWW4dgIzlJHlYlmTyZF+FSIIXOsS3hw9Yd9+GW7yz4iMQxDZqzoMhevRVUTNv7oKaWthrN3kCQdIYFnIi4CeINXL3HPkw12QrTsTzJZyetrHKX SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2015 18:12:22.7422 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0713 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hanjun, On 10/24/15 02:44, Hanjun Guo wrote: > Hi Suravee, > > Some minor comments below: > > On 2015/10/21 23:52, Suravee Suthikulpanit wrote: > [...] >> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c >> index eea8b42..09264f8 100644 >> --- a/drivers/pci/probe.c >> +++ b/drivers/pci/probe.c >> @@ -6,12 +6,14 @@ >> #include >> #include >> #include >> -#include >> +#include > > Seems it's needed for GICv2m patch but not this one? This one is needed since we are making use of the new of_dma_configure instead of the of_pci_dma_configure. > >> #include >> #include >> #include >> #include >> #include >> +#include > > I think acpi.h should be introduced by the next patch. You are right. I'll update this one. > >> +#include > > And property.h is also not needed for this patch set. You are right. I'll remove this Thanks, Suravee