Re: [PATCH 2/3] ARM: dts: qcom: pm8226: add PON device node along with resin sub-node

Luca Weiss
2022-12-26T12:11:41Z

On Freitag, 23. Dezember 2022 20:34:02 CET Rayyan Ansari wrote:
> The PON (Power On) device in PM8226 supports both the power key and
> resin (reset input).
> The reset input is usually connected to a physical volume up/down button.
>
> Signed-off-by: Rayyan Ansari <rayyan@ansari.sh>

Reviewed-by: Luca Weiss <luca@z3ntu.xyz>

> ---
> arch/arm/boot/dts/qcom-pm8226.dtsi | 24 +++++++++++++++++++-----
> 1 file changed, 19 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi
> b/arch/arm/boot/dts/qcom-pm8226.dtsi index d99532ea70b2..403324a35cf5
> 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -1,5 +1,6 @@
> // SPDX-License-Identifier: BSD-3-Clause
> #include <dt-bindings/iio/qcom,spmi-vadc.h>
> +#include <dt-bindings/input/linux-event-codes.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
>
> @@ -10,12 +11,25 @@ pm8226_0: pm8226@0 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - pwrkey@800 {
> - compatible = "qcom,pm8941-pwrkey";
> + pon@800 {
> + compatible = "qcom,pm8916-pon";
> reg = <0x800>;
> - interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> - debounce = <15625>;
> - bias-pull-up;
> +
> + pwrkey {
> + compatible = "qcom,pm8941-
pwrkey";
> + interrupts = <0x0 0x8 0
IRQ_TYPE_EDGE_BOTH>;
> + debounce = <15625>;
> + bias-pull-up;
> + linux,code = <KEY_POWER>;
> + };
> +
> + pm8226_resin: resin {
> + compatible = "qcom,pm8941-resin";
> + interrupts = <0x0 0x8 1
IRQ_TYPE_EDGE_BOTH>;
> + debounce = <15625>;
> + bias-pull-up;
> + status = "disabled";
> + };
> };
>
> smbb: charger@1000 {