From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756143AbbJ2BTB (ORCPT <rfc822;w@1wt.eu>);
	Wed, 28 Oct 2015 21:19:01 -0400
Received: from mga03.intel.com ([134.134.136.65]:16248 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751237AbbJ2BTA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 28 Oct 2015 21:19:00 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,212,1444719600"; 
   d="scan'208";a="837566770"
Subject: Re: [PATCH 01/12] usb: xhci: expose xhci extended capabilities via
 debugfs
To: Oliver Neukum <oneukum@suse.com>
References: <1446019243-5565-1-git-send-email-baolu.lu@linux.intel.com>
 <1446019243-5565-2-git-send-email-baolu.lu@linux.intel.com>
 <1446024421.15140.6.camel@suse.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: "Lu, Baolu" <baolu.lu@linux.intel.com>
Message-ID: <56317402.502@linux.intel.com>
Date: Thu, 29 Oct 2015 09:18:58 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1446024421.15140.6.camel@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 10/28/2015 05:27 PM, Oliver Neukum wrote:
>> +static int fill_buffer(struct debug_buffer *buf)
>> >+{
>> >+	int ret;
>> >+
>> >+	if (buf->output_buf)
>> >+		return -EINVAL;
>> >+
>> >+	buf->alloc_size = PAGE_SIZE;
>> >+	buf->output_buf = vmalloc(buf->alloc_size);
> That really makes no sense. If you allocate exactly
> PAGE_SIZE, you should allocate a page.

Yes, I will change it in v2.

>
> 	Regards
> 		Oliver

Thanks,
Baolu

>
>
>