From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756563AbbJ2BYW (ORCPT ); Wed, 28 Oct 2015 21:24:22 -0400 Received: from mga02.intel.com ([134.134.136.20]:12791 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754963AbbJ2BYU (ORCPT ); Wed, 28 Oct 2015 21:24:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,212,1444719600"; d="scan'208";a="589998335" Subject: Re: [PATCH 11/12] usb: serial: usb_debug: add support for dbc debug device To: Johan Hovold References: <1446019243-5565-1-git-send-email-baolu.lu@linux.intel.com> <1446019243-5565-12-git-send-email-baolu.lu@linux.intel.com> <20151028091019.GB28572@localhost> Cc: Mathias Nyman , Greg Kroah-Hartman , Alan Stern , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: "Lu, Baolu" Message-ID: <56317542.9000807@linux.intel.com> Date: Thu, 29 Oct 2015 09:24:18 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151028091019.GB28572@localhost> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/2015 05:10 PM, Johan Hovold wrote: > On Wed, Oct 28, 2015 at 04:00:42PM +0800, Lu Baolu wrote: >> This patch add dbc debug device support in usb_debug driver. >> >> Signed-off-by: Lu Baolu >> --- >> drivers/usb/serial/usb_debug.c | 29 ++++++++++++++++++++++++++--- >> 1 file changed, 26 insertions(+), 3 deletions(-) > >> +static struct usb_serial_driver dbc_device = { >> + .driver = { >> + .owner = THIS_MODULE, >> + .name = "xhci_dbc", >> + }, >> + .id_table = dbc_id_table, >> + .num_ports = 1, >> + .bulk_out_size = 1024, > No need to set this unless you need a larger (or smaller for ehci) > buffer than the endpoint size. I will remove it in v2. Thanks for pointing this out. > > Johan > Thanks, Baolu