From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756660AbbJ2F5S (ORCPT ); Thu, 29 Oct 2015 01:57:18 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:58655 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750889AbbJ2F5R (ORCPT ); Thu, 29 Oct 2015 01:57:17 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-84-5631b53ad106 Subject: Re: [PATCH v4 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC To: Alim Akhtar , lee.jones@linaro.org, broonie@kernel.org References: <1446094723-6212-1-git-send-email-alim.akhtar@samsung.com> <1446094723-6212-2-git-send-email-alim.akhtar@samsung.com> Cc: linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Thomas Abraham , devicetree@vger.kernel.org From: Krzysztof Kozlowski Message-id: <5631B537.1090404@samsung.com> Date: Thu, 29 Oct 2015 14:57:11 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1446094723-6212-2-git-send-email-alim.akhtar@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrMLMWRmVeSWpSXmKPExsVy+t/xy7pWWw3DDI7P4LF4MG8bm8XUh0/Y LOYfOcdq8fqFocX9r0cZLS7vmsNmMeP8PiaL/Z0djBYdyxgdOD32TDzJ5rFpVSebx51re9g8 +rasYvT4vEkugDWKyyYlNSezLLVI3y6BK+P13ZWMBT+kKpbvXcHawHhQtIuRk0NCwETix9Mp jBC2mMSFe+vZuhi5OIQEljJKfFjeyg7hfGGUaG2ZzA5SJSwQLXF553dmEFtEIFRixvwHzBBF zYwSqzZdZgNJMAssZ5RYutMSxGYTMJbYvHwJWJxXQEti7usmFhCbRUBV4virE2BDRQUiJCZO aGCFqBGU+DH5HlgNp4C7xMWT+4F6OYBm6kncv6gFMV5eYvOat8wTGAVmIemYhVA1C0nVAkbm VYyiqaXJBcVJ6bmGesWJucWleel6yfm5mxghQf9lB+PiY1aHGAU4GJV4eBcYGYYJsSaWFVfm HmKU4GBWEuGVZgEK8aYkVlalFuXHF5XmpBYfYpTmYFES5527632IkEB6YklqdmpqQWoRTJaJ g1OqgZFxykqe+h+T/iicWbRZrZ0jIWGSktOPiafeKDD8lHM7VeE8YW1RJqtKvfG7Ow99ZNbK rffgfHFfapWhqlVv2bWcdWdXPPW7WyLzy6nzjJXyy8qUmZ+sv6i/0En9e+/Gi47NAVJz2Bsf TbvRwy2x6m9Pc+7HxMXNS1R6jD/l3+70X6Cirrk1WkeJpTgj0VCLuag4EQADcCQGdgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.10.2015 13:58, Alim Akhtar wrote: > From: Thomas Abraham > > Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device > is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Thomas Abraham > Signed-off-by: Alim Akhtar > Reviewed-by: Krzysztof Kozlowski > Acked-by: Lee Jones > --- > Documentation/devicetree/bindings/mfd/s2mps11.txt | 23 ++++++++++++++------- > 1 file changed, 15 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt > index 890f0b0e1643..c0427c9d0886 100644 > --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt > +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt > @@ -1,5 +1,5 @@ > > -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current Regulator > +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator > > The Samsung S2MPS11 is a multi-function device which includes voltage and > current regulators, RTC, charger controller and other sub-blocks. It is > @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C interface. Each sub-block is > addressed by the host system using different I2C slave addresses. > > Required properties: > -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps13-pmic" > - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". > +- compatible: Should be one of the following > + - "samsung,s2mps11-pmic" > + - "samsung,s2mps13-pmic" > + - "samsung,s2mps14-pmic" > + - "samsung,s2mps15-pmic" > + - "samsung,s2mpu02-pmic". > - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. > > Optional properties: > @@ -24,7 +28,7 @@ Optional properties: > unwanted buck warm reset (setting buck voltages to default values). > > Optional nodes: > -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 > +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide three(AP/CP/BT) buffered 32.768 > KHz outputs, so to register these as clocks with common clock framework > instantiate a sub-node named "clocks". It uses the common clock binding > documented in : > @@ -37,12 +41,13 @@ Optional nodes: > the clock which they consume. > Clock ID Devices > ---------------------------------------------------------- > - 32KhzAP 0 S2MPS11, S2MPS13, S2MPS14, S5M8767 > - 32KhzCP 1 S2MPS11, S2MPS13, S5M8767 > - 32KhzBT 2 S2MPS11, S2MPS13, S2MPS14, S5M8767 > + 32KhzAP 0 S2MPS11, S2MPS13, S2MPS14, S2MPS15, S5M8767 > + 32KhzCP 1 S2MPS11, S2MPS13, S2MPS15, S5M8767 > + 32KhzBT 2 S2MPS11, S2MPS13, S2MPS14, S2MPS15, S5M8767 > > - compatible: Should be one of: "samsung,s2mps11-clk", "samsung,s2mps13-clk", > - "samsung,s2mps14-clk", "samsung,s5m8767-clk" > + "samsung,s2mps14-clk", "samsung,s2mps15-clk", > + "samsung,s5m8767-clk" Noooo. Why "samsung,s2mps15-clk"? Adding a new compatible to bindings is a major change so my review tag (from v1 where there was no such compatible) should be dropped. Please drop it. Best regards, Krzysztof