From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755964AbbJ2HsT (ORCPT ); Thu, 29 Oct 2015 03:48:19 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:44340 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751218AbbJ2HsQ (ORCPT ); Thu, 29 Oct 2015 03:48:16 -0400 X-AuditID: cbfee68d-f79ae6d00000149a-f2-5631cf36c4df Message-id: <5631CF63.3070204@samsung.com> Date: Thu, 29 Oct 2015 13:18:51 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , lee.jones@linaro.org, broonie@kernel.org Cc: linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Thomas Abraham , devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC References: <1446094723-6212-1-git-send-email-alim.akhtar@samsung.com> <1446094723-6212-2-git-send-email-alim.akhtar@samsung.com> <5631B537.1090404@samsung.com> In-reply-to: <5631B537.1090404@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWyRsSkTtfsvGGYweYp3BZTHz5hs5h/5Byr xesXhhb3vx5ltLi8aw6bxYzz+5gs9nd2MFp0LGN04PDYM/Ekm8emVZ1sHneu7WHz6NuyitHj 8ya5ANYoLpuU1JzMstQifbsEroyL256zFMySqfi8s5G5gfGUWBcjJ4eEgInE8j+LWCBsMYkL 99azdTFycQgJrGCU2DFzJStM0ZTjW5ggEksZJZb8eMcK4TxglGhZcpEJpIpXQEvi67yvzCA2 i4CqRNPTd2wgNpuAtsTd6SDdHByiAhESjy8IQZQLSvyYfI8FJCwiECvx64sOSJhZYDmjxNKd liC2sEC0xOWd35khVi1hlJjS/hPsIE6gkbMuXmKEaLCVWPB+HQuELS+xec1bsAYJgUvsEru7 ZjJB3CMg8W3yIbBlEgKyEpsOMEM8JilxcMUNlgmMYrOQnDQLydhZSMYuYGRexSiaWpBcUJyU XmSoV5yYW1yal66XnJ+7iREYfaf/PevdwXj7gPUhRgEORiUe3gVGhmFCrIllxZW5hxhNga6Y yCwlmpwPjPG8knhDYzMjC1MTU2Mjc0szJXFeRamfwUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4 pRoYZbf84rxq/PiAo8CHpITtcouyKn2Wdb+JbOxP0+vnEvl8RnOWd9+B6zuactYXFR21etSl cpFH4dXfXU2XBDxy9Ddy/f7Z9P/Cta2ZzzQYxcQuWk8P/vqjJmknn0iV4JOPXyr2/9oW+UBq Tm6D0iGVNutzG+/tOeY5+8eDhi06cxM0bPftOSr0WImlOCPRUIu5qDgRAEVPBju5AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsVy+t9jAV2z84ZhBn8SLKY+fMJmMf/IOVaL 1y8MLe5/PcpocXnXHDaLGef3MVns7+xgtOhYxujA4bFn4kk2j02rOtk87lzbw+bRt2UVo8fn TXIBrFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5 QJcoKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwlrGDMubnvOUjBLpuLzzkbm BsZTYl2MnBwSAiYSU45vYYKwxSQu3FvP1sXIxSEksJRRYsmPd6wQzgNGiZYlF8GqeAW0JL7O +8oMYrMIqEo0PX3HBmKzCWhL3J0OMomDQ1QgQuLxBSGIckGJH5PvsYCERQRiJX590QEJMwss Z5RYutMSxBYWiJa4vPM7M8SqJYwSU9p/soIkOIFGzrp4iRGiwVZiwft1LBC2vMTmNW+ZJzAK zEKyYhaSsllIyhYwMq9ilEgtSC4oTkrPNcxLLdcrTswtLs1L10vOz93ECI7vZ1I7GA/ucj/E KMDBqMTDu8DIMEyINbGsuDL3EKMEB7OSCK80C1CINyWxsiq1KD++qDQntfgQoykwDCYyS4km 5wNTT15JvKGxibmpsamliYWJmaWSOO+FDI0wIYH0xJLU7NTUgtQimD4mDk6pBkYzjumVey1f TTjbxjDTzODK/3e13bv1YxZ2/2VIF2Be7+Kx9d5tHQtB0/8HArrVX5fZbju45O5lO4ks39CV t2oyjyen/yp4eKt2szzfxI0qkS664X9TCtWenIj5Mje9cdnkRNU4TcP3nTKzKk12B5f6ziq6 +a6+2iqlaMvDh+8ne02fIPNz514lluKMREMt5qLiRAD2Rx3VBQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/2015 11:27 AM, Krzysztof Kozlowski wrote: > On 29.10.2015 13:58, Alim Akhtar wrote: >> From: Thomas Abraham >> >> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device >> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. >> >> Cc: devicetree@vger.kernel.org >> Signed-off-by: Thomas Abraham >> Signed-off-by: Alim Akhtar >> Reviewed-by: Krzysztof Kozlowski >> Acked-by: Lee Jones >> --- >> Documentation/devicetree/bindings/mfd/s2mps11.txt | 23 ++++++++++++++------- >> 1 file changed, 15 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt >> index 890f0b0e1643..c0427c9d0886 100644 >> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt >> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt >> @@ -1,5 +1,5 @@ >> >> -* Samsung S2MPS11, S2MPS13, S2MPS14 and S2MPU02 Voltage and Current Regulator >> +* Samsung S2MPS11/13/14/15 and S2MPU02 Voltage and Current Regulator >> >> The Samsung S2MPS11 is a multi-function device which includes voltage and >> current regulators, RTC, charger controller and other sub-blocks. It is >> @@ -7,8 +7,12 @@ interfaced to the host controller using an I2C interface. Each sub-block is >> addressed by the host system using different I2C slave addresses. >> >> Required properties: >> -- compatible: Should be "samsung,s2mps11-pmic" or "samsung,s2mps13-pmic" >> - or "samsung,s2mps14-pmic" or "samsung,s2mpu02-pmic". >> +- compatible: Should be one of the following >> + - "samsung,s2mps11-pmic" >> + - "samsung,s2mps13-pmic" >> + - "samsung,s2mps14-pmic" >> + - "samsung,s2mps15-pmic" >> + - "samsung,s2mpu02-pmic". >> - reg: Specifies the I2C slave address of the pmic block. It should be 0x66. >> >> Optional properties: >> @@ -24,7 +28,7 @@ Optional properties: >> unwanted buck warm reset (setting buck voltages to default values). >> >> Optional nodes: >> -- clocks: s2mps11, s2mps13 and s5m8767 provide three(AP/CP/BT) buffered 32.768 >> +- clocks: s2mps11, s2mps13, s2mps15 and s5m8767 provide three(AP/CP/BT) buffered 32.768 >> KHz outputs, so to register these as clocks with common clock framework >> instantiate a sub-node named "clocks". It uses the common clock binding >> documented in : >> @@ -37,12 +41,13 @@ Optional nodes: >> the clock which they consume. >> Clock ID Devices >> ---------------------------------------------------------- >> - 32KhzAP 0 S2MPS11, S2MPS13, S2MPS14, S5M8767 >> - 32KhzCP 1 S2MPS11, S2MPS13, S5M8767 >> - 32KhzBT 2 S2MPS11, S2MPS13, S2MPS14, S5M8767 >> + 32KhzAP 0 S2MPS11, S2MPS13, S2MPS14, S2MPS15, S5M8767 >> + 32KhzCP 1 S2MPS11, S2MPS13, S2MPS15, S5M8767 >> + 32KhzBT 2 S2MPS11, S2MPS13, S2MPS14, S2MPS15, S5M8767 >> >> - compatible: Should be one of: "samsung,s2mps11-clk", "samsung,s2mps13-clk", >> - "samsung,s2mps14-clk", "samsung,s5m8767-clk" >> + "samsung,s2mps14-clk", "samsung,s2mps15-clk", >> + "samsung,s5m8767-clk" > > Noooo. Why "samsung,s2mps15-clk"? > > Adding a new compatible to bindings is a major change so my review tag > (from v1 where there was no such compatible) should be dropped. Please > drop it. > My bad, will drop it. > Best regards, > Krzysztof > >