From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755239AbbJ2INu (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Oct 2015 04:13:50 -0400
Received: from mailout4.w1.samsung.com ([210.118.77.14]:64218 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750980AbbJ2INp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Oct 2015 04:13:45 -0400
X-AuditID: cbfec7f4-f79c56d0000012ee-01-5631d5377ee0
Subject: Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15
 regulators
To: Lee Jones <lee.jones@linaro.org>, Alim Akhtar <alim.akhtar@samsung.com>
References: <1446094723-6212-1-git-send-email-alim.akhtar@samsung.com>
 <1446094723-6212-4-git-send-email-alim.akhtar@samsung.com>
 <20151029080835.GM4058@x1>
Cc: broonie@kernel.org, linux-samsung-soc@vger.kernel.org,
        rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
        Thomas Abraham <thomas.ab@samsung.com>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <5631D533.6070807@samsung.com>
Date: Thu, 29 Oct 2015 17:13:39 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-version: 1.0
In-reply-to: <20151029080835.GM4058@x1>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPLMWRmVeSWpSXmKPExsVy+t/xq7rmVw3DDE78FbR4MG8bm8XUh0/Y
	LF6/MLS4//Uoo8XlXXPYLGac38dksb+zg9GiYxmjA4fHnokn2Tw2repk87hzbQ+bR9+WVYwe
	nzfJBbBGcdmkpOZklqUW6dslcGV8vdDIVPCas2Lf0WPMDYz/2bsYOTkkBEwkliz4xwxhi0lc
	uLeerYuRi0NIYCmjxIrfq5ghnC+MEnt+X2YDqRIWCJFYsPYmmC0i4C3x9l0LVNECRonfn2aA
	OcwC8xklzh76xQhSxSZgLLF5+RKwDl4BLYlzj+aAxVkEVCW+bjzHCmKLCkRITJzQwApRIyjx
	Y/I9FhCbU0BdYua/HiCbA2iousSUKbkgYWYBeYnNa94yT2AUmIWkYxZC1SwkVQsYmVcxiqaW
	JhcUJ6XnGuoVJ+YWl+al6yXn525ihAT7lx2Mi49ZHWIU4GBU4uFdYGQYJsSaWFZcmXuIUYKD
	WUmEV5oFKMSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC6YklqdmpqQWpRTBZJg5OqQZG
	DRuB7/kvGqqvC9/cIPhTNvz3SqHI+5r9ihEJsy8fn10oXNB04MJEodh5TU3V9u5Z/lsmyi9e
	KTfZTMzpXty1Wfs1ctq+LEhN/u/Y3Jr57Gvf+zlHk+e9sFi0+FvQgmM3XopM0LVyK1gWGZ62
	miXG3YDrUERi9Xl1zXSpDVuZl/9WzvtjxXFaiaU4I9FQi7moOBEApHos53ICAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 29.10.2015 17:08, Lee Jones wrote:
> On Thu, 29 Oct 2015, Alim Akhtar wrote:
> 
>> From: Thomas Abraham <thomas.ab@samsung.com>
>>
>> The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains
>> 27 LDO and 10 Buck regulators and allows programming these regulators via a
>> I2C interface. This patch adds initial support for LDO/Buck regulators of
>> S2MPS15 PMIC.
>>
>> Signed-off-by: Thomas Abraham <thomas.ab@samsung.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>>  drivers/regulator/Kconfig   |    4 +-
>>  drivers/regulator/s2mps11.c |  135 ++++++++++++++++++++++++++++++++++++++++++-
>>  2 files changed, 136 insertions(+), 3 deletions(-)
> 
> [...]
> 
>> @@ -1070,6 +1202,7 @@ static const struct platform_device_id s2mps11_pmic_id[] = {
>>  	{ "s2mps11-pmic", S2MPS11X},
>>  	{ "s2mps13-pmic", S2MPS13X},
>>  	{ "s2mps14-pmic", S2MPS14X},
>> +	{ "s2mps15-regulator", S2MPS15X},
>>  	{ "s2mpu02-pmic", S2MPU02},
>>  	{ },
>>  };
> 
> Are you going to s/pmic/regulator/ for the existing devices too?

Yeah, I expected that as well... but of course it is orthogonal to this
patchset.

Best regards,
Krzysztof