From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756833AbbJ2Ie2 (ORCPT ); Thu, 29 Oct 2015 04:34:28 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:55573 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756463AbbJ2Id6 (ORCPT ); Thu, 29 Oct 2015 04:33:58 -0400 X-AuditID: cbfee690-f794e6d0000014de-cf-5631d9f46c96 Message-id: <5631DA24.10303@samsung.com> Date: Thu, 29 Oct 2015 14:04:44 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Lee Jones Cc: broonie@kernel.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, Thomas Abraham Subject: Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15 regulators References: <1446094723-6212-1-git-send-email-alim.akhtar@samsung.com> <1446094723-6212-4-git-send-email-alim.akhtar@samsung.com> <20151029080835.GM4058@x1> <5631D533.6070807@samsung.com> In-reply-to: <5631D533.6070807@samsung.com> Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsWyRsSkVvfLTcMwg48vrSymPnzCZvH6haHF /a9HGS0u75rDZjHj/D4mi/2dHYwWHcsYHdg99kw8yeaxaVUnm8eda3vYPPq2rGL0+LxJLoA1 issmJTUnsyy1SN8ugStj0oyZrAXHuSt+rjzG3sC4jrOLkZNDQsBE4lBjHwuELSZx4d56ti5G Lg4hgRWMEr9Xv2eHKZqz7wMjRGIpo8TN9oXMIAkhgQeMEmsPWILYvAIaEssnXwGbxCKgKvHj 0xqwGjYBbYm707cwdTFycIgKREg8viAEUS4o8WPyPbByEYFQib3PZ4LNZxaYzyhx9tAvRpCE sECIxIK1N6Eu2s8ocXLqcbChnEBDL1xfAnYds4CZxKOWdcwQtrzE5jVvmUEaJATOsUscWD0b 6iIBiW+TD7GAXCEhICux6QAzxGeSEgdX3GCZwCg2C8lRs5CMnYVk7AJG5lWMoqkFyQXFSelF JnrFibnFpXnpesn5uZsYgVF3+t+zCTsY7x2wPsQowMGoxMO7wMgwTIg1say4MvcQoynQFROZ pUST84GxnVcSb2hsZmRhamJqbGRuaaYkzvta6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6p Bkbmg9y6a1N6+1/femVt9uRA2p1ndepzFtsHvknMiSphvLiwbaPh76KCnMVbCjzYDjkkdv6W lZV+toHfJ3zhKmsVx5SwIyU2R48sXzbJR07r+4TEm+/mHfmtut250r/YTMeS/7hw11HfDINf r0I0W68U2l/ZlRb3z09iympx8RT5bndm6U92vUosxRmJhlrMRcWJAK5dbTG1AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsVy+t9jAd0vNw3DDK50mFhMffiEzeL1C0OL +1+PMlpc3jWHzWLG+X1MFvs7OxgtOpYxOrB77Jl4ks1j06pONo871/awefRtWcXo8XmTXABr VAOjTUZqYkpqkUJqXnJ+SmZeuq2Sd3C8c7ypmYGhrqGlhbmSQl5ibqqtkotPgK5bZg7QFUoK ZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjEkzZrIWHOeu+LnyGHsD4zrO LkZODgkBE4k5+z4wQthiEhfurWfrYuTiEBJYyihxs30hM0hCSOABo8TaA5YgNq+AhsTyyVdY QGwWAVWJH5/WgNWwCWhL3J2+hamLkYNDVCBC4vEFIYhyQYkfk++BlYsIhErsfT6TEWQ+s8B8 Romzh36BLRYWCJFYsPYm1OL9jBInpx4HG8oJNPTC9SXsIDazgJnEo5Z1zBC2vMTmNW+ZJzAK zEKyZBaSsllIyhYwMq9ilEgtSC4oTkrPNcxLLdcrTswtLs1L10vOz93ECI7sZ1I7GA/ucj/E KMDBqMTDu8DIMEyINbGsuDL3EKMEB7OSCK/QDaAQb0piZVVqUX58UWlOavEhRlNgKExklhJN zgcmnbySeENjE3NTY1NLEwsTM0slcd4LGRphQgLpiSWp2ampBalFMH1MHJxSDYwCn84VXLv9 IkL+mV1L69aimyIVkX9VrpizbZ14LfFObG5OOecf9uosm5laYi2mCeE67Hk7ix/t0n8TYT5x hcTGV8ERPJmtSglzvPmFGmeH7v13cTqLXOvKOxGySnujlXzMHp9MsndY3u4+7YKRzLkVXTs0 L/Ht2GSQsmeZr/ZUXoZfOWnKqkosxRmJhlrMRcWJAP7AqTgCAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/29/2015 01:43 PM, Krzysztof Kozlowski wrote: > On 29.10.2015 17:08, Lee Jones wrote: >> On Thu, 29 Oct 2015, Alim Akhtar wrote: >> >>> From: Thomas Abraham >>> >>> The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains >>> 27 LDO and 10 Buck regulators and allows programming these regulators via a >>> I2C interface. This patch adds initial support for LDO/Buck regulators of >>> S2MPS15 PMIC. >>> >>> Signed-off-by: Thomas Abraham >>> Signed-off-by: Alim Akhtar >>> Reviewed-by: Krzysztof Kozlowski >>> --- >>> drivers/regulator/Kconfig | 4 +- >>> drivers/regulator/s2mps11.c | 135 ++++++++++++++++++++++++++++++++++++++++++- >>> 2 files changed, 136 insertions(+), 3 deletions(-) >> >> [...] >> >>> @@ -1070,6 +1202,7 @@ static const struct platform_device_id s2mps11_pmic_id[] = { >>> { "s2mps11-pmic", S2MPS11X}, >>> { "s2mps13-pmic", S2MPS13X}, >>> { "s2mps14-pmic", S2MPS14X}, >>> + { "s2mps15-regulator", S2MPS15X}, >>> { "s2mpu02-pmic", S2MPU02}, >>> { }, >>> }; >> >> Are you going to s/pmic/regulator/ for the existing devices too? > > Yeah, I expected that as well... but of course it is orthogonal to this > patchset. > Agree with Krzysztof here. Noted, will send a separate patch to rename other S2MPxxx-pmic to *-regulator. > Best regards, > Krzysztof > >