From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756687AbbJ2JCv (ORCPT ); Thu, 29 Oct 2015 05:02:51 -0400 Received: from mail-bn1bon0064.outbound.protection.outlook.com ([157.56.111.64]:42720 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755598AbbJ2JCr (ORCPT ); Thu, 29 Oct 2015 05:02:47 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH] pinctrl-zynq: Initialize early To: =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , "Mike Looijmans" , Linus Walleij References: <1445513420-23527-1-git-send-email-mike.looijmans@topic.nl> <20151022160733.GH5257@xsjsorenbubuntu> <5629C62D.8030804@topic.nl> <20151023054455.GU5257@xsjsorenbubuntu> CC: , From: Michal Simek Message-ID: <5631E019.5040906@xilinx.com> Date: Thu, 29 Oct 2015 10:00:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151023054455.GU5257@xsjsorenbubuntu> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21908.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD021;1:JKNVFpIQK09BBBo2DvO0hblFUqc8FCriLlOf7Fr6dHnQt9K5zXef2Z+4ukgK1mcVDDpIr1qAWKVfeOfRjesCS3/hwAK++x5+lyMM18J6II/L5Mw35J+suUE9NrAlljmzac6BO8IrVJnJWcQMaFU/wzbfDDR5rvIpb/jGqAgrX4aclHa5+NRcw2kT9MLUluSlrn+jrhKj1Gb6sHvVud/SlA01vOqHC53sgoGtBIfet7dxmjMZ92wYG2lELKJjR41+RUOMX9zYf9orlZ3VAdOWlQ/PaoENfU3htGWqMtx5acsdErSDMgmOAbeaZBfwIUNcq+ky2fEwphGmpEnKxYU3SLx+3v/QeUCtdpWYHx7QzPWc+4Hf1i0EQ8+8zzpUfIJCBNeDXbM7008bJRJ8Vo3SCg== X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(51914003)(479174004)(52044002)(164054003)(377454003)(199003)(24454002)(76104003)(377424004)(23676002)(6806005)(2950100001)(92566002)(16796002)(4001350100001)(63266004)(87936001)(11100500001)(50466002)(36386004)(5001770100001)(5008740100001)(5007970100001)(33656002)(77096005)(106466001)(54356999)(47776003)(50986999)(59896002)(19580395003)(76176999)(5001960100002)(19580405001)(80316001)(65816999)(93886004)(86362001)(36756003)(65956001)(83506001)(4001150100001)(65806001)(87266999)(189998001)(81156007)(64126003)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1BFFO11HUB025;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB025;2:dHBUPjEGPjj0WxG6v+8vdhFFWlR0AXeNash5OvQ2WVSquc+sBU2y5HhXekYcKE/S6MAIFpYXhm3I3tc/dWkFhdGqofaxUTeBuhnXEHJpuHcezcp/uNjiy6FRj1U7QXFyQzLVGl1AUh8wWE21+Zze9WxiqSYMOZF7rfgmN6pIHdA=;3:/jeQ+AqbF6NhEjar7t6yJPItj6Fd/yvpf2ouewc40yUWpDahO8q+zVncK3yoUv3Xi+5Y4mdlnrjKAxwaRKSG0KzTpDbKwVmeGDsYW57lyJ4qA0EKFrH7RcK92LVGNntNZoqJF/rvmExMHbudf7HGxprsALIf9bNf1DfTGZJo3nBUiK+IrLjCN8GgEGBZ7ViquW0hFFq+vYUxgGGvyl1opfwIzJNJ0idb2MDYOJSuT6eAdHYKypOCHA/rPsK7PXtSwbuH2hxWvG0C+ACK2mxgMQ==;25:ALTQfKeQTvXhLPYZkHPFvRFOPUgggiN7QJtWO7jYEnvNbL9h4XmJfB++FcP6TOSwLp9g5FypKj56sUbyGspJVsM7XpThxh8LD+wlDptZGSf5R3n+H3uqbZFG9DPru5kG+O1sUAo4a6pUwpmmoi3jzUFWLhanHa7Wjgd5NFpJJv7/oerkOiipHFvFSjtE7GrPIH46JrQcckRqS2zBrpDGePK1iIYwEkhdjLp5HufZTOzJa2ApIRF7H2ajJtayhPjn2gmUvcZdYtC5qHTdEam0Aw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN1BFFO11HUB025; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB025;20:ysB3pruSaOslppIh7PqF9f+4RN6YdETwRi/sqVZeE8ZEHrW0g3XGJCeXT8CxWcHq2103Eu3OPa+S+PWfcVtDoL3xnTt4itt89C3BKMTZqRSwrjo/RR8Xkwptn+jxpLGxNXouFIkOeQqP9Dz0pQjcQTSrhQn8D9cjqXg+BSgg5F+atyj6YvX/4lx+Xh6D8gFcNOnMEIOImwmaUuDoZn6oFK5I4tuYbwBB01DvDtnEYso3zESIHCvvj6+DFA9Iu40vp759wau66G/H0D4npV1oK2C1IEr5AOqxqK7wqGwqCm5rbGfAvNss4p0CNfJdWnMxJy67pYwdmZ0RGBMhyWue0zrWRaFE98KZ1Qy1BfMYK6Mx/7efuq3xkPe/Er9tpXnmuF420zpJz+utBQfYjqBo7pM9nP5ufh6B+1C/z2ni5UY7YG/DHvb/WSGbw+Hd+tcLPtbP20q82nKgESEcj1CXmlopi+gxQz0vVQQtLN6yUn7bUgXvoxl0QmpEs9zAhMgo;4:fBbXymzgXxCaJ1J7a75RRinthNQRqe5fLy5TZmrrJLTuwGqNvFV1+JBHRN7Cq94r3cx1LMpmDuoS9nJVQodg1Gi75i4h+3UyZi8uxuehjOa/BflZdrpM9fYTv/IY7i7gYPNpc0DV0T62VvSCdJIhCCojdUw0Bs77Midf9QYXqXCveh8aRcML5r+0J07fZrrsDuMeqjQvrO3CrlZve1hyDCowUte5JvsSZ6QiGiaw5FYmAVCoVHCOayFKcvYpymdKlU3vzHGzc/eQuizD2JwN6yzUP8y4TLfVIJNCxDBBoWgxHPj9nA5tkcvg89KN71XZDhLGI4rMw0ePXoUGA9WD2817v8A57l9RekheC++jpd8woyMzc0JgXFiDhoUbFQwdq37nYzyl16PkNskvbIYFhQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046)(102215026);SRVR:BN1BFFO11HUB025;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB025; X-Forefront-PRVS: 0744CFB5E8 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFCRkZPMTFIVUIwMjU7MjM6UGtZaElyRGh0eUxNeHJYMWtYOXRzbXhN?= =?utf-8?B?dndEd0tQZGhSTUdCVm92eGtGQ0lhVVBYSkJ2S0k4V0ozUE5oU1dkRm42NTdX?= =?utf-8?B?ZWlsZGhyZXhUSFhPbVJ2eWV5SGt2SlJwbWVlVGtRdzBvWFM5Mnkrd01STjVk?= =?utf-8?B?dDdtWWg2N0tna3llKy95RnRqRkNZa2hrdVdJWHoybm9JSkRwNDdCT2Q4VUJC?= =?utf-8?B?YVlMbjA4aFA2OUI0NXc0LzJjeE5tNFRTK0tSaUk5QjU5YW5iUkNUcTI0cS9k?= =?utf-8?B?WHd3bFQyZXJxL05KV21URmJXMk90eXpQZnA1SmZkZkR6WHZkUFdPaVNmR2Zt?= =?utf-8?B?TjhvMGV1K0RsTjlzUno2S20wSFE5bE9aMkZ0bGxCdm5qM21Vd1ZOU05KTjZw?= =?utf-8?B?NUQxZUJsOSsrT1hleU84Y1lhL28xMGM5a0lNZEw0U3I4RStzdlpKYnZ1dzNJ?= =?utf-8?B?dEFvbm92MFpJNDVmbTYwWHNQejFIV0lvWE11eUcxVU5rbytqalBBOFB0SEJ4?= =?utf-8?B?VzIzdUlkb2d0REVlY1lBMmd1MlEreWZFMjhYSmpjcUFaYnZJKzhtVHVYZ2Q1?= =?utf-8?B?NjhGQ09BOEtxRkovMlNuNnFRTWFxeUNZT0NrMGFKNmNueWZyQkNkNW1vTDFP?= =?utf-8?B?T3BjTkwwcmEwc1FKYzBSK0NjeGthTDhZWmlzMlltc1pGd3d0MVdaeXFQNTNw?= =?utf-8?B?WE54YkZ1RUlYL08xNEtLSnFLM2lKMi9RcWR1VTBGTEhMQ1MwZFBlZm50dnJY?= =?utf-8?B?aTB6YTFVRVdjWGt1cGgzUjZaVUEzREVtZ2NkQ3NkUVpjZUVpUzR0NkRLeHN1?= =?utf-8?B?UERUc3FWaEFSMDBlNDdUWmZNTzh1OUdTbzVnZ3BwUVNvTTJMeWFweXBKSjhq?= =?utf-8?B?SktFelhGdXhJMHJaV0plcysvanlDajZ4NXl5SXVsYXVoOUZIVjZBY2c0cVpl?= =?utf-8?B?TnI5SnhSNTI2Z3FpT1NzY3ZDbytvdDFOeTNKR3g0NWZJT1Btenh6ZjBncmtk?= =?utf-8?B?QzB3amgyb25hU05IdmV5V1NkNTU4T2xiQ1NvbWFoVThtQTVjMzFseWFiSWt0?= =?utf-8?B?eU55ak1YdmxmWWFIcHRlRU01Z0poR2k1bkhpK0ErZ2owVGI3dWErazRMYlZN?= =?utf-8?B?SW1jSUVpbTBxdUdNUzNjVWxHSnJxSkpCWW5Nb05IMGhkZzhXa2lhcTRkMHRp?= =?utf-8?B?SnVmc1hzNEdweDRQV3h2SXQzZ2tvVDl2SUsyMEVaVUQvTEFhbFdWY1orU3pX?= =?utf-8?B?S09YdklBdnhValpwZjl0RGZmNmh5SVBlNktoV2dZQTVmYlk2TVhCWjgwT3A2?= =?utf-8?B?NUlBMGpodkV1c3BMd3puZ3cwWXU1L0NPRzlDQjVnSUJPMDN3WGM4Tk5WeCtk?= =?utf-8?B?SnN4RE9jN20wTE1uN1htM0ZuOHYrL0ZPanpvem4zNktUbnpRTjNGRW1ERUl4?= =?utf-8?B?RjNablp5UGdBa0lPSXg2aGkxTEFhSTdWdUZ6NHkxQTlaUUp5N0ZuZ2IzaFlJ?= =?utf-8?B?dnhkVnFlZk43WUhzbmg1ZzlHZFpYeDRGUkZvQUJxZ3FkRTdueUtEbENHQSt2?= =?utf-8?B?S2VUTTVKOXh3Y1hOZ3lkcndqeUk1bmF0RmpKWTZhV0hRc2dXc0tWK2Zudm9H?= =?utf-8?B?UVNyL3Z3bWNndUtWeDJjMWNWQnpsMWExa0VjY1p6Z0ZMbXZSKzQyVjZybjZW?= =?utf-8?B?eXFKR1lEYnlxbkl0U2k1Nno4RWZEcHZXUmNVSUVBSUZEbENJSStmZEZaK2ly?= =?utf-8?B?V1dRU3FqUWMxYzVuZjBjYUcreW5QK3VEY1dpV01lQXJrTUowbG1PZFpoeGxF?= =?utf-8?B?RnFFMi9HVURFNzNmZm4xOTEvaVRSaFdqb1hXU0xtL3Z5ZnVVRGE2VU5JbU5X?= =?utf-8?Q?NyRxHHrPq55gwi4EqeR41iHUBKBM4lTB9u?= X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB025;5:K+MlOrKmmx7LQI9sU2tHwOt8nt/RR+bifivoVlvbsKNixXu+6C4jolFf+P5q0+nA3syUpF9+eB31h8/KWvorTcp6oOqsui15WODpXlXmmBKqtlSrmjWnn41vbCLuuu3QYIXdVP4vDOFmUs0jxowGmQ==;24:zPEfxKBRB6BaiqsdARQeWCbZW/YeRU0ckso1yhsKjGyWMfQ6vywgj8buHGwekwEfrHKU0vSi1RYu5j++Wex/Ajc5n0Cna+yT9hffXl5KdC8= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2015 09:02:45.2413 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB025 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, On 10/23/2015 07:44 AM, Sören Brinkmann wrote: > On Fri, 2015-10-23 at 07:31AM +0200, Mike Looijmans wrote: >> On 22-10-15 18:07, Sören Brinkmann wrote: >>> Hi Mike, >>> >>> On Thu, 2015-10-22 at 01:30PM +0200, Mike Looijmans wrote: >>>> Supplying pinmux configuration for e.g. gpio pins leads to deferred >>>> probes because the pinctrl device is probed much later than gpio. >>>> Move the init call to a much earlier stage so it probes before the >>>> devices that may need it. >>>> >>>> Signed-off-by: Mike Looijmans >>> >>> in general, the change should be OK, but neither on zc702 nor zc706 do I >>> see a difference in respect to deferred probes. With and without the >>> patch I see: >>> root@zynq:~# dmesg | grep -i defer >>> [ 0.097021] zynq-gpio e000a000.gpio: could not find pctldev for node /amba/slcr@f8000000/pinctrl@700/gpio0-default, deferring probe >>> root@zynq:~# >>> >>> If you have a case this patch improves things though, feel free to add my >>> Tested-by: Sören Brinkmann >>> >> >> On the Florida boards there are i2c controlled clocks, power supplies and >> reset signals. Replacing the Cadence I2C controller with a GPIO-bitbang >> controller solved the I2C problems but caused a storm of dozens of deferred >> probes because of the pinmux driver arriving even after the first probe >> attempt of the i2c bus driver. Moving the pinmux driver to an earlier stage >> solved that problem neatly, now the "zynq-pinctrl 700.pinctrl: zynq pinctrl >> initialized" message appears after the OCM driver. > > OK, makes sense. Thanks for the background. > >> Judging from your comment the GPIO driver still probes earlier (I don't have >> any GPIO-only pinmuxes yet), so maybe we should amend the patch to probe >> even earlier. The pinmux driver doesn't depend on anything, so it can >> potentially probe very early. What do you think? > > I'm pretty neutral on this one :) Hasn't the probe deferral mechanism > been introduced to avoid having to create ordering through the initcall > stages? But I agree, having the probe deferral notices is not particularly > pretty. So, I'd definitely not oppose changing this. > Though, there is one dependency on the SLCR regmap, but that is initialized > fairly early. Any comment on this one? Thanks, Michal