public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	vivien.didelot@savoirfairelinux.com,
	Fabian Frederick <fabf@skynet.be>,
	Pavel Nakonechny <pavel.nakonechny@skitlab.ru>,
	Joe Perches <joe@perches.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Frode Isaksen <fisaksen@baylibre.com>
Subject: Re: [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling
Date: Thu, 29 Oct 2015 15:10:11 +0100	[thread overview]
Message-ID: <563228C3.6010501@baylibre.com> (raw)
In-Reply-To: <20151029135156.GQ2307@lunn.ch>

On 10/29/2015 02:51 PM, Andrew Lunn wrote:
> On Thu, Oct 29, 2015 at 02:22:41PM +0100, Neil Armstrong wrote:
> Hi Neil, Frode
> 
> I assume you have see:
> 
> http://permalink.gmane.org/gmane.linux.network/380777
> 
> which is now in net-next.
> 
> The only driver making use of poll_link is mv88e6060.c. The argument
> from removing it from the other mv88e6xxx drivers is that it is not
> needed. The phylib will be polling the phys and looking for state
> changes. mv88e6060.c implements phy_read() and phy_write() so it
> should also allow the use of phylib.
> 
> Could you try 6060 without .poll_link. If that works, we should be
> able to remove all this code, rather than fix it up.
> 
>      Andrew
> 
Hi Andrew,

Thanks for the hint, I will test this, but while reviewing the datasheet,
the port 5 has no PHY, so must only be used as cpu port.

I also have another patchset which fixes 2 setup registers writes and
adds a shiny new mv88e6060.h based on mv88e6xxx.h.
I think the removal of the poll_link in mv88e6060 should be in this patchset.

Neil

  reply	other threads:[~2015-10-29 14:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-29 13:22 [PATCH v2 1/6] net: dsa: Use delayed work instead of timer+work for polling Neil Armstrong
2015-10-29 13:51 ` Andrew Lunn
2015-10-29 14:10   ` Neil Armstrong [this message]
2015-10-29 14:40     ` Andrew Lunn
2015-10-29 14:52       ` Vivien Didelot
2015-10-29 15:28         ` Andrew Lunn
2015-10-30 15:44           ` Neil Armstrong
2015-10-30 16:30             ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563228C3.6010501@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=fabf@skynet.be \
    --cc=fisaksen@baylibre.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=netdev@vger.kernel.org \
    --cc=pavel.nakonechny@skitlab.ru \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox