From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965536AbbJ2Rd4 (ORCPT ); Thu, 29 Oct 2015 13:33:56 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:41951 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752703AbbJ2Rdy (ORCPT ); Thu, 29 Oct 2015 13:33:54 -0400 Subject: Re: [PATCHv2] btrfs: bugfix: handle FS_IOC32_{GETFLAGS,SETFLAGS,GETVERSION} in btrfs_ioctl To: Luke Dashjr , Chris Mason , David Sterba , , , References: <201510290822.26515.luke@dashjr.org> From: Josef Bacik Message-ID: <56325870.20506@fb.com> Date: Thu, 29 Oct 2015 13:33:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <201510290822.26515.luke@dashjr.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-29_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/29/2015 04:22 AM, Luke Dashjr wrote: > 32-bit ioctl uses these rather than the regular FS_IOC_* versions. They can > be handled in btrfs using the same code. Without this, 32-bit {ch,ls}attr > fail. > Looks good, thanks, Reviewed-by: Josef Bacik