From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757910AbbJ2U5W (ORCPT ); Thu, 29 Oct 2015 16:57:22 -0400 Received: from mail-bn1on0080.outbound.protection.outlook.com ([157.56.110.80]:18492 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757095AbbJ2U5T (ORCPT ); Thu, 29 Oct 2015 16:57:19 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <56328826.2020406@caviumnetworks.com> Date: Thu, 29 Oct 2015 13:57:10 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: David Daney , Bjorn Helgaas CC: , , "Michael S. Tsirkin" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , , "Sean O. Stalley" , , , , David Daney Subject: Re: [PATCH v6 1/5] PCI: Handle IORESOURCE_PCI_FIXED when sizing resources. References: <1445382282-2396-1-git-send-email-ddaney.cavm@gmail.com> <1445382282-2396-2-git-send-email-ddaney.cavm@gmail.com> In-Reply-To: <1445382282-2396-2-git-send-email-ddaney.cavm@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: BY2PR07CA050.namprd07.prod.outlook.com (10.141.251.25) To BN4PR07MB2129.namprd07.prod.outlook.com (25.164.63.11) X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;2:9zQNyFODqgy1QxbmbzYb6jGWSwqDvStBHZmu8RO2uM6jqQraGE9FuDGl9E1uKuQ9Jlyg5/HkSUXe6BU6szozAC9TYyP9u4z8KVi55BpRXI8LR8idvOrj+hbzlLfiA32k89VwaoXZD9WtpkWRX6peVSgkBIKJwK7m4VVJvHF9Dm8=;3:thqVpKsW/Nq/z9GhfTSqbSzElkY+ZP+Ry0sTRLFWzcuxlJbIekjgGON7DjPKfYP/3u09CVd11/xK9Wdq8DygZiKKMChqRZFPOlRf/Ww76hF4QI2hhUMYHstQ/Fp5TSQ/fRRL7Zg+xkClhLj2Qdjm5A==;25:Mi7cOH0xa0snoy7quTZCs5+ESC5BXFQgxI3Xfv+zM2/91Rx8GqGoOwutjsvd2dhocS5hC4O/kKjYcwoB0sdRUZC8Toc+b+DKeb0FEvC5vcvph/+Hh4ipsZXb3Yq1OA2VZelgF3TWWzD6VUfWTGcNPGfuqg3ud8X6CFAn3fkWdJLO0fPr1FrnL8GjRsD84ldgaf4XE9S/bbzkquQ+cdiGVBWcZl2fnT18BSVDbpRxXsEzC9WAhFiDCw/kLnt+vUR2r519NEZXx8C5KIFXIBDd4g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2129; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;20:IjgeSAcalJdfgqPxjC0vmebEqXvIlApaIDdhW/Er7JEo8TuFPlShrDtCveaYrt84VTyGgbfYG4WHBBhHtlzBax6nR5fSAofec8QpBSG0l7ko+ufSDBLyZtrl1L/Sa0qTFB0hLRLeDmSD/juGtDjL1NrLhy4/tRfRGw9Hmrgg+I6NwXQ1Qa8mo79oJ+C7KA4x/n1M5CxuM5xoBFx/CIxwLP5RvItN1DakDykjsuiKKK0t8EgGAGnRElHOEt1TEdxMF7V8ZGVkiTMMkACLtZhGGg5tf8+qT8tbEQEF28mqO7lJccHvAQTRzikAChu4AZpnRhjoEMHpxMJ89JE+sPm+nZl1cBc24ywj46pYjn/Tu8H1tL5/dvnJGgF6UwqIWM63BZrzBbSSY9n3Ik2ednh3EnIynNiTMchPDskG5cDu89WQ6PDUTaHftRG3YEwNyH3jWzkPuhDZHqdM1XpCo+/CKNWqf0AKkHDGvXXxUFCgFRjUGtXFE+My1yQluB2DJQTYqbyVyhab+DVdFF8hgWqrZIs9z/1zmPag4uNOvKl4xgKZtOvzOvrp9u44G8QXwKLjrqVubUzNHMz3jKer82OKmjjoTqmKQ2QBCpmE96L9KKg= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001)(102215026);SRVR:BN4PR07MB2129;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2129; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;4:VJZv4T3EMaMqErQHGPk0csLMF7jJ6JvOSS9Mp3TXykCmm8l9+CKwX5Ml77wu8wa2HCrP8ARYeGB1GIPNB7hQhnvnJcmCfkAjauku9smlX0An/nlDKo2M5VfEBasdulrJw7U2AbP8YJgjheU3RzpnfIXrkkPbv+ZEKck3W9ljyftsokwCTGb9fqwrebwEmkj3eVX0NkOWZa8uBASqTOBFxM2/7/mhbRtAs8aI6Fu9kzbX3ZOZTaLOJ7tn2hcjQX+BWHQ7Rjkr2yPSTwvOKA2RYfxD/i7K/A7xj+kTb+ksHkCqFhAfr8xua8kFKePV6wxiBPLjPjhvCOgLhmNKynCpG4aSkSIyYIB+CJ8YK+hInN/EOzwhWg25fsczdMpHpoc37bDVXCn5kJHeP9lF7C/6JQ== X-Forefront-PRVS: 0744CFB5E8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(377454003)(189002)(199003)(479174004)(65956001)(5008740100001)(19580405001)(53416004)(36756003)(122386002)(2950100001)(81156007)(64126003)(77096005)(65816999)(54356999)(50466002)(50986999)(97736004)(19580395003)(105586002)(5001960100002)(99136001)(4001350100001)(87266999)(106356001)(5001770100001)(47776003)(40100003)(5007970100001)(59896002)(69596002)(5004730100002)(83506001)(117636001)(76176999)(66066001)(42186005)(92566002)(87976001)(101416001)(189998001)(65806001)(23676002)(62816006);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2129;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjRQUjA3TUIyMTI5OzIzOm9nVFVtektMR1lLK0VlYWw0anJPVWNTVWlS?= =?utf-8?B?VzUrZGdNckNXbkpua1ZQNHBUcW05bXM0NVhrU3I0VG5pL0RJV2ZTZTZJTENV?= =?utf-8?B?UHA3NnBHODBSU1ViTllacktCWmx1QkhPNjlJQjFXSzZmS3hXTWxJV3BNejRa?= =?utf-8?B?NmhYNHg0VVNtSzJ2ZFc2TmFIZ3N0bHVCRlVNdWFxbzBWcGpiblQ3djRYQ1BB?= =?utf-8?B?M1RWUHhBUXY2amNCQmlEM2dwaFFQeDg4ZXlxNGZuV2RKWEZHN2FRY3VXTmdx?= =?utf-8?B?dThuS3BYRmswRWZWSHg4bTZWRkJuQ3N3ZzVLNHFDWWFRZ0pJbEdhd0huQW5I?= =?utf-8?B?VGp0QXRZcG5jNFlGUjFXdUdQZ1g2MS9qdXZtZi96UEZjL1BDcFMyVXNYYUZw?= =?utf-8?B?alpTV0hpcCs2aVhSS0ZRMGdaeG55S3N6a0pZTllhSDMxK1l0L0p4bWZMdWdC?= =?utf-8?B?N3Vydk85eEVmN0FBUFl1bnk5RkZZYlRkU1FXdUlVYzQyR29Wam5BWGVyczYx?= =?utf-8?B?TkhxSVduclp5UmsrbTNuUW5xTldnQ016S1BJenVQNXpJVUo5WmxsODlBMlhj?= =?utf-8?B?eDYwU3AzaUVxUVRONFNCL25sQTZUK2JhVzJNc05SSXBhblcxYSt5YkxNYVZQ?= =?utf-8?B?RHN4WUx5dmRlVHhnWTl1UzVabW1obTIwajRUaHUrYkhZRUhERTBqRWNRSVFB?= =?utf-8?B?aWtXaThENjUxSG5Va1Nwb2VRL2VacS9uY0tYWnhQRTdYYm1ybWRKQ2JvTjhp?= =?utf-8?B?Q2Q2WXgzT1VXM1ozVUs2STRXS0k5dFkvUzBmUjIxclZRbDVZaGo1Uk00Q1BS?= =?utf-8?B?R0NaOU5qaUlqMWFrMzI5V1FyZXFTVDV3bXh3dER4TjloRld5WFovNFlLTStU?= =?utf-8?B?czFKcnBQaXBaU0dmUUZ4T0RaQVh6UU9BOXY3T01EcGxVN0ZNQmgxNFJtZHF5?= =?utf-8?B?Ni8wR3NEZUZHTllEakFzVUIrcUd4SC9vMWRrenlhQzFzdlZJeTJBUWZhMXFr?= =?utf-8?B?RFcwVkZneU5yQ0R1ZXlBM1Y1Q251bnVlYjdHZFFkSVUzemVaTFBiOEs5dGgw?= =?utf-8?B?V1VDN1BsejdkeFFKbDl2YXZJeFJKVFFIOWsxSXNtMmZadnZHSERYNlhqRGxJ?= =?utf-8?B?Qlo4VEJjL3NkRGNBMXVKM25FSFQ2UkxvM3dMTDlXREJCTWZxUW5lZXVkb2hU?= =?utf-8?B?M2k4RXdhMXZaYkROUUtvMG1GZGorMmljRWFGVVlTalp3RU1yK2JEY2RBdVBN?= =?utf-8?B?clBpVy9JLzZla005VmV0TkhEVDc2TzJ2ZXhGTTlZclowVTZFNHVZZFNYcXhk?= =?utf-8?B?T2F5R3FkTVdBeHlvT2pOVWcxaEc0SDliell2R2t3eVlWWlpGQW1hb2NoK0dB?= =?utf-8?B?bWQvVVdFZzFRZVdDSnYzMEtTMWhqOXBENGNiQWtqTzVWT1pLQ1JvS3J5T2Qy?= =?utf-8?B?aGpibGh0Y2w0cklEM2F0N3grbGZoN2kybXZoL2ZDYUp3ZFdkRG8ybi9sT2dx?= =?utf-8?B?a2dZc0xjUmFEOGkwZ1EwaEcxRkVHcXJzYmUxbGFGTEFlSU56RGtWQzRMN1hv?= =?utf-8?B?eStxaUdvSXdLSmM3c1FFYkZ6UGpuL3o0SkRTMm80cm91ZjVPK0dUTkJleUxo?= =?utf-8?B?aWI4cGdML2Jid1dLTGVOZmxCM1p1TXo1UmNTVFVoQmFnNlVud1Zsdnp0cG1w?= =?utf-8?Q?f9gshD3qiQAa5i0KxI=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2129;5:dQK74iGSVw545HJCSvD4ajhxPR1MuI7fGSWCvw7x2g7GuoelwldUzKyK+I+KFyx6XNJzbt3t0xwDOiy4h9m3FRgN+Oj++7lTUTaoQpl9Knc5MJ+gs0gJOqnuNmQGqmhvTkvIhng63Ss0R8YmY6tAsA==;24:1hdCaoI1H2GRSfO4G+atLnDcyhSTXm694YoBtN37NEovUC6qry7gaEO0XpihnnZj7WbnqYclK4xWpRqpzD+iXiefuTDlL2Uca1k+WG+hHMw=;20:nZD9G0swFgYxhqg2MGbxcOYUfLPWtmK2WNra1kCvVno6JYApKWopsh3Kfrf3N2qive4rAoTZVePhOBc2+vDLeA== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Oct 2015 20:57:14.6277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2129 X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2260;2:MPKFkW9mboSqqFWfCcmRaW2UGu+BDF5Tqejucn9kzHUNkwl7fc/aJy6HtAjp0mZOfnMTTp6TFRlIxmDG5nwHGXGNbkZU3HLdK/v5m7TxcxJ+gs+qVfINefG7rHk//dHqmaH/sk5ClmejT/t9l7G7sN8nc5ldy1a8EmhJx8kct1o=;23:JeZviO+ylDfVp+rzB46OCyA7c5vX6JWCqxMrwOgaFeh5QVN8S/l/nDQeWocvaOz5NaEircyYI5B8t/jdUD/Xqwymw71fu8Ozh5m9zHxIcNl6kPm4O9bQF0aHtTIHJRKag5Iz/cup0pCAKwLGqTiawA/cZdE6zHzU0vTxZFfiG6nG3vHb/EQWT0y4rvgBnk1o X-OriginatorOrg: caviumnetworks.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bjorn, A small snafu... On 10/20/2015 04:04 PM, David Daney wrote: > From: David Daney > > The new Enhanced Allocation (EA) capability support (patches to > follow) creates resources with the IORESOURCE_PCI_FIXED set. Since > these resources cannot be relocated or resized, their alignment is not > really defined, and it is therefore not specified. This causes a > problem in pbus_size_mem() where resources with unspecified alignment > are disabled. > > So, in pbus_size_mem() skip IORESOURCE_PCI_FIXED resources, instead of > disabling them. > > Acked-by: Sean O. Stalley > Signed-off-by: David Daney > --- > drivers/pci/setup-bus.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c > index 508cc56..4dfef10 100644 > --- a/drivers/pci/setup-bus.c > +++ b/drivers/pci/setup-bus.c > @@ -1037,9 +1037,10 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask, > struct resource *r = &dev->resource[i]; > resource_size_t r_size; > > - if (r->parent || ((r->flags & mask) != type && > - (r->flags & mask) != type2 && > - (r->flags & mask) != type3)) > + if (r->parent || (r->flags | IORESOURCE_PCI_FIXED) || Should be: r->flags & IORESOURCE_PCI_FIXED With the erroneous '|', sizing of bridge resources can break. Q: How to fix this. A) Replace this patch entirely? B) A patch on top of this one? > + ((r->flags & mask) != type && > + (r->flags & mask) != type2 && > + (r->flags & mask) != type3)) > continue; > r_size = resource_size(r); > #ifdef CONFIG_PCI_IOV >