From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758108AbbJ2Wqd (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Oct 2015 18:46:33 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:39741 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757188AbbJ2Wqa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Oct 2015 18:46:30 -0400
Subject: Re: [PATCH] sparc64: Fix numa distance values
To: Sam Ravnborg <sam@ravnborg.org>
References: <1446077026-5598-1-git-send-email-nitin.m.gupta@oracle.com>
 <20151029185056.GA398@ravnborg.org>
Cc: sparclinux <sparclinux@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        Chris Hyser <chris.hyser@oracle.com>,
        Khalid Aziz <khalid.aziz@oracle.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        David Hildenbrand <dahi@linux.vnet.ibm.com>,
        Tony Luck <tony.luck@intel.com>,
        Santosh Shilimkar <santosh.shilimkar@oracle.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
From: Nitin Gupta <nitin.m.gupta@oracle.com>
Message-ID: <5632A1A9.9040301@oracle.com>
Date: Thu, 29 Oct 2015 15:46:01 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151029185056.GA398@ravnborg.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/29/2015 11:50 AM, Sam Ravnborg wrote:
> Small nit.
>
>> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
>> index 01d1704..ed3dfdd 100644
>> --- a/arch/sparc/include/asm/topology_64.h
>> +++ b/arch/sparc/include/asm/topology_64.h
>> @@ -31,6 +31,9 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
>>   	 cpu_all_mask : \
>>   	 cpumask_of_node(pcibus_to_node(bus)))
>>
>> +extern int __node_distance(int, int);
> We have dropped using "extern" for function prototypes.
>

ok, dropped extern here.

>> +#define node_distance(a, b) __node_distance(a, b)
>
> And had this be written as:
> #define node_distance node_distance

underscores here to separate macro name from function name
seems to be clearer and would also avoid confusing
cross-referencing tools.

> int node_distance(int, int);
>
> Then there had been no need for the leadign underscores.
>
> But as I said - only nits.
>
> 	Sam
>
Thanks for the review.
Nitin